From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: Question about display engine Date: Sat, 21 Sep 2019 23:55:51 +0200 Message-ID: <20190921215551.ruu6ji6sjpxydpng@Ergus> References: <83mufg5yn1.fsf@gnu.org> <20190908005109.s7hhcczkrcbzewdc@Ergus> <83imq24qx3.fsf@gnu.org> <20190908182346.hheaveun2pw5usb6@Ergus> <20190914204207.gfyvgbb7t4ztya7a@Ergus> <83ftkxy3r7.fsf@gnu.org> <20190915214233.xkjtoxyfxkyrd2id@Ergus> <20190917021725.xxhhhxcz3nr6sb7z@Ergus> <83blvjw8x9.fsf@gnu.org> <83v9tmqcv7.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="210131"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: NeoMutt/20180716 Cc: rudalics@gmx.at, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Sep 21 23:56:21 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iBnMb-000sYH-1S for ged-emacs-devel@m.gmane.org; Sat, 21 Sep 2019 23:56:21 +0200 Original-Received: from localhost ([::1]:43912 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iBnMZ-0004AF-CI for ged-emacs-devel@m.gmane.org; Sat, 21 Sep 2019 17:56:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44895) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iBnMQ-00049y-QV for emacs-devel@gnu.org; Sat, 21 Sep 2019 17:56:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iBnMP-0003h7-1c for emacs-devel@gnu.org; Sat, 21 Sep 2019 17:56:10 -0400 Original-Received: from sonic310-14.consmr.mail.bf2.yahoo.com ([74.6.135.124]:46451) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iBnMO-0003fi-EI for emacs-devel@gnu.org; Sat, 21 Sep 2019 17:56:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1569102967; bh=/V8j4AM+ZtoAzYVS1Rf52gaIFmsZUv+Xj+aa3Wj2YeY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=D/345dGLoVqGVvd3z2SIkJENo9Rnh7MkLB9r6Nqltdwon1O/DCl3L+Wbgx/SGmFkLabH5oJ9go+zNjU9bNQ4HG9WObkvOslIxiRnBx1+/4OdQYOkrv55vKuvjpQi8V8pqebfMDDEMDq0yOBLp3BoLZvThBI713O0B156ruXTugPHU24XRuN3brQnfwOIZe+9AqdtEqkUQDWsNMNjrTfa1sxpUzL+xLSPoFlOkSs9UQkCgV3vxpHkeS3rLMUz/RAzTt4zjU7PcRezh4UwNy+DmARuR7oSh9pi3kg8MrM8cOhZRamOKrqSz/yS9FxaijFvA4muCIvofLnPtk7711w4LQ== X-YMail-OSG: IkgpXMIVM1kHui5NyWm2pc4bj6_Y3plzsoxQPnItVOxRkV8stVvkwLnnN.26Xv8 mavy6_utLi4KGm3dlQ9IT9ix5q_fLZo_EAqlLGZUslyH2vFl9KzrBXMfvfKU5e17lY1HrDHQKaj4 FtZuDjj_elhLKTKNB05gmOUyZ3H8IijfINhMEJUz.aHK_wM0hh87d_BLB9KTE4YuJ2PruhMeP08T GlmUCfMQmgsiKTWuO4j6Y1G2fOztyxdfDofr04K3Cfox8qeLiCYCO7GV3MmZiWJYFRL9Uwz32CdG WNfT2nz0qrqUc8vur5j._IlIIdJHp4.B7LkvGLENHfktfqDYp73WQaqzLq2JqqoFCEwf1OlyZlMN z2UaUBN_euwlXD1nwZTxf8g15A49pebmAnGrZbtLyy7bIxppv5nMfsfz.T.MoLzs65TrbM1ZKQHY HLCKLo4BC.zHvrAhp40Km0yL8ly7ucFlnsJA5n9UOUGRQiWRZ7LhdPI.KnO_FbSA3CYjTTp1Pwk9 .o4UxDfJOq.3cdyvg6fl5dWjao8m9b7txJUVWsPBHhUwnUiP_.kTMl6yJKmGyLUus4LPoyawUNei aG1Q_iovUsybXe8FmDYal7_eCuvLJ2RzIvaqXWHo897tcOJEWxOF.48PJgWoerFOp3ZrdxoIHxve P62eSGoIRJphY9O7ap16PXI1Zjx0ZIIwi4wDrYqPd1UvpMM7ppNph9Dew6yzT7NPjT.KYNxttV0J PPib_foeGvgbf5qozDXEqKxpeZzaR6tXTDvp8eaoZA6j3kFjBW2SuY7kPHrdpqDgSrJo_OfWbKD0 S09PKXvKUl1vjO4bdSKHR6UNKmq1zRVTpENm4z5yY9 Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic310.consmr.mail.bf2.yahoo.com with HTTP; Sat, 21 Sep 2019 21:56:07 +0000 Original-Received: by smtp426.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID cc2ce81cd79341ab8135bed26369f9f5; Sat, 21 Sep 2019 21:56:02 +0000 (UTC) Content-Disposition: inline In-Reply-To: <83v9tmqcv7.fsf@gnu.org> X-Mailer: WebService/1.1.14303 hermes Apache-HttpAsyncClient/4.1.4 (Java/1.8.0_181) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 74.6.135.124 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:240229 Archived-At: On Sat, Sep 21, 2019 at 11:20:44AM +0300, Eli Zaretskii wrote: > >Sorry for the delay. > >Having looked at the code, I'm not sure I understand the problem. Why >not simply pass the attr_filter down to the respective merge_face_ref >calls, where you currently force zero instead? Am I missing >something? > >Some other comments about your code: > > . Please rename handle_face_prop_general into something like > face_at_pos, and make it just return the face ID, without assigning > any field in 'struct it'. handle_face_prop will then call > face_at_pos and assign the face ID as needed. > . handle_face_prop_general is supposed to be called just once with > the last argument non-zero, so I see no reason why it should be > also passed the initial_face_id argument. It looks wrong to call > that function with it->extend_face_id as the 2nd argument, and have > it compute it->extend_face_id, because the value you pass as an > argument is undefined: it hasn't been computed yet. I think the > function should use it->face_id internally instead of that > argument. > . I don't understand why you need new members of 'struct it', like > extend_face_id, saved_extend_face_id, etc. > extend_face_to_end_of_line correctly assigns the value of extend > face ID to it->face_id, after saving it->face_id in a local > variable, so I see no need for it->extend_face_id, certainly not > for it->saved_extend_face_id. You also have extend_face_id in > other related structures, where it is never used. > >Regarding documentation: if you have difficulties with the Texinfo >markup, you could write plain text, and someone else could then add >markup. Adding markup is a mostly mechanical procedure, unlike coming >up with a useful text. > Hi: I just added some documentation in the reference manuals please check it. I should add a comment in the NEWS file, in which part is the right one? >Thanks.