From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: Question about display engine Date: Tue, 17 Sep 2019 04:17:26 +0200 Message-ID: <20190917021725.xxhhhxcz3nr6sb7z@Ergus> References: <20190906093117.25qfim4kcrmiqunk@Ergus> <83o8zw5zh8.fsf@gnu.org> <83mufg5yn1.fsf@gnu.org> <20190908005109.s7hhcczkrcbzewdc@Ergus> <83imq24qx3.fsf@gnu.org> <20190908182346.hheaveun2pw5usb6@Ergus> <20190914204207.gfyvgbb7t4ztya7a@Ergus> <83ftkxy3r7.fsf@gnu.org> <20190915214233.xkjtoxyfxkyrd2id@Ergus> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="23679"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: NeoMutt/20180716 Cc: rudalics@gmx.at, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Sep 17 04:18:20 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iA34O-00060Q-9b for ged-emacs-devel@m.gmane.org; Tue, 17 Sep 2019 04:18:20 +0200 Original-Received: from localhost ([::1]:41332 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iA34N-000143-39 for ged-emacs-devel@m.gmane.org; Mon, 16 Sep 2019 22:18:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39954) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iA33n-00013s-41 for emacs-devel@gnu.org; Mon, 16 Sep 2019 22:17:44 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iA33l-0005sf-Dk for emacs-devel@gnu.org; Mon, 16 Sep 2019 22:17:42 -0400 Original-Received: from sonic301-1.consmr.mail.bf2.yahoo.com ([74.6.129.40]:43399) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iA33l-0005s0-0u for emacs-devel@gnu.org; Mon, 16 Sep 2019 22:17:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1568686659; bh=nsyQfULYzhY101F3zOQUWCq0BxofnNK8hmZNoiHeoso=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=M9bzdQv6nlavVFsEkCkgZoVa3IeLof6oGpKH/S4YC9Z75Op/67GanalX20uzSnUQ0jn9DdWh65mq1bjNlhk5RYd0C8EdndEf5bO3li1EAs7jZjdjhrbVA+9+4t1NW+BGgzj1p557SEwZrEFsVr2q+MmhLVTBUhGdCIFM4VUoER4yuppmIRO1I7MvkDsPjRV0DELmowpBAqkBYaOwubKWalr7AJ77JdM0KvQPFwg9TTWtyqiw6SL/LkZldZ06WogBI2rniSTwD49aJ73lDcGWYua3IiLPNbcMUvQSqaNH72q0WoQY3N7U7tj7AtrbDrVzhbrM6QnHwkYM0YWseSqerg== X-YMail-OSG: J6IcYdwVM1mTeoTpU6HOxwfQb5F5_n00L8W8NQZGm9cylBs_hswuzFCmTkvRkGd Mx8iKRinMF9NHZLDX9Mp4J18xW77Se2CU.bb.Cx4ZU_NM5c9h4.9T6VacSoJlCf7vA2rQpF9RMxm PgKjm4dBHBgGtbeaSleNDHUdaZMbxyj1JbAedCb3EwXLOpn6fsooWufkTgCLJnDv8t6w3OIYFipm uZgYZ8tgcDed.d7FTfXhe8kk_ha812eReQ4nRPPnbM8LF0DE7qb3J4gEpaFhc1GGFh1Xee5._9e3 IWmYq2NEHEelDimVWhm2pmKY8zjpQ4uTVZZDHtcTz7z7InWDXwBdArbyZTrm.O7G2jqYlGSbDpiU A4UMyspcR2zZ4NxA11vquQuUqCZtQgdq63.bX0y8Pd93HLeFaH75VSQfuzvtwVSAVswWwTlJ30OO IKwkkt13bHQLWEE6NS2KTRNdmTdRCP.vXp1n2zU.BQLhrXWtjK5YeqKDv.BPTycCcIW9H8Mi1oFU 08xumOf3FpyKMqJ5l0FnNVT7Fv6Pfid43flXVZg.YJ9lX79uYOqKrW4Lz1KBU.gsggZU2q.x41g5 GeyoFJpVV_29XZUbTeS7v6CXgNVhl4kmQJHotRwk6s8flVdayMpZzUq3kZukV4tusLl.JxllfHsP Nm9Jxzcwb_8GiJ75QVcDIu.0dbNtHg6tOkVUL.1g1el4ASO97s66vWkjLtA_AIcweaWGJZxzrDzQ pNT9RSd8xmhU_r_unpbCRz_kyrQnac2c4eYFUMmOJeGzzLbfAvvu1UG6H03cQ._ziCN3IkEBS3Un OU2fVjkseZkR6AaROAxqsuRQ5LnGRNLWiFfg6xKKMC Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic301.consmr.mail.bf2.yahoo.com with HTTP; Tue, 17 Sep 2019 02:17:39 +0000 Original-Received: by smtp430.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID c8f4965896cb496d7cbc0c17aae67abc; Tue, 17 Sep 2019 02:17:35 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190915214233.xkjtoxyfxkyrd2id@Ergus> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 74.6.129.40 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:240096 Archived-At: >>>>The filter now in merge_ref only works when !CONSP(ref_name). As it only >>>>bypass the extra parameter to merge_named... it this right in the >>>>general case? >> >>I think we should support all the cases, otherwise the feature will >>behave inconsistently, and we will get bug reports. >> >About this; the problem is that in the general case I'm not sure what's >the "right" behavior for the other cases. When !CONSP(ref_name) it means >that the parameter is a face_name; but in the other cases it means that >we are explicitly specifying the attributes as a cons list or as >:atribute value pairs... What's expected to happen in those cases?? > Hi: Any Idea about this? Could you suggest what to do when CONSP(ref_name) is true? > >>>Could you suggest (if any) if there are some conditions we can use to >>>avoid the call to handle_face_prop_general in some cases? >> >>Why, did you see any tangible slow-down of redisplay due to these >>changes? > No actually, but I think that there should be many cases where we could avoid calling the new function. So it is better to put them and avoid unneeded calls. For example when face_id is the default_face_id maybe?