From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: Question about display engine Date: Sun, 15 Sep 2019 23:42:35 +0200 Message-ID: <20190915214233.xkjtoxyfxkyrd2id@Ergus> References: <97f66744-8481-084a-ef23-2c50444e1f05@gmx.at> <20190906093117.25qfim4kcrmiqunk@Ergus> <83o8zw5zh8.fsf@gnu.org> <83mufg5yn1.fsf@gnu.org> <20190908005109.s7hhcczkrcbzewdc@Ergus> <83imq24qx3.fsf@gnu.org> <20190908182346.hheaveun2pw5usb6@Ergus> <20190914204207.gfyvgbb7t4ztya7a@Ergus> <83ftkxy3r7.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="214729"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: NeoMutt/20180716 Cc: rudalics@gmx.at, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Sep 15 23:43:36 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i9cIy-000tjv-0Q for ged-emacs-devel@m.gmane.org; Sun, 15 Sep 2019 23:43:36 +0200 Original-Received: from localhost ([::1]:57350 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i9cIw-0007L0-HD for ged-emacs-devel@m.gmane.org; Sun, 15 Sep 2019 17:43:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53631) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i9cID-0007J5-31 for emacs-devel@gnu.org; Sun, 15 Sep 2019 17:42:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i9cIB-00037m-TC for emacs-devel@gnu.org; Sun, 15 Sep 2019 17:42:48 -0400 Original-Received: from sonic303-21.consmr.mail.ir2.yahoo.com ([77.238.178.202]:34168) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i9cIB-00036b-G0 for emacs-devel@gnu.org; Sun, 15 Sep 2019 17:42:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1568583764; bh=/MhES8J6o4ipilRvk8TC3oaVTQcJbTIPW9lmfcyEI0Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=ESfBL3ivnn/9EgKqI02jJw3HIpSBpdCOyFVNh+cGdwDDEWc2H9kSjzPS1xtWgEBUHXvc0v8DCN9BAl1OIWMqNE21QR3dQw4+uG5BvXP7puDXtLHmwTPyqxWcrNYs9PKm2BVP3RgLsZn4y8WScPL1hboIlAXfc4qk4mO91iZajXKIAiAMakC3tU8guzczK+91BVEcoj8TDAFsmK2CUjym619EBImB5poCyYEhPY3cAAlUdMqpffRmWAE6Bu34nhDUF3wEOwJcuCia8rUdQvjdoosIJA5iMljLXnFx18NV88m7QWIStqjHfBFybLKRSoxoqJYuEaUWsqf7mMgU/vazHA== X-YMail-OSG: f8RIrxgVM1nQ2yoFM1Z7Tz0ZyPrX_j0OzhzSNMXYXmZiOOSkOhHeW8HyAnkvygF ir7PIGpK86cQaDJw1oyJ6ltf1p_GDV4A3MIRRf0nt5wjHodp3ZYdZrxXfcpclmh3vlgTdEITj.la Xl93KdnMCcQEMwQ2X9t0ds6yhO6iKCAamMKleH8u.I2oe.39LNsCSrywLIZZvSE1wn4os4FL2jdN XwRQuv7jhJjc1IxaYDN9sUB10fcQGIaChJagdXM4AAIUbWitmCvloJ.vLo5a12pQI8iSkW3PXCiu KfS3FUsznHVcf6uPxJkB9IXm.2xiyTYjjcNHQzSo90XnW8Z9jIGtIv2t0lxo.Y26vrFl3PmGiXT4 HHhUIFceEwsSsDLlzT5_WbIX.gqXFikRhcQv9gIoKytsao3gDaHyC8EvuDZ6ptGv5eDdngMwyybe 7SpW6kjeWsaYrrSv9zJnOHpctBoq16pTqZ8KEH5VMIHBDdewQfyShWsbd9lwD6ShPGRjvA2CDyFX HfXIVdBH348W4siUISjtyByJFrtotAJNab0cblP_oSqa365KPMwjl_rnV3b7Qfha7zjUCiGnPQ4t xFAVDw4Rey28moNBAue9B9FlCKO8CeiSuknLCIWPj08yGu38OYJElKW9k50fEF4G43G3BOCh1_8k ZqdrBJpuQnfE69ECFT60cgI_PW0S1PnAHlggCy.vn5_O3Hg3LjtPK6x9aKc3ASLPcVFRGhLhEEiA 4D8IfEZdC.Z0i2eWmRj6t3iEc1ptl78yU8B8avwn3fIE75be5jPS0YdYEESnAx9QYZ59_mAZmtZF JvLp36xb_YW0X6Yq7GDQt6h3ml3meqvkx2kstzjIem Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic303.consmr.mail.ir2.yahoo.com with HTTP; Sun, 15 Sep 2019 21:42:44 +0000 Original-Received: by smtp412.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 64bbb9ca8f58e7e685db6b683c112cd9; Sun, 15 Sep 2019 21:42:43 +0000 (UTC) Content-Disposition: inline In-Reply-To: <83ftkxy3r7.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 77.238.178.202 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:240057 Archived-At: On Sun, Sep 15, 2019 at 06:32:12PM +0300, Eli Zaretskii wrote: >> Date: Sat, 14 Sep 2019 22:42:07 +0200 >> From: Ergus >> Cc: rudalics@gmx.at, emacs-devel@gnu.org >> >> >I implemented this in the face_at_buffer_position but in the same >> >function (handle_face_prop_general) there is a function called >> >face_at_string_position equivalent to face_at_buffer_position... is it >> >possible in some conditions to reach that part of the code at eol? if >> >so I will need to modify that one too maybe right? > >Yes, it's possible. You need to arrange for a display string or an >overlay string with en embedded newline. > Done, new commit uploaded >> >The filter now in merge_ref only works when !CONSP(ref_name). As it only >> >bypass the extra parameter to merge_named... it this right in the >> >general case? > >I think we should support all the cases, otherwise the feature will >behave inconsistently, and we will get bug reports. > About this; the problem is that in the general case I'm not sure what's the "right" behavior for the other cases. When !CONSP(ref_name) it means that the parameter is a face_name; but in the other cases it means that we are explicitly specifying the attributes as a cons list or as :atribute value pairs... What's expected to happen in those cases?? >> Could you suggest (if any) if there are some conditions we can use to >> avoid the call to handle_face_prop_general in some cases? > >Why, did you see any tangible slow-down of redisplay due to these >changes?