From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: Question about display engine Date: Sat, 14 Sep 2019 22:42:07 +0200 Message-ID: <20190914204207.gfyvgbb7t4ztya7a@Ergus> References: <318675867.1913640.1567711569517.ref@mail.yahoo.com> <318675867.1913640.1567711569517@mail.yahoo.com> <97f66744-8481-084a-ef23-2c50444e1f05@gmx.at> <20190906093117.25qfim4kcrmiqunk@Ergus> <83o8zw5zh8.fsf@gnu.org> <83mufg5yn1.fsf@gnu.org> <20190908005109.s7hhcczkrcbzewdc@Ergus> <83imq24qx3.fsf@gnu.org> <20190908182346.hheaveun2pw5usb6@Ergus> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="223611"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: NeoMutt/20180716 Cc: rudalics@gmx.at, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Sep 14 22:42:30 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i9EsH-000w23-B3 for ged-emacs-devel@m.gmane.org; Sat, 14 Sep 2019 22:42:29 +0200 Original-Received: from localhost ([::1]:52274 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i9EsF-0002Kj-Rf for ged-emacs-devel@m.gmane.org; Sat, 14 Sep 2019 16:42:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39364) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i9Es8-0002KP-QV for emacs-devel@gnu.org; Sat, 14 Sep 2019 16:42:21 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i9Es7-0003hb-A4 for emacs-devel@gnu.org; Sat, 14 Sep 2019 16:42:20 -0400 Original-Received: from sonic301-22.consmr.mail.ir2.yahoo.com ([77.238.176.99]:37849) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i9Es6-0003hK-Rp for emacs-devel@gnu.org; Sat, 14 Sep 2019 16:42:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1568493736; bh=aSApoL/eIO2n5coO+aQs7PrnLRe0kK6UcNXUbcg7pfg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=VTgQMoZYZ5/9sdgjRNaGvlotV5NwWo48fWIfhQxLwgZdtQSkmVcRRPYEklZiPf74vGrsraQTHwWIJwGQEAAJGAN59o2E19o4TH5Z5WJwILETB3q2YzjVA4YKFX6mwpSk+XinA9/CA+K/P7i6nLgMJMmJSThSgHTNJQAKop/NzHckWXg17urHNiCs8BqsTlc2MeVGQhFdZSpt9rWX82tgTTycAw/HY1lExYQOzWR0NUVsn5O2hXp5fXOQL6dBN3PCP6TKLuJiJ8z/HkAzzro408ubbxnrzYbfPm9OClnPJRFG9WRc0yP9V+K1w/8usM/sthaENnS96cQsf21OPFIE3A== X-YMail-OSG: RGfIsj4VM1ktJOs4nAKf6dmhb4lqKIbA.vUUytzBCaXuGiGH30d.RHL31K2M9Bk gilnR9wh57yg6hzBUl30Opo0sAuLV0gO8sedQyq7uJTxtFSH3PuYXOeUkfHyDPUUgSK8kKRI1Y.b bolLR4k0ob3FqJ3.014ZqhzA31rrYwmljrpnH0hptBlb5f0Ui4tPRNls8L0bpzrHnhEC9Glduwmf JA.miAHAYiaFN0lB7oZVtzleb_LSNIhm17Xe7x4jH3lh7ySEgaGSSCdPZcxc4WZTk.RpymlVjn__ CvBHkan.ILWWz5sbA1Zt0RtIIMBrIWovTw.pI2DRAbrl_i.aYqPNzHYm6CON3Wo76K0kGvFGNYr2 POo7GeebAatfQfN9rMZlp8y3c_rUMNUulK.Kth1TQaEejVp_AZc_lAgf.b.PY5wDcMy.UlZ5aHx8 jXKEaVCgG4Kgbo1Ilq9Clq.s8HpZkELHCdN60NFz3rF.fdz5IYyDSASofc_LoSP.N9s6KKp6C_wS r0BuOzbD4MbtqzPgpYBCzymAhUyCBtcKRETHqR4MYZMJ_fnXf4aVy0PRYDNxr9mrs9xHlHRwLVtM GCXleONNGLjBlEX.KJur87uEDsAZH7ZM9J.gomdGJVNVVBAofFMNQOs_ZL5j_p3KB.lGZ5sJtp_7 tJcZ4asoIxKyTAMfz4LCpu7Chz1Jk4QPD6mQMRphgBocDZ6NP6TWxHNIumwNU7S0W9dF.ni4Kcqu jJVwx33_TBXmhRiXgr6SX4dHbYlsFAjRxkQHEkEFjwJPDMknfD75K_qTws5QABMkWDJYKQDzF1Cr 1tlFzenEOqxTpwIS_DyJUcfCUfKQoXsPEKgbbrBo67 Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic301.consmr.mail.ir2.yahoo.com with HTTP; Sat, 14 Sep 2019 20:42:16 +0000 Original-Received: by smtp419.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 27ecbfc4ad2db194d97b8052ad715df0; Sat, 14 Sep 2019 20:42:15 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190908182346.hheaveun2pw5usb6@Ergus> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 77.238.176.99 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:240035 Archived-At: Hi Eli & Martin: I just made some extra changes in the branch to fix the issues for the extra space in terminal gui. To test them try to disable the :extend for the region face and select a region with empty lines see if this is a right behavior (I think so). Now the extra space is colored like the text no with the extend face in gui and tui interfaces.. Eli: The questions I asked before were: > >I implemented this in the face_at_buffer_position but in the same >function (handle_face_prop_general) there is a function called >face_at_string_position equivalent to face_at_buffer_position... is it >possible in some conditions to reach that part of the code at eol? if >so I will need to modify that one too maybe right? > >The filter now in merge_ref only works when !CONSP(ref_name). As it only >bypass the extra parameter to merge_named... it this right in the >general case? > Could you suggest (if any) if there are some conditions we can use to avoid the call to handle_face_prop_general in some cases?