From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: Question about display engine Date: Thu, 8 Aug 2019 16:50:15 +0200 Message-ID: <20190808145015.2qaxwzwf4ws2i3er@Ergus> References: <83k1bpasic.fsf@gnu.org> <20190807155738.yviofsumjjhqueci@Ergus> <83imr9ar9f.fsf@gnu.org> <0975890b-37b4-428d-f6e5-5dcf894fb6be@gmx.at> <83ftmdapxm.fsf@gnu.org> <20190808083804.ta3evocyb4hirywj@Ergus> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="270106"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: NeoMutt/20180716 Cc: Eli Zaretskii , emacs-devel@gnu.org To: martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Aug 08 16:51:02 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hvjkq-00184c-Lc for ged-emacs-devel@m.gmane.org; Thu, 08 Aug 2019 16:51:00 +0200 Original-Received: from localhost ([::1]:52458 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hvjkp-0005zp-EK for ged-emacs-devel@m.gmane.org; Thu, 08 Aug 2019 10:50:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59464) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hvjkI-0005lf-24 for emacs-devel@gnu.org; Thu, 08 Aug 2019 10:50:27 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hvjkG-0005Gp-RN for emacs-devel@gnu.org; Thu, 08 Aug 2019 10:50:25 -0400 Original-Received: from sonic310-11.consmr.mail.ir2.yahoo.com ([77.238.177.32]:42559) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hvjkG-0005Fw-Kk for emacs-devel@gnu.org; Thu, 08 Aug 2019 10:50:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1565275822; bh=PafvLGMT9Y8nX06B2sKxfxHh85NcFau9nvLrz0Mfzts=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=MyTBjY/RzLtDIsMldfnKHKZYwMl/vPw5HYma2ezFKBJUbBTtINcoD76vPLkORaDonMErvnl7FHqf/a/aOit2hfzUHExG67uJA+KqnMgu6sMF4Rvi0lmvnYmPNZATMb6NES7/9KP//0TrDrQ8Ga8iIEpj/zKxpBYnmlCbgD0vBYb52RauGoo5Py67XxN8DEs29i8/vs0Y/7XpZiPuIesJPyuZXfD1jfw6NVPqPsZzqz9aT/qtylIuFrt3UsD0BAzde3a/hBexa6XEJJIw7e//mu0dZr+CJlrATT3gkCp5YIcHe9xir6bSmA/X1sf1oXMBmNLXdFc4q2biEQoc0m27ew== X-YMail-OSG: DK3eW6IVM1lhodon7muqFpQxa6kv2A4c7vJvlI9p0OGFIFGnPHrPG.iRktV.KH_ Vaj4XULURhI8rk63VsKtA0RVQKzmXsja6dEA.lsIHdhZQDrIVQQOxW7dsGqJdD.HwCsmcOzhI0nt B1xlp1uIfoTo5FwJi8o34pWIdqXubAXaa1ywdmspIN1FnV.hExhhzQUkHn0k_f43XNA7GN2adb2R 8BiA2.lwyF1mUx2RPb1MI6iAwDcl.5M3gpYKz22zBuBOj1XnKTIlOfU.pm_ZndEHW4qA2Yfdo.MF s6d0I7K1_U6lEhfvzoAJscRZs7WIv1.Xd16UMu4dm1f1lbP3O_E57weLrfAkuYI5.H.LEgfM1aY6 CMpuSyz7BQbHP6mSIlWm7f6Um6RYH6yEJimyVPSDifuIklkbFLT5MQ9DSUV1.PQNVIZsge7MNVOK nUWse7h_ZBVago2WJd_ftKCJ3PJI5bbnRisYsATQ.p8SgJWwndNlEET23gkPROzkdxKoGJSOPakE ngRuWTRaNqlNGaspoBKDSQSjNfP3rh3o5BJIA36l6soav8EEsLaFZvTVgwCdX8rhHGjX7m_kQBiL qal1EoMGQkXRLAF_jf0dIvrdjmp9BV4WAW4NihLQtO.YA0VqfLh7qAvzzW35nKB2gGL2ZoYyjg4W 8qbYT0fb7F8VnVVLyTYnfDoscrqtfGON6QEnYPr81oC803jfLmFwgGKi_fM5TRSveKx7.9Yy.Mx7 CDjDAmsZvsC3SLX2f0jSEDEfft9fELk7_.JyUkmw5_xAAVGnL0c2WFyOtsIveoS.zoQIQ7qEMwLQ X2IimySSdG1FY2GwnLiLkPm6rDwREoHHWRo7rxgMU3 Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic310.consmr.mail.ir2.yahoo.com with HTTP; Thu, 8 Aug 2019 14:50:22 +0000 Original-Received: by smtp417.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID ae932f41c227eff9cfc5e087e6845246; Thu, 08 Aug 2019 14:50:18 +0000 (UTC) Content-Disposition: inline In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 77.238.177.32 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:239253 Archived-At: On Thu, Aug 08, 2019 at 03:05:37PM +0200, martin rudalics wrote: >> Yes, that's exactly the point. The only face I see that needs to be >> extended so far is the region. If only the region is extended >> (assuming we won't stop extending that one too) you won't need your >> workarounds, extra settings, another flag in the face structure, or >> call extend face to end of line most of the time. > >I'm afraid things are not that simple. We have at least the secondary >selection and 'hl-line-mode' to take care of. Moreover, there might >be users who do prefer the current way of extending (and not >extending) faces to window edges. And I have no idea whether image or >rectangular regions require special treatment too. > >martin > You are right, I ignored those use cases, but I still don't think that the faces are the right place to flag that. The line extension maybe needs to be decided based on another text property. Maybe there are already some conditions we can check dynamically. Because adding a flag is a bit error prone when there are already some conditions. There is also the case when the face to use comes from FACE_FOR_CHAR or another is merged over that. Or when there is a highlight inside the region at the end of the line text... That, in the display engine, I am not clear yet how are handled. About the user preferences I think it needs to be accepted the Eli's choice (I will favor the uniformity+simplicity over over-specification, but I am not very "emacsy" in that point). Because we won't make happy everyone in any case.