unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: emacs-devel@gnu.org
Subject: Elisp manual: Note that created faces cannot be removed.
Date: Sat, 20 Jul 2019 18:37:15 +0000	[thread overview]
Message-ID: <20190720183715.GC27030@ACM> (raw)

Hello, Emacs.

It transpires that once a face has been created by defface, it cannot
then be removed.  This is not mentioned in the Elisp manual, despite this
non removeability being exceptionally rare in Emacs.

So I propose the following patch, which is surely(?) uncontroversial:


diff --git a/doc/lispref/display.texi b/doc/lispref/display.texi
index 276d60b21a..22b7eb0bd1 100644
--- a/doc/lispref/display.texi
+++ b/doc/lispref/display.texi
@@ -2476,6 +2476,9 @@ Defining Faces
 usual procedure is to define a face with @code{defface}, and then use
 its name directly.
 
+Note that once you have defined a face with @code{defface}, you cannot
+later remove this face except by restarting Emacs.
+
 @defmac defface face spec doc [keyword value]@dots{}
 This macro declares @var{face} as a named face whose default face spec
 is given by @var{spec}.  You should not quote the symbol @var{face},


.  Is it too late to push this patch to Emacs 26, or does the rule about
documentation changes being OK still hold?

-- 
Alan Mackenzie (Nuremberg, Germany).



             reply	other threads:[~2019-07-20 18:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-20 18:37 Alan Mackenzie [this message]
2019-07-20 18:39 ` Elisp manual: Note that created faces cannot be removed Eli Zaretskii
2019-07-20 18:41   ` Eli Zaretskii
2019-07-20 20:26     ` Alan Mackenzie
2019-07-21  2:28       ` Eli Zaretskii
2019-07-22 10:02         ` Alan Mackenzie
2019-07-22 14:33           ` Eli Zaretskii
2019-07-22 15:18             ` Alan Mackenzie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190720183715.GC27030@ACM \
    --to=acm@muc.de \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).