From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.devel Subject: Re: -getRed:green:blue:alpha: not defined for the NSColor Date: Sun, 14 Jul 2019 11:24:11 +0100 Message-ID: <20190714102411.GA11787@breton.holly.idiocy.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="42622"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mutt/1.12.0 (2019-05-25) Cc: emacs-devel@gnu.org To: Keith David Bershatsky Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jul 14 12:24:24 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hmbg7-000Awr-IX for ged-emacs-devel@m.gmane.org; Sun, 14 Jul 2019 12:24:23 +0200 Original-Received: from localhost ([::1]:59556 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hmbg6-0002cF-Gw for ged-emacs-devel@m.gmane.org; Sun, 14 Jul 2019 06:24:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49937) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hmbg4-0002bx-7h for emacs-devel@gnu.org; Sun, 14 Jul 2019 06:24:21 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hmbg3-0000W8-8C for emacs-devel@gnu.org; Sun, 14 Jul 2019 06:24:20 -0400 Original-Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]:55200) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hmbg2-0000VJ-VZ for emacs-devel@gnu.org; Sun, 14 Jul 2019 06:24:19 -0400 Original-Received: by mail-wm1-x330.google.com with SMTP id p74so12417573wme.4 for ; Sun, 14 Jul 2019 03:24:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=kpej8CAQC5b6O1q5lo79BVwhgoqjVxIaw0aOAj9jls8=; b=crvyphsR6dkIisuC1g7VWNGb51zdW7U+GQONDvKYEEDB+bGytR7EHUQasFa5VFHzaF Mpv7NT8p5MN/T5dfQ8qNyzagsRynSBmqOVnn0vEBbV+xrVEMRxJWgdp5J2wbT9kugaUy MqqSQ7ZmBta5BH7wr6L+fe95tfAP/01ADydN+UokQX37q40sT48nKAzA0WzVcnDT6xBd IXw2ekwKuQygTBTku6ilsZRuOppSGOhq9yeYfkm8rsW2saCs1oX8MhH5cvKDukEHJJ50 Gcl2Cv1oFqSlnUaODw0+mFT7FY49nf6gTHUeJuo98tbhKkFtLfUNkYqcqpPsx8y4khKn 0yyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=kpej8CAQC5b6O1q5lo79BVwhgoqjVxIaw0aOAj9jls8=; b=KZomg6RnXbEpuL+uGxOlhLXD2b9UJ6PvIwgVIEz0mx4cb4SazrDwM9ykU3PuvNpu9C R1/PB+i80ICQ87O03XpRHqOrobLh78LzlFMEbbHpvjwM6wTlyo/59AEDvjUrF+FkJVJI cgqLJaiFVLpoRd5XRm6hy9Q6qy8LJEcYKZsoRZfSU/j2eclYinR5nR7zpm0iQF7uVxyL RGIvF0CzsLuU0nu/UyDgYSW7eXpnyRdBGkNMQecxCFr6Gt34wzL6rkbbUxQLOAssK6J+ bPk3oDoQ0pjMkTBOtzLmAsTR+zyRYQcC5oNwjD8meERMD2SVVgfVU1DqziEZGc60ndY5 yyyg== X-Gm-Message-State: APjAAAUjbW+eJXg/iWUmy21HvS9XNaYil8GNcFt0ANhTRrbd4QqqmqTb OqBJD0C8DgTChiotVZ+SUDRKMdkr X-Google-Smtp-Source: APXvYqx4Th9npLHnYe6JttIVKfut3L3H9XVLZSBjeQMw1tTRmq3sZvddSMkKnPOUvjuTeqf2yWxJeQ== X-Received: by 2002:a7b:c38c:: with SMTP id s12mr18211337wmj.71.1563099856757; Sun, 14 Jul 2019 03:24:16 -0700 (PDT) Original-Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-b0d8-8cf9-dc55-40ba.holly.idiocy.org. [2001:8b0:3f8:8129:b0d8:8cf9:dc55:40ba]) by smtp.gmail.com with ESMTPSA id q1sm11480404wmq.25.2019.07.14.03.24.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 14 Jul 2019 03:24:14 -0700 (PDT) Content-Disposition: inline In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::330 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:238579 Archived-At: On Sat, Jul 13, 2019 at 11:10:29AM -0700, Keith David Bershatsky wrote: > The following change made with > 9624f609493da7c08016ba00d6895bad0fe26a0e is what prevents Emacs on > OSX 10.6.8 from working. Would it be possible for the Emacs team to > put in a condition that permits Emacs on OSX 10.6 to use the two > lines of code that were removed? [I do not know what is the earliest > version of OSX that can make use of two new lines of code without > breaking.] Hi Keith, thanks for tracking this down. Can you try this change: modified src/nsimage.m @@ -310,6 +310,6 @@ - (instancetype)setXBMColor: (NSColor *)color return self; - if ([color colorSpace] != [NSColorSpace deviceRGBColorSpace]) - rgbColor = [color colorUsingColorSpace:[NSColorSpace deviceRGBColorSpace]]; + if ([color colorSpace] != [NSColorSpace genericRGBColorSpace]) + rgbColor = [color colorUsingColorSpace:[NSColorSpace genericRGBColorSpace]]; else rgbColor = color; If that doesn’t work I’ll make your suggested change. -- Alan Third