From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: master b9ac4f8.. (Fix locating pdump by symlink) breaks with stow Date: Mon, 24 Jun 2019 15:50:46 +0200 Message-ID: <20190624135046.x4r54hwj4yzfea5t@Ergus> References: <87imsvuvnr.fsf@wavexx.thregr.org> <20190624111050.jindvg6j4hr5j226@Ergus> <20190624122841.vfezkecaxjqwzjy3@Ergus> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="237781"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: NeoMutt/20180716 Cc: Yuri D'Elia , Yuri Khan , Emacs developers To: Daniel Colascione Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 24 16:04:50 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfPaT-000zf3-P7 for ged-emacs-devel@m.gmane.org; Mon, 24 Jun 2019 16:04:50 +0200 Original-Received: from localhost ([::1]:51458 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfPaS-00015H-63 for ged-emacs-devel@m.gmane.org; Mon, 24 Jun 2019 10:04:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43313) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfPN6-0002nR-33 for emacs-devel@gnu.org; Mon, 24 Jun 2019 09:51:01 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hfPN4-00082I-1Q for emacs-devel@gnu.org; Mon, 24 Jun 2019 09:51:00 -0400 Original-Received: from sonic309-24.consmr.mail.ir2.yahoo.com ([77.238.179.82]:40369) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hfPN2-0007z7-A9 for emacs-devel@gnu.org; Mon, 24 Jun 2019 09:50:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1561384253; bh=vIbOVOw+0hL2mKCdHDeSYP9YsceVVfJ5kTLI/hy3vJI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=ksPzkZ8SF9WKsf+7P/okqvbBxzrDVKSiZtAYWDU2WM7dk50M7hF9y9ey2s7QXs+7zftNzXN/48+5sqX/a3i4N2M7lEJvCpp4oM37hYARcrIGZEk1abLNhqWJrcJKzl/r9rrC0j1573vC/c5Z4ufwkVgrfuPgdK4eu7IcNyoOLDu58okOd5Z1VaU8YGYCyOZcKif6FcPMex59/Sk0pjiDJZwV+bUjtXW8FDWVekzwXZVJXveGOxu1z5ILt68ne9YRP43xsIF0TF518O4/QEAyewnK5yOWzyQi6AAi8cJtRTrI6UpILe63IdjUjfIQPphX043V38iBR0oA0IzTFhuxww== X-YMail-OSG: cukLMzoVM1n52NtYdB9nTcihuEAK.89QdhZkz6cnoJmLh4R2CXVXpedhtFGPvyM P5gSJF9aJia3BRve_QcZlKKwmEMjrx6lJqEXtbiV2Zk2JqfWEU81.xr14ykCMYF37fw9Cc7DHK2g AHxqMncRka4RL5yhSmR0RVcGyuB5Eknn1inn.hdH5xGp6tTZicnm4tCECKdPetYKQsiQ2DjAH2Qf dL1EJojwogV0Hi6JvdJa5EMiuB7ZOIxbwYtDiRd5aaqawUXcf82n0K1xThx9oh4A2aMn92OA_uKF NRBeILlYl4R3CxB77OAjljX0eVMra1gdAoRgNzMTZAAJkNAJTuy2GmCJG0k4y44Wf9Jm794lzfem xn7eIxAONdAgrruGBQQRqcGPsCkn1eHXrofbe39vN5cr.RPu2mOoylhg362.u77Pt5dbxaMJo3zV voCAlNVchuRbGK28BpraCNQjUpynNgnMHxrp7MKho7eH2j0HeHUpaAPLeLF5VaNP7PAdkhh_6y9X heXCQe3cL5.eacpd6YcCIsoVsKQroakxaidLP8gagMQsgiAvCJ0WE7gVTqvJiUwhYRssYAnC1Yrt f9lNr53TlFGsvN6L.d6FUo7ZQN7yeeVUs8vJM5DZAdBfd1Gxw.0fRsTR_3PYYJDRxwMzOeDIUWbL dhUaoOlOiSijZzktjdy.ljP_SFJ1Cr9kvEs7wlGUpMRci7ZY4S4fJjG4oOrPjRM2YbwYA7HQAjUy 3d8pwYx9Yj2ymFlqyX4tiNz834mT5Q2GT3FXDTP9XxzY.UmfpfohfANSHDNuxkEmNGrpmzObGeLI SIYCMENlJdrc8hCPYOY1o_BwnlNbrhKI7y29HMpCHN Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic309.consmr.mail.ir2.yahoo.com with HTTP; Mon, 24 Jun 2019 13:50:53 +0000 Original-Received: from 2.152.205.184.dyn.user.ono.com (EHLO Ergus) ([2.152.205.184]) by smtp422.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 1553835f4e8f4c1bacb55fee679bfd1f; Mon, 24 Jun 2019 13:50:50 +0000 (UTC) Content-Disposition: inline In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 77.238.179.82 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:238098 Archived-At: On Mon, Jun 24, 2019 at 06:21:12AM -0700, Daniel Colascione wrote: >> On Mon, Jun 24, 2019 at 06:57:32PM +0700, Yuri Khan wrote: >>>On Mon, Jun 24, 2019 at 6:12 PM Ergus wrote: >>> >>>> 750| char* argv0 = realpath (argv[0], NULL); >>>> 751| if (!argv0) >>>> 752| fatal ("could not resolve realpath of \"%s\": %s", >>>> 752| argv0, strerror (errno)); >>> >>>This looks wrong. If we called realpath and it returned null, we???d >>>probably want the original argv[0] in the error message, not the null >>>result. >>> >> >> This also produces problems when using emacs from an alias like em o emc >> which is a very common practice. >> >> So there should be actually other conditions to try if the first >> realpath call fails and not abort (call fatal) in the first try. > >Try it now. Sorry about the botched change. > > Hi Daniel: Did you pushed any change too savannah/master? Best Ergus