From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: master b9ac4f8.. (Fix locating pdump by symlink) breaks with stow Date: Mon, 24 Jun 2019 14:28:41 +0200 Message-ID: <20190624122841.vfezkecaxjqwzjy3@Ergus> References: <87imsvuvnr.fsf@wavexx.thregr.org> <20190624111050.jindvg6j4hr5j226@Ergus> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="85475"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: NeoMutt/20180716 Cc: Yuri D'Elia , Emacs developers To: Yuri Khan Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 24 14:29:36 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfO6I-000M5M-7k for ged-emacs-devel@m.gmane.org; Mon, 24 Jun 2019 14:29:34 +0200 Original-Received: from localhost ([::1]:50742 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfO6H-00069b-8O for ged-emacs-devel@m.gmane.org; Mon, 24 Jun 2019 08:29:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50522) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfO5a-00067s-Ph for emacs-devel@gnu.org; Mon, 24 Jun 2019 08:28:51 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hfO5Z-0007jn-Su for emacs-devel@gnu.org; Mon, 24 Jun 2019 08:28:50 -0400 Original-Received: from sonic313-20.consmr.mail.ir2.yahoo.com ([77.238.179.187]:41622) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hfO5Z-0007hd-FK for emacs-devel@gnu.org; Mon, 24 Jun 2019 08:28:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1561379326; bh=EM6N56SP1Fbg668f6bgrAekhvCgnMD5pgzVPq7BnPiU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=Nt9kiGqZ8pHGTQRy2I5/kE8yiIuH194q9vzIMN0FPCmd3f+YaE1PopUyLLJUbA/vDwhDeeqfX40IB0F1FfkLqBU72+XhABr89kOz6fbH1Bpjgg/urZ9kEI30+htOdDh+FnqdqlLZC1KNH79eEcEIeTmdm9MsZtKuZ7RrztZtZYC4DzPDKMV148LcMX+ZSOSPlcyt5ecf8EYcdtZAvUCDM4Gsv0pyI6oVDE6kZFZcFxLJty0mHv2lga7na/BXZIBU5kDy2Ajl/roth5CmVh6YaqEE4f9srX0haka5xEpTJtYhqh6JUYaKkqsFxZc2KxsrNW2yeo2tWPW/ZdQxjV8BXQ== X-YMail-OSG: Jx.WQsIVM1l0yv3kFFMOesUxQ69eY.hMuQz7GTNTiVz2PNVflUX5lAxZB4EADED nMk588Qrnt.U9sKE9Pf2TomESbFKC6a1XA.3fwwFV_acJvWgsduLVlcyCTTo53UenkY2BS8DQt2U mxdfkmQ4KED.oSBipFyUhw1vpBrkc02u03RMvAlixkhi_Cr1Hr5X85JTQ6fpQE.zdSod2IOv.MdL 3rQ.vrvEGBvnkglWe8qe93eh_VWb_tiiY.LonnxDm6Bxn6pBZ5jtEk6zOorzU65TSGq9tyfMOEZ2 BSEcsclZfann.IJzmJ01jl0bFE.xf0cFeUQ4SIdfaFE4YGi._bmswiEd1NNntuG.F5aVzDlgx7IK hKPt3V4r7wmDyjOPIB6yj4kMkqWKYNlOj051csr0.pwYB48qyrPuHzVlIi9uBEdxj.Vdvr9u8NgC nwLfl6wVVdj9b0J0XVR7BMmmdTd_Psq2njaAde.kmA7bblia2IP9pwEpLyFlxOnEhMZYzrCN4iba inwd0m6WInjWYch4Yb0nHU_uKXiyav.tf9FdB1G_QrioZcr3rRUp4qKG2FtrMyo5POOW9K.ujgMY bYA5cuPkUcLbn.QlFOu5I6wCffrLSLYw6SSdhx.giYtfipKshErRtQbYUkHTV14A_RO8.yTDCy6n RzLVub0TvUmi7KoUFHTaOLgBUwuw0WcjaOL2QOXR8So_9uHpd.yoGjHoAT6ahqOyg.A7cUiUBD0L XeUu0QKSI0XhZQi9FLsXowa4hN_1dguuZb2RcqK9.GXXU_IBR2Sf8u824O7PKGwc3Gcl_pH8i2Fm VX.tekofSjsr6gu1seTW27kVEBiBGnu5KKaLsOAfzO Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.ir2.yahoo.com with HTTP; Mon, 24 Jun 2019 12:28:46 +0000 Original-Received: from 2.152.205.184.dyn.user.ono.com (EHLO Ergus) ([2.152.205.184]) by smtp415.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID d220a48fa2208271ed5bc650e3b6f88f; Mon, 24 Jun 2019 12:28:44 +0000 (UTC) Content-Disposition: inline In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 77.238.179.187 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:238092 Archived-At: On Mon, Jun 24, 2019 at 06:57:32PM +0700, Yuri Khan wrote: >On Mon, Jun 24, 2019 at 6:12 PM Ergus wrote: > >> 750| char* argv0 = realpath (argv[0], NULL); >> 751| if (!argv0) >> 752| fatal ("could not resolve realpath of \"%s\": %s", >> 752| argv0, strerror (errno)); > >This looks wrong. If we called realpath and it returned null, we???d >probably want the original argv[0] in the error message, not the null >result. > This also produces problems when using emacs from an alias like em o emc which is a very common practice. So there should be actually other conditions to try if the first realpath call fails and not abort (call fatal) in the first try.