From: Ergus <spacibba@aol.com>
To: Yuri Khan <yuri.v.khan@gmail.com>
Cc: Yuri D'Elia <wavexx@thregr.org>, Emacs developers <emacs-devel@gnu.org>
Subject: Re: master b9ac4f8.. (Fix locating pdump by symlink) breaks with stow
Date: Mon, 24 Jun 2019 14:28:41 +0200 [thread overview]
Message-ID: <20190624122841.vfezkecaxjqwzjy3@Ergus> (raw)
In-Reply-To: <CAP_d_8UeyAaQ5QxFDwvR7WDnTY4nCT6xdXUo6+OCqc2h+Rg85g@mail.gmail.com>
On Mon, Jun 24, 2019 at 06:57:32PM +0700, Yuri Khan wrote:
>On Mon, Jun 24, 2019 at 6:12 PM Ergus <spacibba@aol.com> wrote:
>
>> 750| char* argv0 = realpath (argv[0], NULL);
>> 751| if (!argv0)
>> 752| fatal ("could not resolve realpath of \"%s\": %s",
>> 752| argv0, strerror (errno));
>
>This looks wrong. If we called realpath and it returned null, we???d
>probably want the original argv[0] in the error message, not the null
>result.
>
This also produces problems when using emacs from an alias like em o emc
which is a very common practice.
So there should be actually other conditions to try if the first
realpath call fails and not abort (call fatal) in the first try.
next prev parent reply other threads:[~2019-06-24 12:28 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-24 10:26 master b9ac4f8.. (Fix locating pdump by symlink) breaks with stow Yuri D'Elia
2019-06-24 11:10 ` Ergus
2019-06-24 11:57 ` Yuri Khan
2019-06-24 12:28 ` Ergus [this message]
2019-06-24 13:21 ` Daniel Colascione
2019-06-24 13:50 ` Ergus
2019-06-24 13:54 ` Daniel Colascione
2019-06-24 14:05 ` Ergus
2019-06-24 14:19 ` Ergus
2019-06-24 14:14 ` Andy Moreton
2019-06-24 14:52 ` Eli Zaretskii
2019-06-24 16:06 ` dancol
2019-06-24 17:23 ` Eli Zaretskii
2019-06-24 18:12 ` Daniel Colascione
2019-06-24 18:25 ` Eli Zaretskii
2019-06-24 17:12 ` Eli Zaretskii
2019-06-24 18:26 ` Andy Moreton
2019-06-24 18:44 ` Eli Zaretskii
2019-06-26 16:26 ` Eli Zaretskii
2019-06-26 16:58 ` Eli Zaretskii
2019-06-27 17:45 ` Ken Brown
2019-06-27 18:36 ` Eli Zaretskii
2019-06-27 19:56 ` Ken Brown
2019-06-24 15:01 ` Basil L. Contovounesios
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190624122841.vfezkecaxjqwzjy3@Ergus \
--to=spacibba@aol.com \
--cc=emacs-devel@gnu.org \
--cc=wavexx@thregr.org \
--cc=yuri.v.khan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).