From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: master b9ac4f8.. (Fix locating pdump by symlink) breaks with stow Date: Mon, 24 Jun 2019 13:10:50 +0200 Message-ID: <20190624111050.jindvg6j4hr5j226@Ergus> References: <87imsvuvnr.fsf@wavexx.thregr.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="27404"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: NeoMutt/20180716 Cc: emacs-devel@gnu.org To: Yuri D'Elia Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 24 13:12:52 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfMu4-00072Y-P2 for ged-emacs-devel@m.gmane.org; Mon, 24 Jun 2019 13:12:52 +0200 Original-Received: from localhost ([::1]:49858 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfMu3-0006PZ-JL for ged-emacs-devel@m.gmane.org; Mon, 24 Jun 2019 07:12:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54083) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfMsH-0006NL-Be for emacs-devel@gnu.org; Mon, 24 Jun 2019 07:11:02 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hfMsG-0008Ke-B1 for emacs-devel@gnu.org; Mon, 24 Jun 2019 07:11:01 -0400 Original-Received: from sonic314-19.consmr.mail.ir2.yahoo.com ([77.238.177.145]:45299) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hfMsF-0008Fi-Fz for emacs-devel@gnu.org; Mon, 24 Jun 2019 07:11:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1561374655; bh=k291GrCtzDAy/zL5MBL0lIxmTwVKczsUDzJg+MyJHTw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=Hq/SzzqCXV+fgmLU3EaaJwmtks942zHXGwCGrm5k3uzeaDzdanjCaiuIa5ZUfT8W61oP5tvc4AXF0x7JN4f5+QvOvL5d2VABi52IUVwofzojItsV3Mu59Xcn+q2HXZ2dad0P+O1iHq/QEwjJQrvcRMkIIIF6mgRXrKPaoB28oG0tznANHx8Awc7LC5BiKLszSXeFuVgQtImDsk3vlslKwk9qzs9aS/nx1G9Ym/rK69pI6Qewae00Ptx/y60svDGadc1s8Wjz8N0Zk+TJgtzw1NrYEavu+4k9VSay7US3YJEfbmwEXD0MARvMetF5OVzomIlg/VmTPBW9othjOUs9hQ== X-YMail-OSG: DpGrRUQVM1nGQx8FB_4v23ezRftVEKEbrJxM4ZjTHjrIRtVK_AWd5e8IM6iNJui pwIqRIFNKK.N5vMX5b4jNEBT9kmEreGpRvsjpK07NDH2uTYWMkeLqrTlqAd8Cel.lubWJaLhlCFu QOzGv7zJ9vAswL0nKFrS2bQCjUsD6Wp9xx8pi9wjqzZ_Qa4G.lrxYqWSTVsirYhY1okP47zdNqry HOooVSL7BUjVqYon5QiQWGuB4ZMGooufFU7i024aycGTsBIoFQ6rHniEbsWGYnwxNAmYQCxoIRsR piw3yJ85ZPfEACRq94zEiwf5rLl.rfIKzwuS.m16dvfBTK8bUIW8WuA2eyWezJi0yDRQXHXXexod ldyMV0d_tQZCqYfVTGsIUlMtN4gYzeK0H4tBaIsPI43oHepZXFL4AkdVjFNm1bD.YbShEqZHk_xC .P7pwZhAMnMd7Qzxt_8tktAgKbPvRdUDnA6c_odW07W.Oj6MJkEhRAAHqJ0IX5cThnIhllzVp_tf 7K3cuzeVocL81WLOEle51a_a0QwVBWJDi9PKqSjbiNGPrBXWucTDeapPGwP_vTb75KXDtVeXD8OM MBayo34sGSFwbYTXgwMzyrTgpiNrMnxUw3NRorepW89VahqGSyW5DWgUbW2oSaiP39Z9T.KnwFh3 z2w_hcaZ4Uku1AwkhMDO7k0_yBzxdFdRx.ivSWVUjoDd7U5buYr9.bdboCbwumr859kQJTVQ9xLD QlpKYfj1dAuA8lgjj.qpGoEn722m869PuFD_Pksf61_IoXuxjrbEWuQds3sRMzv7_rc1booAHuzg DSAV84jgsZsrPTw4pE2nKmS9OH.NBMHC1eBxORd2JB Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic314.consmr.mail.ir2.yahoo.com with HTTP; Mon, 24 Jun 2019 11:10:55 +0000 Original-Received: from 2.152.205.184.dyn.user.ono.com (EHLO Ergus) ([2.152.205.184]) by smtp404.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 0bfae1824117664f2680726d87fd0687; Mon, 24 Jun 2019 11:10:54 +0000 (UTC) Content-Disposition: inline In-Reply-To: <87imsvuvnr.fsf@wavexx.thregr.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 77.238.177.145 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:238090 Archived-At: Hi: I am getting the new warning after commit b9ac4f815ebaa1a. It is just a warning but it is right. ../../emacs_git/src/emacs.c:752:5: warning: ???%s??? directive argument is null [-Wformat-overflow=] This is the code. 750| char* argv0 = realpath (argv[0], NULL); 751| if (!argv0) 752| fatal ("could not resolve realpath of \"%s\": %s", 752| argv0, strerror (errno)); The format %s expects a char[] but in this case argv0 is NULL, thats where the warning is coming from. On the other hand I see that realpath() was called with NULL as a second parameter, in that case it internally invokes a malloc, so there should be a free for it somewhere. On Mon, Jun 24, 2019 at 12:26:00PM +0200, Yuri D'Elia wrote: >% which emacs >/usr/local/bin/emacs >% ls -l =emacs >/usr/local/bin/emacs -> ../stow/emacs-20190624/bin/emacs >% emacs >emacs: could not resolve realpath of "(null)": No such file or directory > >reverting commit b9ac4f815ebaa1acb0d045fe9583f665efa6f628 fixes the >issue. > >