unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Alan Third <alan@idiocy.org>
To: Sungbin Jo <pcr910303@icloud.com>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH v2] Add xwidget webkit support for macOS Cocoa
Date: Tue, 4 Jun 2019 17:22:12 +0100	[thread overview]
Message-ID: <20190604162212.GA23349@breton.holly.idiocy.org> (raw)
In-Reply-To: <20190603235121.15533-1-pcr910303@icloud.com>

On Tue, Jun 04, 2019 at 08:51:20AM +0900, Sungbin Jo wrote:
> ---
>  configure.ac                     |  34 +-
>  lisp/xwidget.el                  | 315 ++++++++++++----
>  nextstep/templates/Info.plist.in |  12 +-
>  src/Makefile.in                  |   1 +
>  src/emacs.c                      |   2 +-
>  src/nsterm.m                     |  23 +-
>  src/nsxwidget.h                  |  80 ++++
>  src/nsxwidget.m                  | 611 +++++++++++++++++++++++++++++++
>  src/xwidget.c                    | 261 ++++++++++++-
>  src/xwidget.h                    |  50 ++-
>  10 files changed, 1288 insertions(+), 101 deletions(-)
>  create mode 100644 src/nsxwidget.h
>  create mode 100644 src/nsxwidget.m

This applies fine now. Thanks.

I’ve only had a brief test and it appears to work, but I did something
wrong the first time I tried it.

M‐x xwidget-webkit-browse-url RET idiocy.org RET

it silently fails to load the page, then try the same but with
https://idiocy.org/ and it starts spewing lots of this message into
the terminal:

2019-06-04 17:15:16.041 Emacs[38758:2115790] xwHasFocus: Error Domain=WKErrorDomain Code=4 "A JavaScript exception occurred" UserInfo={WKJavaScriptExceptionLineNumber=1, WKJavaScriptExceptionMessage=ReferenceError: Can't find variable: xwHasFocus, WKJavaScriptExceptionColumnNumber=11, WKJavaScriptExceptionSourceURL=undefined, NSLocalizedDescription=A JavaScript exception occurred}

If I type in the full correct URL the first time it’s fine.
-- 
Alan Third



  parent reply	other threads:[~2019-06-04 16:22 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-25 13:27 [PATCH] Add xwidget webkit support for macOS Cocoa Sungbin Jo
2019-05-25 17:47 ` Paul Eggert
2019-05-26  2:57   ` 조성빈
2019-05-26  6:02     ` Paul Eggert
2019-05-28 15:07       ` [PATCH v2] " 조성빈
2019-06-02  6:14         ` 조성빈
2019-06-02 14:39           ` Eli Zaretskii
2019-06-03 16:11         ` Alan Third
2019-06-03 17:25           ` Stefan Monnier
2019-06-03 23:36             ` Paul Eggert
2019-06-03 23:51               ` Sungbin Jo
2019-06-04  2:40                 ` Stefan Monnier
2019-06-04  8:33                   ` Andreas Schwab
2019-06-05  3:06                   ` Sungbin Jo
2019-06-05  3:18                   ` [PATCH v3] " Sungbin Jo
2019-06-05 13:55                     ` Stefan Monnier
2019-06-05 14:34                     ` Eli Zaretskii
2019-06-23 22:38                     ` Alan Third
2019-06-04 16:22                 ` Alan Third [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-05-27  9:50 [PATCH v2] " Sungbin Jo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190604162212.GA23349@breton.holly.idiocy.org \
    --to=alan@idiocy.org \
    --cc=emacs-devel@gnu.org \
    --cc=pcr910303@icloud.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).