From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.devel Subject: Re: Native image rotation Date: Mon, 20 May 2019 19:18:48 +0100 Message-ID: <20190520181848.GA18876@breton.holly.idiocy.org> References: <20190224113050.GA67303@breton.holly.idiocy.org> <83tvgtnoyh.fsf@gnu.org> <20190224232228.GA67813@breton.holly.idiocy.org> <83y364mtde.fsf@gnu.org> <20190225192102.GA3060@breton.holly.idiocy.org> <20190302132911.GA20556@breton.holly.idiocy.org> <87mujikx2p.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="165832"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mutt/1.11.3 (2019-02-01) Cc: Eli Zaretskii , emacs-devel@gnu.org To: "Basil L. Contovounesios" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon May 20 20:19:47 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hSmt0-000gym-P3 for ged-emacs-devel@m.gmane.org; Mon, 20 May 2019 20:19:46 +0200 Original-Received: from localhost ([127.0.0.1]:40042 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hSmsz-0007em-Cn for ged-emacs-devel@m.gmane.org; Mon, 20 May 2019 14:19:45 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45418) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hSmsF-0007eU-6I for emacs-devel@gnu.org; Mon, 20 May 2019 14:19:00 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hSmsD-00076G-Q3 for emacs-devel@gnu.org; Mon, 20 May 2019 14:18:58 -0400 Original-Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]:40272) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hSmsB-00074b-8G; Mon, 20 May 2019 14:18:55 -0400 Original-Received: by mail-wm1-x32d.google.com with SMTP id 15so294121wmg.5; Mon, 20 May 2019 11:18:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=AfNLebMiLBd9kf9Uc1D0VtY4Zqnqt+CHA9NNZbJTQtg=; b=SWmyViegPYK4PTbPss8DWqJQCc+4yk8+TtUsaww4sKnIw0ZzcaUNrSJnxDoMLcPQOe ROA7ziBEUB6ZqeNuCCxWTSS9NiO0DddvKvgWAUHYnjztXydF4vWXW7Czfe69CMKw9Vqq 7QaiLl10wcbPxLeZhuqhh4f3RGE14D+3WTm10ml8XOsDMQC64CSHGk+kBDNb/0wk7Sd8 Gi7jryXNkUx8oCdo5AF9EfraqI3ZSBXmhSfoeftvUE/TpdMpXA4X2JxYqhGWom2hAMY7 cNsZkE35biZ9nPoNcN52sHOdUx1Wsgbp4jAOYRkGBxVlT9an4p7Be/wW6QUsdcXFv/Y2 hemw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=AfNLebMiLBd9kf9Uc1D0VtY4Zqnqt+CHA9NNZbJTQtg=; b=NnOMlmuyElbgC0TuGpMTDaUH5M4JTCyC5uoIWurTmRdIa9rES0Zpmym4TFTUE6RaZy Yy5pFv87y84rdAaWv/e5hnk6xVj0HOMT3/nfKacAIcBUXbiKkzrIpRPRlPhR0mumd6G2 hlS21/aE3cgvtYGoaxkNYPytcPobQg6MwHwGJilXudhwiqllNUBAEwgIbrHxBPQT4K1W tOLpg7crRqCI/2b/d+hVSoR+ocdSCS0A/8eUXRnQ9xAz3vCLq5EAvQ9/zyTM3RbOx2il SXJCW+5vC9FJuysBdRqvmYYD+oVV3KwEw3G6SmBGTyKnN/RajV5alpQQmIrs5YaybbPG CmUw== X-Gm-Message-State: APjAAAV2QPEKCYF3dS2fNihvw2zsHCYEcniN6oEzd/Tba4RuWcPV+kY6 p1gefWW/+CMQEl1v1AMUMoU= X-Google-Smtp-Source: APXvYqxtcQtbiKDidmyWNCUSseyIAqxRCvo9qMEp/D0Uy8E8ZzZ2SVkbx8e75S0KF5CV3F+m6DBTeg== X-Received: by 2002:a05:600c:24a:: with SMTP id 10mr340085wmj.100.1558376330977; Mon, 20 May 2019 11:18:50 -0700 (PDT) Original-Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-a96e-154b-45c8-e27a.holly.idiocy.org. [2001:8b0:3f8:8129:a96e:154b:45c8:e27a]) by smtp.gmail.com with ESMTPSA id v184sm513075wma.6.2019.05.20.11.18.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 May 2019 11:18:50 -0700 (PDT) Content-Disposition: inline In-Reply-To: <87mujikx2p.fsf@tcd.ie> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::32d X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236811 Archived-At: On Sun, May 19, 2019 at 09:29:02PM +0100, Basil L. Contovounesios wrote: > Alan Third writes: > > > On Mon, Feb 25, 2019 at 07:21:02PM +0000, Alan Third wrote: > >> On Mon, Feb 25, 2019 at 05:36:46AM +0200, Eli Zaretskii wrote: > >> > > >> > It's indeed the clearing that bothered me, > >> > >> Would it be better if it was done by another XRender composite rather > >> than x_clear_area? > > > > I tried to replace this with XRenderFillRectangle, but realised I need > > to construct an XRenderColor struct, and I’ve no idea how to get the > > colour data held in img->background. > > > > I’ve attached a patch containing the original two, and the ability to > > crop. > > Thanks for working on this; I'm curious to know its status. I’ve sort of put Emacs development on a back burner for the moment. I’m planning on returning to this at some point, though. > BTW, I think native image rotation should support arbitrary angles (if > possible), if for no other reason than ImageMagick also supporting them. I do think there is an issue with masks and cursors that maybe wouldn’t be straight forward. I’m still somewhat unclear on how images, cursors and masks interact. If someone has a good solution I’d be happy to hear it, but of course it has to be passed by Eli too and I don’t know if his objections are the same as what I’m thinking of. I plan to go back and rewrite it to only handle 90 degree increments and submit that, at least for now. -- Alan Third