From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: make check fails due to missing test directory Date: Sat, 4 May 2019 09:24:06 +0000 Message-ID: <20190504092406.GA4139@ACM> References: <83d0kzmjw6.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="53669"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mutt/1.10.1 (2018-07-13) Cc: noloader@gmail.com, Eli Zaretskii , emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat May 04 11:24:55 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hMquc-000Dhh-8E for ged-emacs-devel@m.gmane.org; Sat, 04 May 2019 11:24:54 +0200 Original-Received: from localhost ([127.0.0.1]:53786 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMqub-00009V-AU for ged-emacs-devel@m.gmane.org; Sat, 04 May 2019 05:24:53 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51249) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMqtx-00009B-Cb for emacs-devel@gnu.org; Sat, 04 May 2019 05:24:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hMqtw-0002gn-BB for emacs-devel@gnu.org; Sat, 04 May 2019 05:24:13 -0400 Original-Received: from colin.muc.de ([193.149.48.1]:32592 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1hMqtw-0002fd-5I for emacs-devel@gnu.org; Sat, 04 May 2019 05:24:12 -0400 Original-Received: (qmail 79972 invoked by uid 3782); 4 May 2019 09:24:08 -0000 Original-Received: from acm.muc.de (p4FE150FB.dip0.t-ipconnect.de [79.225.80.251]) by colin.muc.de (tmda-ofmipd) with ESMTP; Sat, 04 May 2019 11:24:06 +0200 Original-Received: (qmail 4155 invoked by uid 1000); 4 May 2019 09:24:06 -0000 Content-Disposition: inline In-Reply-To: X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x [fuzzy] X-Received-From: 193.149.48.1 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236140 Archived-At: Hello, Paul On Fri, May 03, 2019 at 15:01:58 -0700, Paul Eggert wrote: > On 5/3/19 12:13 PM, Eli Zaretskii wrote: > > You need to download the test suite. It is not part of the release > > tarball. You can find it in the Emacs development repository. > Sure, but as his email suggests, it's better for 'make check' to succeed > when the set of tests is empty. That way, standardized build procedures > (like his) are more likely to do the right thing. I installed the patch > 0001 (attached) into the master branch to do that. > We've talked before about distributing tests in the Emacs tarball - > which is what the GNU Codings Standards recommend and what pretty much > every other GNU package does - and this email suggests that now's a good > time to do that. Distributing tests adds about 2.5% to the size of the > compressed tarball, and nowadays that is a small price to pay for making > tests available to people building from a release tarball rather than a > Git clone. Proposed patch attached as patch 0002, and comments welcome. The tests in make check are development tests. They're not build tests. In fact, they're fairly useless for anybody who isn't developing Emacs. Somebody who is developing Emacs will have the git repository. Therefore, we shouldn't be encouraging users to run these tests, just as we don't encourage users to byte compile the .el files. Both these things have been done as part of the release process, and both are wastes of time for users. I, personally, would certainly not run these tests after downloading an Emacs release. So I think, if we're going to include these tests in releases, there should be a strong recommendation in the docs NOT to run them, that they're only there for people with special needs. -- Alan Mackenzie (Nuremberg, Germany).