From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: isearch region or thing at point. Date: Wed, 1 May 2019 18:03:44 +0200 Message-ID: <20190501160344.qfh7fslj23meprzu@Ergus> References: <20190427001453.isjx247kc3lu5fe4@Ergus> <87a7gcp51i.fsf@tcd.ie> <20190429004135.rn5tp2gnmbjovrxj@Ergus> <87h8agy4yf.fsf@mail.linkov.net> <20190430162501.xmqh5r5h57sjjlq5@Ergus> <87h8af15kg.fsf@tcd.ie> <20190430231614.l423x6eqta5fbhor@Ergus> <874l6f132f.fsf@tcd.ie> <20190501112025.fnsynkbmkvllapyv@Ergus> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="7015"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: NeoMutt/20180716 Cc: "Basil L. Contovounesios" , emacs-devel@gnu.org, Juri Linkov To: Drew Adams Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed May 01 18:05:10 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hLrjJ-0001f4-VP for ged-emacs-devel@m.gmane.org; Wed, 01 May 2019 18:05:10 +0200 Original-Received: from localhost ([127.0.0.1]:34563 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLrjJ-0003kP-0O for ged-emacs-devel@m.gmane.org; Wed, 01 May 2019 12:05:09 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:43623) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLriM-0003i3-8t for emacs-devel@gnu.org; Wed, 01 May 2019 12:04:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hLriJ-0000dm-4D for emacs-devel@gnu.org; Wed, 01 May 2019 12:04:10 -0400 Original-Received: from sonic311-31.consmr.mail.ir2.yahoo.com ([77.238.176.163]:46123) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hLriH-0000Pr-4m for emacs-devel@gnu.org; Wed, 01 May 2019 12:04:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1556726631; bh=Y5Dij3hkv+f9Rzx37KvlUsEZebDVkeOCiauTenH/Nhw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=AMY1JRtblteCXK/2HLigI+poy0w4tyW8XH0s4RUiwgI4F6e/SIjsYPHVmnNGeqY/yk7vZTKi1g3u3p5YXZQPB/T8fcmf1gKY0/ycBAup5cugllBKgtlaITyU7SjOgF1TGbvhH0RPMAKMyHDcqeXAhHHSKPxqa9Qmc6XcjeOvKr7y+dnAL5e1eCQcwbYw1rAxAMGOeLbysFaFF/1KucrxkOVNAGk4Xko7jGsGL91YFKfBQSclVvChGARYiHeVooEHh+vQN/f/HPhpbfeBinPISxC/jYzkU9qi5niJPjulfc7o+sX112jkyMOY9pycbhCRRJKGFfJ5dLOTjjCWmOxW8w== X-YMail-OSG: JsVKKRYVM1lz190t32leslQhk8ncr3tyYUVKnI6.b9ko27tHspKq7RKHgMJqXnp 9OFzc3EeLdQSH3yG8.BAEwVCOu3II8QWAbe6aPynMsD7YD15_waNX8ZMxapC0tRjSDmeaN_2SQX2 c4P240HOp2tau7xwRdbYOujgEO04vOffeijo_WgpsRK30F7ZiEw0yUUkuPiV0HZiIoOtZCbaAmAN 3ZECQEo4CtbFevWoSIpiZOntuytszy03QD9hdQILMxiPjmoSFiX8vkR6B0eUSmROrl6WOeAbD7.F Oyk_t8a1NAg.KgQpCabZODuFfFJc8OYp_pAR7nmFyAruuPIJ9AtrVMKzuC0D7PgC00KaUzSy2BYX 3WQ.PuWO9sERM9aGS4dlzfpaDX7nLdM4i2vCENAohPr8tuI5nJOXvBsdgQ9RRvkCts4gbHPZ3N8W MVaRVdYtc31_jOxaPg1rmewQoxOilkEzSRokbP3waqogoU6K_43XyBZrKki.1i0_7yjTwQHnWeCC 34JgZ_Tho1Ej_pMxd7rkncXvXGY.rO2VmHmYOc_1NBstt29wD4d5Ke76D1tTumNpgcp4K8tHoxP9 52_NQyduY9DwJCa0VAnH1wGeq5V5nP8oBMPwrFkL5nAgOk_0.lr24KYf6J2XqHB.gtC8lKb1bjVQ q20E6OUfmkKgyNMwZRyU4wa20ut_WY_DH5Msq7Jw26Pa4Jhm.Z6RAk9YNyckwoOgZbJWXnRepIVM rP1ZnY.h5Vm_VLZIm6MmNwLj3QiqVdwuIT3mm6ynlt7vZBTvJOJGlW_rA_CQIYJf18QibiY6I9Sw B6O1XyXIRaQxF7Ejc1s_Y1MlyGqvXl24FLTgesjTfZ Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic311.consmr.mail.ir2.yahoo.com with HTTP; Wed, 1 May 2019 16:03:51 +0000 Original-Received: from 2.152.205.184.dyn.user.ono.com (EHLO Ergus) ([2.152.205.184]) by smtp410.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID e0a8056fd90a72d01d2fd71893c792c0; Wed, 01 May 2019 16:03:47 +0000 (UTC) Content-Disposition: inline In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 77.238.176.163 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236093 Archived-At: Hi Drew: I would prefer a keybind for it, even a different one, but otherwise nobody will use the command and the people will continue using workarounds like now. I didn't take M-y or C-y because they were already taken and M-w was not colliding with anything in my emacs -Q. Many people just find the emacs commands while using emacs (thanks to which-key or counsel-completion or Helm they discover the keybinds) and commands without a keybind are VERY less visible/accessible unless they explicitly know and configure a bind for them. The users find them only after reading a lot of documentation in the manual (which no many people do). But which-key simplifies the life a lot. Specially for new users. In fact the "right" to do (IN MY OPINION) is to define a keybind for all the commands like this. (which insert text from active-region into minibuffer once in the minibuffer, that could help for replace-regex/find-file/flyspell/and many others) that will solve a lot of collisions and will simplify the user experience a lot. (memorization) We have a lot of package that already proposes patches for this issue trying to figure out somehow when to insert text from region (or near to point) to the minibuffer (all the thing-at-point-like packages in elpa && melpa are workarounds for this general issue). BTW: The isearch+ package isn't in elpa||melpa?? I can't find it in the packages-list, so probably that's why I didn't check it before (I try to avoid this kind of issues as much as possible before proposing changes). Is there any reason why it is not in elpa||melpa? Because I don't know anyone who uses it; for sure because they don't know it. Let's wait for Eli, Basil and the others... Maybe they will propose a genial solution (as usual). On Wed, May 01, 2019 at 07:33:27AM -0700, Drew Adams wrote: >I'm sorry to say that I'm not in favor of `M-w' >being bound in `isearch-mode-map' for this behavior. > >I'm not opposed to some key being bound for it, >though I'd prefer that we just define the command >and leave it unbound (letting users bind it if they >find it handier than just using `M-w' before `C-s'). > >In Isearch+ I bind `M-w' to `isearchp-kill-ring-save', >which I feel is more useful than your command, which >is a short cut for the usual Emacs keys. > >`isearchp-kill-ring-save' copies the current search >string to the kill ring. > >I've bound it to `M-w' in the search map since 2013, >when we moved `isearch-toggle-word' from `M-w' to >`M-s w'. > >How about just adding your command and not binding >it by default?