From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: Fill column indicator functionality Date: Sat, 6 Apr 2019 13:06:52 +0200 Message-ID: <20190406110652.sehoccflrntd4yod@Ergus> References: <20190405103614.oivi4mtlnklldli4@Ergus> <835zrsd670.fsf@gnu.org> <20190405150404.bm2d6wjtivwyesek@Ergus> <83r2agbhwv.fsf@gnu.org> <20190405173010.snavjhxrmmufwp54@Ergus> <83h8bcb7ce.fsf@gnu.org> <20190405200319.jfwt7lgevas556id@Ergus> <87zhp4w42x.fsf@telefonica.net> <835zrrbpbm.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="206864"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: NeoMutt/20180716 Cc: =?utf-8?B?w5NzY2Fy?= Fuentes , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Apr 06 13:07:42 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hCjAj-000rdF-Pu for ged-emacs-devel@m.gmane.org; Sat, 06 Apr 2019 13:07:42 +0200 Original-Received: from localhost ([127.0.0.1]:53495 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hCjAi-0006Jp-AY for ged-emacs-devel@m.gmane.org; Sat, 06 Apr 2019 07:07:40 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:46630) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hCjA8-0006Jk-0c for emacs-devel@gnu.org; Sat, 06 Apr 2019 07:07:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hCjA5-0008FB-D4 for emacs-devel@gnu.org; Sat, 06 Apr 2019 07:07:03 -0400 Original-Received: from sonic314-19.consmr.mail.ir2.yahoo.com ([77.238.177.145]:40968) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hCjA4-0008Bp-B5 for emacs-devel@gnu.org; Sat, 06 Apr 2019 07:07:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1554548815; bh=0YD/aUV3pCu5KYTdMmqhl95rLbh2hKTGc3hLRbH6jKk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=diQE9c3c+g2Etj42bujTLE94alyPgTj1v+/9ppl4Fd4si8MD+O3qO74IHYuuGAS/ub9O/FY6CNh+UN3NPOEGevIiNbipEzgCddZR7YX7RaPtUGCXY2XdqjWLzS/2ULa0cX7lZDjfnPs2COuIatVvh62kGfNiIN221lhK63KRwSaWrOUPc8dRQiPSkCbAEKqMM3lfnjFG4Crab6JdHHMdVXgkLxeqSvUnSXoBMRRkShYwo83Pdzt1KEsrXfnr+RUh471eRWiXTYlKmveNdbF2uf4nP/mKEn+reNHdVVgUwhgBWY+URIZWMdOGbhhOtj+HWAsECUAoK4rEnSWrtz2HKQ== X-YMail-OSG: gKOLhNsVM1kVGIXXm9GpdY08R0ztNra8q9wSIKsNJRCjnA6fu7i29QzuLdqwYwb H34E87Fd5hKRu1Rp6YkdR9zOPVWkX5UJSJkFW5AFp9l0XhQQdr1GeyJt1Oeg3PXwziSa_.6xFU_0 M7eSSCUnG.Uz7MpQaelLMGS08535dy4jEuoPO8fKwkD3bn5wFM6hbTXTrqaA8HvKyhOrcsZSH18Z DG50llDyoQq9d_5t1Gu_xW3FwMDUvysz1yHlcyft_o_us5dxYi0OjAAoEnoszyyKQuAmKuTTVvq. 1._vPvCXbUZSBAslzpZsUDodX5NDg2qfYFEKFq7l4sAVloYoS4S8xm3uNKmB3aLCoZH3osTvmQ4W Q24z7PBmbGlSubIErbTZ6tu4vFflfiPxucX8dBYAO7JSNFeDU4g4LUlpjqsMXKSbpREKktviDSoc g2WUqppRdCVhfdvf0jx.83D6lqidV5YjKVmiQMzDpveER0Nmw30dq7CwXJISkWrG2OcQd0UJEfXN lO5dRI1RuvA2csr6M9Rj5XxgM7ETu817ZBgndq4tDd5NQd.ALdrZwvAN_LusDJ4EWNXVbV6Xr_5u tLOU_kf3a2JWBshlRgczC.7tqWIknNOEODpnNSrBaDK2FwZ8yYoildcuGK03yhSHQT5q1EML0c4I nJQ6XnaJp.YGDlbsBNtJ9UblsM.9yHe9f0DK.6il2P4QOLlk3Abryvl0kmpBSqdazq.KxGdwHX5x cBs_zgh79cCs3jnkXe1Huae7BWSrmUr_MKHEdqwSTIhODh4GlLQmyj0LDoFlXDnV1Gdk.bh2fguG OPhCISS2v83Gz9PT18jRAJVLfo.dXSkSA7wh4k1WVM Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic314.consmr.mail.ir2.yahoo.com with HTTP; Sat, 6 Apr 2019 11:06:55 +0000 Original-Received: from 2.152.205.184.dyn.user.ono.com (EHLO Ergus) ([2.152.205.184]) by smtp432.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 538a23c0664ce2bf1f260807c4c31d3b; Sat, 06 Apr 2019 11:06:54 +0000 (UTC) Content-Disposition: inline In-Reply-To: <835zrrbpbm.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 77.238.177.145 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235026 Archived-At: On Sat, Apr 06, 2019 at 09:49:49AM +0300, Eli Zaretskii wrote: >> From: Óscar Fuentes >> Date: Fri, 05 Apr 2019 23:10:46 +0200 >> >> I have a patch from some days ago applied here, sorry if this is >> outdated, but I see something suspicious. After M-x customize-variable >> display-fill-column-indicator-character : >> >> >> Hide display-fill-column-indicator-character: nil >> State : STANDARD. (mismatch) >> Character to draw the indicator when ‘display-fill-column-indicator’ is non-n >> >> >> That "nil" and "mismatch" are not right. This is the definition of the >> variable in xdisp.c: >> >> >> DEFVAR_LISP ("display-fill-column-indicator-character", Vdisplay_fill_column_indicator_character, >> doc: /* Character to draw the indicator when `display-fill-column-indicator' is non-nil. >> The default is U+2502 but a good alternative is (ascii 124) if >> the font in fill-column-face does not support Unicode characters. */); >> Vdisplay_fill_column_indicator_character = Qnil; >> DEFSYM (Qdisplay_fill_column_indicator_character, "display-fill-column-indicator-character"); >> Fmake_variable_buffer_local (Qdisplay_fill_column_indicator_character); > >Hmm... why do we need those DEFSYMs? I don't think the Qfoo symbols >are ever used in C, are they? Do the problems go away if you remove >the DEFSYMS? > Hi Eli: I just followed the same schema than the display-line-numbers variables some lines before. (and many other variables) What are actually the Qfoo symbols for? I thought they where for make buffer local variables? Actually the question is: Why are we not using those? instead of Vdisplay_fill_column_indicator_character? Maybe these are dumb questions, but now is when the real doubt came out.