From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: Fill column indicator functionality Date: Tue, 2 Apr 2019 18:36:23 +0200 Message-ID: <20190402163623.2gvlraa5qitzgi6y@Ergus> References: <20190318010313.rec67ljatygf5xlf@Ergus> <837ecwx3ao.fsf@gnu.org> <20190318114249.ouqxfghhw5dfr5ry@Ergus> <83y35cumzs.fsf@gnu.org> <20190402124236.cpb63pdopfk6vpj5@Ergus> <87k1gczhi8.fsf@telefonica.net> <20190402133718.z464xomdq6l3pfrl@Ergus> <83pnq4fnte.fsf@gnu.org> <20190402153504.jfliuexzn4ntqnn4@Ergus> <83k1gcfm3y.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="216099"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: NeoMutt/20180716 Cc: ofv@wanadoo.es, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 02 18:37:30 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hBMPh-000u58-RV for ged-emacs-devel@m.gmane.org; Tue, 02 Apr 2019 18:37:30 +0200 Original-Received: from localhost ([127.0.0.1]:53434 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hBMPg-0006KF-Ro for ged-emacs-devel@m.gmane.org; Tue, 02 Apr 2019 12:37:28 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:38893) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hBMPW-0006HM-3f for emacs-devel@gnu.org; Tue, 02 Apr 2019 12:37:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hBMOj-0003Lf-PX for emacs-devel@gnu.org; Tue, 02 Apr 2019 12:36:30 -0400 Original-Received: from sonic304-22.consmr.mail.ir2.yahoo.com ([77.238.179.147]:42866) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hBMOj-0003IZ-9W for emacs-devel@gnu.org; Tue, 02 Apr 2019 12:36:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1554222987; bh=VNvwV0uFx6ogunL/UQup+uRI3z6TSS5FzSDYE7Efy6Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=kqOKosoh5QsTUQLWDYp16pUGpAuvyDqcQntc2C8AMYS1qijlKcVCxbNQFWITlb0g4VyTQX1pRQbLmgd27T2VS6VMbXfYA4Mrw4aEzV8MitQ7mUcAhNZ0TZ5z3OUoBkPVxsaUfLd9JuYpqxMuQD95dF5VDFE+Koo/UMR1hn0nOHepDvu7B0ugBh4bQmWcG9F3kbY5KROpsSuL0oOTrjF2tafjQBb/U7yda1+ajXTn4VdjpXHAlzdjgTPedPALpzKkmZ76zwHcoO259FjE+6vUFWefkJxniQ4xY6s8kuQsH65gteRdNrNy6XRTezBpavv8Sm6cUBSe4bv4AkwMejDHYg== X-YMail-OSG: ..ZeaNQVM1mnLXQ_OxfatDd3GNmWLIE2laBU_fluGV27Fr.GqCMT6TYFPeVf39W fTjLkoLXOYQx0ZJRnRwMI3NZNvsPcy1DcLw93fDgiENxO4dtMEq6_Zd2w7G09rqXGx18Gujv.yPF QsXyv86uEmWJJfCIJc2Sa2Bz6bNQo8YRFfl6CK2C5bjbQVgPNh7.LnSAw_dYZiUhRJT7ALyeW.4K O6km6EYn2yxkjMRLA6ck38VZR_TRrSGEl5vHqCaMCQU_qWnpW5P17SvcuO0Bd9wZaqt15aWH11ip w6EDOo2YpqCwOYMmS8E8b1orywRbGCy1YEaUkV2hLxHrMOlhhiJPSinLvN9oWfLe07ybQtji9j9j u6b4TuxXLI1YaFgITf6lPS1wsJ1eHQvoV8fZolBxa7bNo43U.47XUkUGgPVU5P6vJNVu4ox2DtpI x8NMjme._WSj2mEBN_NQDgbH6OVS0yioDpQV_ZMAd2b38ad9fALKC0Qz_h_N11Fc._xJykzcCBsy Kul0OmmmPCsF74bNuAD0ww5NrIVWcw.3aYHxw66CKwq6OhzJCwJVLgjtT1PMjxRskJK48DkwOHaB d.x9CMTY.OibjQhbQBUVRTIvQ8G98AgBv7BKafccUWk4zSjBylK3XhKtVnW51v.FLoqDzr836oNm KFRmrrqRPKADiv3MlL4IRZOlxgnIPKyMgLuChOkpcIsL4Xs_icVWzlEL.qAzr4RxXMseJ8qPu9L1 .QZtvJV4.ERmqwPscZfBOqNh7cK1sYFjazzP.BE8JtHDyc.KnmtcdscegwPpccR28e3xxUDqPedB IRKuocPhh3yA3LEQ887Xs0oetUc0UcP_SyDeg0uNUt Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic304.consmr.mail.ir2.yahoo.com with HTTP; Tue, 2 Apr 2019 16:36:27 +0000 Original-Received: from 2.152.205.184.dyn.user.ono.com (EHLO Ergus) ([2.152.205.184]) by smtp424.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID b9919fb6efa8c3465003044120086c9a; Tue, 02 Apr 2019 16:36:26 +0000 (UTC) Content-Disposition: inline In-Reply-To: <83k1gcfm3y.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 77.238.179.147 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234875 Archived-At: I just pushed a new branch with the fill-column-indicator feature. I would prefer to rebase before pushing to the master branch. (In my ideal world I will rebase and then do a merge with -no-ff. But this is not the workflow you have here) So, how is decided when to move this to the master branch? (the equivalent to accept the pull request) There are changes in the NEWS already but not in the manual. So, just tell me the following steps. Best, Ergus On Tue, Apr 02, 2019 at 06:44:17PM +0300, Eli Zaretskii wrote: >> Date: Tue, 2 Apr 2019 17:35:04 +0200 >> From: Ergus >> Cc: ofv@wanadoo.es, emacs-devel@gnu.org >> >> Ok, it is done in the simpler way then, I just added the extra if: >> >> && (it->continuation_lines_width == 0) \ >> >> and moved everything to a macro. I think this is enough right? > >Yes, I think so.