From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Ergus Newsgroups: gmane.emacs.devel Subject: Re: Fill column indicator functionality Date: Fri, 8 Mar 2019 19:57:46 +0100 Message-ID: <20190308185744.a4vnfoab5wdvqyny@Ergus> References: <20190205184720.nd43dg5ho47dhqfe@Ergus> <83tvhgsxvm.fsf@gnu.org> <20190206222524.zic6idgs2vkglg7h@Ergus> <8736p0nznz.fsf@tcd.ie> <837eebsmaj.fsf@gnu.org> <87sgwvco1l.fsf@Ergus.i-did-not-set--mail-host-address--so-tickle-me> <83r2cel3qf.fsf@gnu.org> <20190211165636.ch5x4wb2ibdt2dzy@Ergus> <83ef8el03u.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="197962"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: NeoMutt/20180716 Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Mar 08 19:58:38 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h2KhZ-000pLo-9U for ged-emacs-devel@m.gmane.org; Fri, 08 Mar 2019 19:58:37 +0100 Original-Received: from localhost ([127.0.0.1]:48560 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h2KhU-00015t-TD for ged-emacs-devel@m.gmane.org; Fri, 08 Mar 2019 13:58:32 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:56769) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h2KhM-00014Z-3x for emacs-devel@gnu.org; Fri, 08 Mar 2019 13:58:24 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h2KhL-0000a7-BG for emacs-devel@gnu.org; Fri, 08 Mar 2019 13:58:24 -0500 Original-Received: from sonic304-22.consmr.mail.ir2.yahoo.com ([77.238.179.147]:38025) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h2KhL-0000Y9-4u for emacs-devel@gnu.org; Fri, 08 Mar 2019 13:58:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1552071500; bh=BKt1NuWv3IHQnwriQZ9iM+hPqfrSXuvaj8xLCBNQ6no=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From:Subject; b=W4mTeJtVTz47kjHBkoUZXC0DpQNsYfGqUX93U/wIUEsBJhGE3juvqKwfMuXPNK78R38ZY/TrF/o8oXDbuvEn1q8Zo79YFYWINlnR+ulppV2YqhKHENWMMVgggzgBVjjRYSujtT0rSjlGukE/6dSQdh+BHMO5I7CbAeKFKaCw57ULLdsLUJnuA725tcy9pE9s4HNbU9qTk7VkoJ2QIubk4TzUoJS8xYSxnJjOhSrgT/3Ay2HmZ/D4itzRmj5A7+OReY+JhtAyiIdhHhU2Y4v8LeQndDifU3nmue2oGm9+OfOEd+prnqDw12lmH9dKX2HUvCF/0VSYh0R+cyxsVSJYSA== X-YMail-OSG: 9EhUkHsVM1nbgumMpxA96kt18.PaIaxu49wMNCqjhDrAzULyY._nBm7EvpZU7xg b20CRP.hCSlzx0gq3dtRLQg3S.kYoQ8PnQNvoilKT84EchoylN0VWWh8kr9MzWEk7bp3w0Vv09a5 he9PgEq_h4c9wr8n9.0OMg3k3GpkwWsakAJPv7GACa9t0dhB9353ENNpiY7MD0SIAmNy3Bi3M1tM pAyUrh.vAbT7Sm2XQXHx3Jwv0BRjfjzyYeDZqc1I6xNdg8VpAnEHd.stFIVxVv04QAdOeOzOSi8R RtVAgkxyfIWiUU.Jv_Yn84Gfkq.aCepxF0Tg7o5ZHq4pi34PGVQbj6K2qSvAnehSqlrawrPRWLno 9WDgloORVchJku7APJN5Z9wKt.Topj_dJosEHqMv7xkS3mj74Al0zw2Vhs._ZcLh_JbNa6lNxqNc jwVkcaNzVijljykvD6Key7AdWmrUAGeGWdNaA_vPXy6bSFB4XVcxknEMZBG8Ih5oYWGE9ZTcC.hd bTlQkPW1FAuYVA1z28REoeeiLTX9.sbLiN7laNiTR2_z1VJZo1ZVJaXc4QNtfW2fcgel1orJi2k_ oRi35K7kWQGIlLiu7dpSPZRHIwVgBEPD_TEjMJcdoa6yejrUy54BkIcq2g9sFz6BSccaSE0yVlRY r4vy6QTlE_A04dz_b.iwwT5oIk7QFveIrv0CjjAl1AikAyrlxqbGyndBbrIPQH7gzbiWCnaa6G0d 7gcR2d8TfWaACKb40QUqtmFZcJu.86OFHK4PbuTnon6QdbouINrFV30LV7lj8ol3cZDDHARBUoBJ mUIx.YwGO_TpUC46p5WGeV4n3VdJQJO8TWJUKhaWGd Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic304.consmr.mail.ir2.yahoo.com with HTTP; Fri, 8 Mar 2019 18:58:20 +0000 Original-Received: from 2.152.205.184.dyn.user.ono.com (EHLO Ergus) ([2.152.205.184]) by smtp406.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID be8b4c11f7291166a70fd8e7b42c86a6; Fri, 08 Mar 2019 18:57:50 +0000 (UTC) Content-Disposition: inline In-Reply-To: <83ef8el03u.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 77.238.179.147 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:233936 Archived-At: Hi all: I have been playing with the display engine in order to try to implement this functionality (at least a proof of concept). But after reading the comments and the ~33E3 lines in xdisp.c there are more questions now than answers. The simplest approach I see is to add a '|' (or similar) in the desired column in the "at_end_of_line:" label. But maybe there is a better approach? My approach is somehow based on the display_line_numbers, but taking into account that in this case the characters are always the same, maybe there is a way to set them in the background and it will be simpler? Is it there any documentation about this? specially the relations between the data structures? because the it and the glyphs are very confusing. Any help please? On Mon, Feb 11, 2019 at 07:13:25PM +0200, Eli Zaretskii wrote: >> Date: Mon, 11 Feb 2019 17:56:36 +0100 >> From: Jimmy Aguilar Mena >> Cc: Ergus , contovob@tcd.ie, john@yates-sheets.org, >> emacs-devel@gnu.org >> >> >> I have been checking the display engine and the commits to add the >> >> display-line-number functionality. With this, it really looks much >> >> simpler to implement the version of the vertical line (character at >> >> column X). >> > >> >I'm not sure I understand: much simpler than what alternative? >> > >> The color change one. > >I don't think it's easier, I think both could be implemented with >similar efforts, and in the same place in the code. (Caveat: I only >thought a little bit about the implementation, so I might be missing >some important details.) > >> BTW, is it there any legal paperwork before contributing? > >If you don't have a copyright assignment for contributing to Emacs, >you should start the legal paperwork rolling, so that it's in place by >the time you will have code to contribute. > >Thanks. >