From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.devel Subject: Re: Native image rotation Date: Mon, 25 Feb 2019 19:21:02 +0000 Message-ID: <20190225192102.GA3060@breton.holly.idiocy.org> References: <20190224113050.GA67303@breton.holly.idiocy.org> <83tvgtnoyh.fsf@gnu.org> <20190224232228.GA67813@breton.holly.idiocy.org> <83y364mtde.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="47262"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mutt/1.11.2 (2019-01-07) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Feb 25 20:21:19 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gyLoV-000CC2-AO for ged-emacs-devel@m.gmane.org; Mon, 25 Feb 2019 20:21:19 +0100 Original-Received: from localhost ([127.0.0.1]:43177 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gyLoU-0007Np-8h for ged-emacs-devel@m.gmane.org; Mon, 25 Feb 2019 14:21:18 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:41019) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gyLoN-0007Ni-PI for emacs-devel@gnu.org; Mon, 25 Feb 2019 14:21:13 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gyLoM-0000uZ-Pi for emacs-devel@gnu.org; Mon, 25 Feb 2019 14:21:11 -0500 Original-Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]:37694) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gyLoI-0000r0-Sl; Mon, 25 Feb 2019 14:21:07 -0500 Original-Received: by mail-wm1-x32d.google.com with SMTP id x10so85311wmg.2; Mon, 25 Feb 2019 11:21:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=cq94Qaui8eD/9bIIsUa+TvJmVWhguENhsXS/XaojEas=; b=rgPb1VQH/PxG0aQ2cIqiqxtZdjiA/BSYqww9Tt3mpmoyS5yVu3l1cQ2W5855KC7cdW m3de+udbCiSElH/+ygRZQQDzbQ+bdBpCVuoVdRvoD+lny4cE3nHT4/tgLmCIev+O2Mss z+lBZEdynn0ei/YCgwfahbjwu3YfbXhALLdKi8HypL2YWwUkhSkVXz4SO3gmQDozMwQV rs74xz3dUAOlvG1uNy2eKz5BzOXj9jtPWs/0OdSwe/RugYcje1cKToHkCcUtGNUpM/gM nktiVJVFiEg6ifxBLQKUDqPYeL0cI2En8KxYNexFH95xBrbbDSAGyTKfgTRS5MTvJrwE b1Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=cq94Qaui8eD/9bIIsUa+TvJmVWhguENhsXS/XaojEas=; b=AKU/9pMfY4NIMvrZpUsSyVEtjN9iv7cWPaCnZ8AmwTuTLTzob0SX+88QoON1Sr4201 xm98iAjQ9LkqFmksD+B2fPuNit3/ToE//A/FmfeYa7frC9Z5UnRIAHf151xVpxVLQhmJ L8yzy0C5IdTVQSnFdvPaCNEhsm/rxhPGVJMgERFmC0yLtoUhU6tUWNduir2aVAbhJ2Q4 C0GiiRIL7jxNBYcrmCUDFy0OqjXKlJLKnlmupRnf1XF1IUobfBUFjP1WDiadQR1MPDjX ovYua6YoMzpCIXyZnMwjyAAEuX5KnAuKj02PokZYItWrF8jQbin7j+q9RfUfp4qq5YpF gJEQ== X-Gm-Message-State: AHQUAuaZ1svaFPHCI7RC2VUi709jzPE6mZcNZ4825qabJf6XQXUEZo8/ FUbg1njop0StUto888lRA2tWmV1q X-Google-Smtp-Source: AHgI3IYxkyFRMfIgWvOcAdqS59V9D9zwXhTtisyfVMJm5uKe5dq8+TgVSlmnf09ftQw9oG0Ky390Hg== X-Received: by 2002:a1c:be04:: with SMTP id o4mr209330wmf.19.1551122464805; Mon, 25 Feb 2019 11:21:04 -0800 (PST) Original-Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-b45d-8a12-0e92-554b.holly.idiocy.org. [2001:8b0:3f8:8129:b45d:8a12:e92:554b]) by smtp.gmail.com with ESMTPSA id z17sm8204579wrs.75.2019.02.25.11.21.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Feb 2019 11:21:03 -0800 (PST) Content-Disposition: inline In-Reply-To: <83y364mtde.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::32d X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:233612 Archived-At: On Mon, Feb 25, 2019 at 05:36:46AM +0200, Eli Zaretskii wrote: > > Date: Sun, 24 Feb 2019 23:22:28 +0000 > > From: Alan Third > > Cc: emacs-devel@gnu.org > > > > And I guess we maybe wouldn’t have to worry about clearing under the > > image any more in X: rotating can leave transparent sections. > > > > But the maths is performed only once, when the image is loaded, so I > > doubt we’d find a significant improvement. > > It's indeed the clearing that bothered me, Would it be better if it was done by another XRender composite rather than x_clear_area? If this really is a problem then I think we have to allow only 90 degree multiples. I can’t see any other reasonable solution. > and also the increase in the screen estate taken by a rotated image. I think that would be less of an issue with the addition of cropping, as an image could be rotated then cropped down to size. Besides, if someone wants to rotate at 45 degrees they’ve got to expect the size of the image to change, there’s no other reasonable option. > I'm asking whether it's worth it. Limiting to 90 degree increments feels like an arbitrary limitation, but I don’t feel strongly about it either way. -- Alan Third