From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: master 223e7b8: Make CC Mode and electric-pair-mode work together. This fixes bug #33794 Date: Wed, 16 Jan 2019 18:05:06 +0000 Message-ID: <20190116180506.GA2988@ACM> References: <20190115160812.12319.90321@vcs0.savannah.gnu.org> <20190115160813.EFFD4209E3@vcs0.savannah.gnu.org> <87ef9dijn1.fsf@gmx.de> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1547662610 15688 195.159.176.226 (16 Jan 2019 18:16:50 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 16 Jan 2019 18:16:50 +0000 (UTC) User-Agent: Mutt/1.10.1 (2018-07-13) Cc: emacs-devel@gnu.org To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jan 16 19:16:45 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gjpk5-0003xo-En for ged-emacs-devel@m.gmane.org; Wed, 16 Jan 2019 19:16:45 +0100 Original-Received: from localhost ([127.0.0.1]:40081 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gjpmC-00045V-LZ for ged-emacs-devel@m.gmane.org; Wed, 16 Jan 2019 13:18:56 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:57088) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gjpjY-0002qg-62 for emacs-devel@gnu.org; Wed, 16 Jan 2019 13:16:13 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gjpjV-0005Fo-7x for emacs-devel@gnu.org; Wed, 16 Jan 2019 13:16:10 -0500 Original-Received: from colin.muc.de ([193.149.48.1]:25199 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1gjpjU-0004te-TB for emacs-devel@gnu.org; Wed, 16 Jan 2019 13:16:09 -0500 Original-Received: (qmail 4794 invoked by uid 3782); 16 Jan 2019 18:15:55 -0000 Original-Received: from acm.muc.de (p2E5D5805.dip0.t-ipconnect.de [46.93.88.5]) by colin.muc.de (tmda-ofmipd) with ESMTP; Wed, 16 Jan 2019 19:15:54 +0100 Original-Received: (qmail 3057 invoked by uid 1000); 16 Jan 2019 18:05:06 -0000 Content-Disposition: inline In-Reply-To: <87ef9dijn1.fsf@gmx.de> X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x [fuzzy] X-Received-From: 193.149.48.1 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:232400 Archived-At: Hello, Michael. On Wed, Jan 16, 2019 at 00:30:26 +0100, Michael Albinus wrote: > acm@muc.de (Alan Mackenzie) writes: > Hi Alan, > > branch: master > > commit 223e7b87872d4a010ae1c9a6f09a9c15aee46692 > > Author: Alan Mackenzie > > Commit: Alan Mackenzie > > Make CC Mode and electric-pair-mode work together. This fixes bug #33794 > This seems to break electric-tests.el: Thanks! Part of the problem is in CC Mode, still. Another part of the problem is electric-tests.el making assumptions about CC Mode's implementation (which has recently changed). Thanks for reminding me to run make check. ;-( Incidentally, there's a test engine in electric-tests.el which is 100% undocumented (no doc string, no comments in functions like electric-pair-test-for and electric-pair-define-test-form). It would be appreciated if anybody reading this who understands any of these functions could add doc strings to them. > --8<---------------cut here---------------start------------->8--- > # make -C test electric-tests > Ran 475 tests, 387 results as expected, 88 unexpected (2019-01-16 00:28:55+0100, 214.752138 sec) > 1 expected failures > 88 unexpected results: > FAILED electric-layout-int-main-allman-style > FAILED electric-layout-int-main-kernel-style [ .... ] > FAILED electric-pair-whitespace-jumping-at-point-8-in-c++-mode-in-comments > FAILED electric-pair-whitespace-jumping-at-point-9-in-c++-mode-in-comments [ .... ] > Best regards, Michael. -- Alan Mackenzie (Nuremberg, Germany).