From: Alan Mackenzie <acm@muc.de>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: emacs-devel@gnu.org
Subject: Re: master 223e7b8: Make CC Mode and electric-pair-mode work together. This fixes bug #33794
Date: Wed, 16 Jan 2019 18:05:06 +0000 [thread overview]
Message-ID: <20190116180506.GA2988@ACM> (raw)
In-Reply-To: <87ef9dijn1.fsf@gmx.de>
Hello, Michael.
On Wed, Jan 16, 2019 at 00:30:26 +0100, Michael Albinus wrote:
> acm@muc.de (Alan Mackenzie) writes:
> Hi Alan,
> > branch: master
> > commit 223e7b87872d4a010ae1c9a6f09a9c15aee46692
> > Author: Alan Mackenzie <acm@muc.de>
> > Commit: Alan Mackenzie <acm@muc.de>
> > Make CC Mode and electric-pair-mode work together. This fixes bug #33794
> This seems to break electric-tests.el:
Thanks! Part of the problem is in CC Mode, still. Another part of the
problem is electric-tests.el making assumptions about CC Mode's
implementation (which has recently changed). Thanks for reminding me to
run make check. ;-(
Incidentally, there's a test engine in electric-tests.el which is 100%
undocumented (no doc string, no comments in functions like
electric-pair-test-for and electric-pair-define-test-form). It would be
appreciated if anybody reading this who understands any of these
functions could add doc strings to them.
> --8<---------------cut here---------------start------------->8---
> # make -C test electric-tests
> Ran 475 tests, 387 results as expected, 88 unexpected (2019-01-16 00:28:55+0100, 214.752138 sec)
> 1 expected failures
> 88 unexpected results:
> FAILED electric-layout-int-main-allman-style
> FAILED electric-layout-int-main-kernel-style
[ .... ]
> FAILED electric-pair-whitespace-jumping-at-point-8-in-c++-mode-in-comments
> FAILED electric-pair-whitespace-jumping-at-point-9-in-c++-mode-in-comments
[ .... ]
> Best regards, Michael.
--
Alan Mackenzie (Nuremberg, Germany).
next prev parent reply other threads:[~2019-01-16 18:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190115160812.12319.90321@vcs0.savannah.gnu.org>
[not found] ` <20190115160813.EFFD4209E3@vcs0.savannah.gnu.org>
2019-01-15 23:30 ` master 223e7b8: Make CC Mode and electric-pair-mode work together. This fixes bug #33794 Michael Albinus
2019-01-16 18:05 ` Alan Mackenzie [this message]
2019-01-17 15:47 ` João Távora
2019-01-16 19:49 ` Ted Zlatanov
2019-01-17 9:27 ` Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190116180506.GA2988@ACM \
--to=acm@muc.de \
--cc=emacs-devel@gnu.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).