From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: master 1ca436a: Make compilation mode work with warnings from compiled buffer functions Date: Thu, 29 Nov 2018 10:26:38 +0000 Message-ID: <20181129102638.GB12576@ACM> References: <20181128132417.30869.1170@vcs0.savannah.gnu.org> <20181128132418.851A9204F1@vcs0.savannah.gnu.org> <20181128201600.GA5331@ACM> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1543487359 21352 195.159.176.226 (29 Nov 2018 10:29:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 29 Nov 2018 10:29:19 +0000 (UTC) User-Agent: Mutt/1.10.1 (2018-07-13) Cc: emacs-devel@gnu.org To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 29 11:29:15 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gSJZK-0005PK-PD for ged-emacs-devel@m.gmane.org; Thu, 29 Nov 2018 11:29:14 +0100 Original-Received: from localhost ([::1]:53294 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gSJbR-0001LJ-6a for ged-emacs-devel@m.gmane.org; Thu, 29 Nov 2018 05:31:25 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52968) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gSJaY-0001JH-5T for emacs-devel@gnu.org; Thu, 29 Nov 2018 05:30:34 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gSJaU-0007Hu-51 for emacs-devel@gnu.org; Thu, 29 Nov 2018 05:30:30 -0500 Original-Received: from colin.muc.de ([193.149.48.1]:41636 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1gSJaT-00079S-KV for emacs-devel@gnu.org; Thu, 29 Nov 2018 05:30:26 -0500 Original-Received: (qmail 76941 invoked by uid 3782); 29 Nov 2018 10:30:22 -0000 Original-Received: from acm.muc.de (p2E5D5BA2.dip0.t-ipconnect.de [46.93.91.162]) by colin.muc.de (tmda-ofmipd) with ESMTP; Thu, 29 Nov 2018 11:30:21 +0100 Original-Received: (qmail 13046 invoked by uid 1000); 29 Nov 2018 10:26:38 -0000 Content-Disposition: inline In-Reply-To: X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x [fuzzy] X-Received-From: 193.149.48.1 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:231509 Archived-At: Hello, Glenn. On Wed, Nov 28, 2018 at 22:51:02 -0500, Glenn Morris wrote: > Alan Mackenzie wrote: > > The previous version of bytecomp.el used at least one function in > > compile.el (namely compilation-mode), suggesting that compile.elc? is > > already loaded when bytecomp starts. > It only uses compilation-mode in interactive use, but 1ca436a33c loads > compile unconditionally. > > However, for some fiddly reason a macro in compile.el was no longer > > defined, hence the require. > Since AFAICS you only need the define-compilation-mode macro, > eval-when-compile should solve the slowdown. Ah, I've got you now! Yes, that does indeed save a few seconds on the bootstrap time. Thanks for making the change in the repository. -- Alan Mackenzie (Nuremberg, Germany).