unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: Glenn Morris <rgm@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: master 1ca436a: Make compilation mode work with warnings from compiled buffer functions
Date: Thu, 29 Nov 2018 10:26:38 +0000	[thread overview]
Message-ID: <20181129102638.GB12576@ACM> (raw)
In-Reply-To: <k5bm68pmmx.fsf@fencepost.gnu.org>

Hello, Glenn.

On Wed, Nov 28, 2018 at 22:51:02 -0500, Glenn Morris wrote:
> Alan Mackenzie wrote:

> > The previous version of bytecomp.el used at least one function in
> > compile.el (namely compilation-mode), suggesting that compile.elc? is
> > already loaded when bytecomp starts.

> It only uses compilation-mode in interactive use, but 1ca436a33c loads
> compile unconditionally.

> > However, for some fiddly reason a macro in compile.el was no longer
> > defined, hence the require.

> Since AFAICS you only need the define-compilation-mode macro,
> eval-when-compile should solve the slowdown.

Ah, I've got you now!  Yes, that does indeed save a few seconds on the
bootstrap time.  Thanks for making the change in the repository.

-- 
Alan Mackenzie (Nuremberg, Germany).



      reply	other threads:[~2018-11-29 10:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20181128132417.30869.1170@vcs0.savannah.gnu.org>
     [not found] ` <20181128132418.851A9204F1@vcs0.savannah.gnu.org>
2018-11-28 16:37   ` master 1ca436a: Make compilation mode work with warnings from compiled buffer functions Glenn Morris
2018-11-28 20:16     ` Alan Mackenzie
2018-11-29  3:51       ` Glenn Morris
2018-11-29 10:26         ` Alan Mackenzie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181129102638.GB12576@ACM \
    --to=acm@muc.de \
    --cc=emacs-devel@gnu.org \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).