From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: scratch/accurate-warning-pos: Solid progress: the branch now bootstraps. Date: Sun, 25 Nov 2018 19:54:02 +0000 Message-ID: <20181125195402.GJ27152@ACM> References: <20181117124534.GA8831@ACM> <83muq7u9rk.fsf@gnu.org> <20181123130904.GA2916@ACM> <20181125143125.GA27152@ACM> <20181125173528.GD27152@ACM> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1543175763 25878 195.159.176.226 (25 Nov 2018 19:56:03 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 25 Nov 2018 19:56:03 +0000 (UTC) User-Agent: Mutt/1.10.1 (2018-07-13) Cc: michael_heerdegen@web.de, eliz@gnu.org, "Charles A. Roelli" , cpitclaudel@gmail.com, emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Nov 25 20:55:59 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gR0VX-0006WG-AK for ged-emacs-devel@m.gmane.org; Sun, 25 Nov 2018 20:55:55 +0100 Original-Received: from localhost ([::1]:32814 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gR0Xe-0004zP-0X for ged-emacs-devel@m.gmane.org; Sun, 25 Nov 2018 14:58:06 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47491) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gR0Wz-0004zJ-6F for emacs-devel@gnu.org; Sun, 25 Nov 2018 14:57:25 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gR0Ww-0001RQ-61 for emacs-devel@gnu.org; Sun, 25 Nov 2018 14:57:25 -0500 Original-Received: from colin.muc.de ([193.149.48.1]:10958 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1gR0Wv-0001R2-S4 for emacs-devel@gnu.org; Sun, 25 Nov 2018 14:57:22 -0500 Original-Received: (qmail 70205 invoked by uid 3782); 25 Nov 2018 19:57:21 -0000 Original-Received: from acm.muc.de (p2E5D5C08.dip0.t-ipconnect.de [46.93.92.8]) by colin.muc.de (tmda-ofmipd) with ESMTP; Sun, 25 Nov 2018 20:57:18 +0100 Original-Received: (qmail 20903 invoked by uid 1000); 25 Nov 2018 19:54:02 -0000 Content-Disposition: inline In-Reply-To: X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x [fuzzy] X-Received-From: 193.149.48.1 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:231367 Archived-At: Hello, Stefan. On Sun, Nov 25, 2018 at 13:22:38 -0500, Stefan Monnier wrote: [ .... ] > > NILP won't work here (as I pointed out to Eli), because of circular > > dependencies inside lisp.h. > Oh, right: > #define lisp_h_NILP(x) EQ (x, Qnil) > Reminds me of another question I had: in your code, do you need NILP to > pay attention to symbols-with-pos-enabled? I think so, yes. The compiler has to recognise an explicit # as being nil. I had quite some fun in the hacking with the (foo . nil)s in fontset.el. > That would significantly increase the impact in terms of code-size and > CPU time (could explain why you see 8% slowdown which is more expansive > than my patch which turns EQ into EQL). Would it? Currently, an EQ does a binary == test between the Lisp_Objects, and only if that fails does it test symbols-with-pos-enabled. So if the number of successful and failing tests were equal (I've really no idea), EQ would be slowed down by 33%. > Stefan -- Alan Mackenzie (Nuremberg, Germany).