From: Alan Mackenzie <acm@muc.de>
To: Stefan Monnier <monnier@iro.umontreal.ca>, Eli Zaretskii <eliz@gnu.org>
Cc: Michael Heerdegen <michael_heerdegen@web.de>, emacs-devel@gnu.org
Subject: Re: Thoughts on getting correct line numbers in the byte compiler's warning messages
Date: Mon, 12 Nov 2018 15:44:48 +0000 [thread overview]
Message-ID: <20181112154448.GB4459@ACM> (raw)
In-Reply-To: <20181108140843.GB5041@ACM>
Hello, Stefan and Eli.
A snag.....
On Thu, Nov 08, 2018 at 14:08:43 +0000, Alan Mackenzie wrote:
[ .... ]
> One thing we'd need to watch out for is using equal, not eq, when we
> compare symbols. (eq 'foo #<symbol foo with position 73>) will surely
> be nil, but (equal ....) would be t. Same with member and memq.
Unfortunately, this isn't going to work. There will be macros which do
things like:
(cond ((eq (car form) 'bar) ....) .....)
Here, (car form) is going to be #<symbol bar at 42>, so the eq is going
to return nil.
The only way out of this I can see at the moment is to amend eq (and
memq, assq, delq, ....) so that it recognises a symbol with position as
being eq to the bare symbol.
At least when the flag variable symbols-with-pos-enabled is currently
non-nil. At the implementation level, when that variable is nil (i.e.
for normal running), there would be a cost of one comparison of an
in-cache variable with zero on each eq operation which returns nil.
This isn't pretty. If this modification of eq, memq, .... is too much
to take, then I think the current approach is doomed to failure.
What do you think?
[ .... ]
--
Alan Mackenzie (Nuremberg, Germany).
next prev parent reply other threads:[~2018-11-12 15:44 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-01 17:59 Thoughts on getting correct line numbers in the byte compiler's warning messages Alan Mackenzie
2018-11-01 22:45 ` Stefan Monnier
2018-11-05 10:53 ` Alan Mackenzie
2018-11-05 15:57 ` Eli Zaretskii
2018-11-05 16:51 ` Alan Mackenzie
2018-11-06 4:34 ` Herring, Davis
2018-11-06 8:53 ` Alan Mackenzie
2018-11-06 13:56 ` Stefan Monnier
2018-11-06 15:11 ` Alan Mackenzie
2018-11-06 16:29 ` Stefan Monnier
2018-11-06 19:15 ` Alan Mackenzie
2018-11-06 20:04 ` Stefan Monnier
2018-11-07 12:35 ` Alan Mackenzie
2018-11-07 17:11 ` Stefan Monnier
2018-11-07 17:00 ` Alan Mackenzie
2018-11-07 17:25 ` Stefan Monnier
2018-11-07 18:47 ` Alan Mackenzie
2018-11-07 19:12 ` Stefan Monnier
2018-11-08 14:08 ` Alan Mackenzie
2018-11-08 17:02 ` Stefan Monnier
2018-11-08 22:13 ` Alan Mackenzie
2018-11-11 12:59 ` Alan Mackenzie
2018-11-11 15:53 ` Eli Zaretskii
2018-11-11 20:12 ` Alan Mackenzie
2018-11-11 20:47 ` Stefan Monnier
2018-11-12 3:30 ` Eli Zaretskii
2018-11-12 16:19 ` Eli Zaretskii
2018-11-12 14:16 ` Alan Mackenzie
2018-11-12 15:44 ` Alan Mackenzie [this message]
2018-11-12 20:36 ` Stefan Monnier
2018-11-12 21:35 ` Alan Mackenzie
2018-11-14 13:34 ` Stefan Monnier
2018-11-15 16:32 ` Alan Mackenzie
2018-11-15 18:01 ` Stefan Monnier
2018-11-16 14:14 ` Alan Mackenzie
2018-11-08 4:47 ` Michael Heerdegen
2018-11-08 11:07 ` Alan Mackenzie
2018-11-09 2:06 ` Michael Heerdegen
2018-11-10 10:59 ` Alan Mackenzie
2018-11-10 13:20 ` Stefan Monnier
2018-11-11 7:56 ` Michael Heerdegen
2018-11-08 13:45 ` Stefan Monnier
2018-11-09 3:06 ` Michael Heerdegen
2018-11-09 16:15 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181112154448.GB4459@ACM \
--to=acm@muc.de \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=michael_heerdegen@web.de \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).