From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: Replace trivial pcase occurrences in the Emacs sources Date: Wed, 31 Oct 2018 12:08:21 +0000 Message-ID: <20181031120821.GA20575@ACM> References: <83r2g8klf9.fsf@gnu.org> <83wopzk3sw.fsf@gnu.org> <83r2g7jrot.fsf@gnu.org> <83k1lzjq0r.fsf@gnu.org> <83in1jjmy4.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1540987611 30898 195.159.176.226 (31 Oct 2018 12:06:51 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 31 Oct 2018 12:06:51 +0000 (UTC) User-Agent: Mutt/1.10.1 (2018-07-13) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Oct 31 13:06:46 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gHpGj-0007qy-Hg for ged-emacs-devel@m.gmane.org; Wed, 31 Oct 2018 13:06:41 +0100 Original-Received: from localhost ([::1]:59082 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gHpIp-0008Li-Cg for ged-emacs-devel@m.gmane.org; Wed, 31 Oct 2018 08:08:51 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45229) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gHpIj-0008LY-Nx for emacs-devel@gnu.org; Wed, 31 Oct 2018 08:08:46 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gHpIg-0001e0-CF for emacs-devel@gnu.org; Wed, 31 Oct 2018 08:08:45 -0400 Original-Received: from colin.muc.de ([193.149.48.1]:13900 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1gHpIa-0001Rw-Ph for emacs-devel@gnu.org; Wed, 31 Oct 2018 08:08:38 -0400 Original-Received: (qmail 73860 invoked by uid 3782); 31 Oct 2018 12:08:25 -0000 Original-Received: from acm.muc.de (p5B147AF0.dip0.t-ipconnect.de [91.20.122.240]) by colin.muc.de (tmda-ofmipd) with ESMTP; Wed, 31 Oct 2018 13:08:24 +0100 Original-Received: (qmail 20607 invoked by uid 1000); 31 Oct 2018 12:08:21 -0000 Content-Disposition: inline In-Reply-To: X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x [fuzzy] X-Received-From: 193.149.48.1 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:230868 Archived-At: Hello, Stefan. On Tue, Oct 30, 2018 at 14:58:58 -0400, Stefan Monnier wrote: > >> matching doesn't assign any values to anything directly related to > >> BODY, so the mechanism by which it affects execution of BODY needs > >> to be described. > > Could you please fill that void? This isn't a repetition of what > > dolist does. > I don't know how to say it any better than with the patch I just > installed into emacs-26. Thank you for this patch, which is excellent. However, the doc string for pcase-dolist is still not quite perfect, in that: 1. It doesn't say what the macro does. 2. It doesn't document the arguments to the macro. 3. It appears to refer to an argument which don't exist (VAR). 4. It forces somebody new to Lisp to traverse 5 nodes of the graph of doc strings (namely pcase-dolist, pcase, dolist, pcase-let, let) and synthesise these disparate doc strings to get an idea of what the macro does. This is too many nodes, and the task is too difficult. 5. It states the macro is equivalent to an expansion of other macros, which appear no easier to understand than pcase-dolist itself. Otherwise, not bad! Are you willing to put these final touches onto pcase-dolist's doc string, or would you prefer somebody else to do it? > Stefan -- Alan Mackenzie (Nuremberg, Germany).