unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: martin rudalics <rudalics@gmx.at>
Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
Subject: Re: Documenting buffer display
Date: Tue, 23 Oct 2018 15:52:31 +0000	[thread overview]
Message-ID: <20181023155231.GB7594@ACM> (raw)
In-Reply-To: <5BCEE2B5.9090205@gmx.at>

Hello, Martin.

On Tue, Oct 23, 2018 at 10:58:29 +0200, martin rudalics wrote:

[ .... ]

> Then why do we have all this dispute about 'display-buffer'?
> According to the majority of people because its documentation is
> confusing, wrong, incomplete, implicit, arcane or just bad.

I was one of the people recently criticising these things.  I think I
went over the top in what I said, so apologies for that.  The
documentation is difficult because the function does so much.  Yet
display-buffer is a coherent do-one-thing-and-do-it-well function, and I
think any replacement for it would not be as good.

All the same, there are some concrete things in display-buffer's doc
string I would like to comment on.

(i) PLEASE do not delete the extensive description of the ACTION
argument.  Without it, the function would be more difficult to
understand, even if the doc string were shorter.

(ii) The optional argument FRAME gets combined with other ALIST entries.
But where?  Is it considered before or after the other entries?

(iii) "If ACTION is non-nil .... where FUNCTION is either a function or
a list of functions ....".  Would it not be better to call this element
"FUNCTIONS" (plural)?

(iv) "If ACTION is non-nil .... ALIST is an arbitrary association
list...".  This is unfinished.  Could it not say, for example, "... an
arbitrary association list which FOO uses to BAR BAZ (see below)"?

(v) "Based on those arguments, it should display the buffer and return
the window.".  Possibly better would be "it should TRY TO display the
buffer and return the window.".  Maybe.

(vi) (Same paragraph): isn't there a missing "...otherwise the function
will throw an error" after the bit about (allow-no-window . t)?

(vii) `reusable frames': it sort of seems that a list of frames could be
given as the cdr of this entry.  That is not the case.  Maybe the text
could become: "value, AN ATOM, specifies frame(s) to search...".  This
will remove that uncertainty over the possibility of a list of frames,
forcing the reader to follow the hyperlink to get details.

(viii) `allow-no-window' is a little unclear on what happens when a
function fails to display and return a window.  The text implies that
the window remains undisplayed, whereas I think that instead the next
function is tried, and so on, until one returns a window.

> martin

-- 
Alan Mackenzie (Nuremberg, Germany).



  parent reply	other threads:[~2018-10-23 15:52 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-20 12:20 Documenting buffer display martin rudalics
2018-10-20 13:21 ` Eli Zaretskii
2018-10-20 18:02   ` martin rudalics
2018-10-21 12:56     ` Eli Zaretskii
2018-10-22  9:06       ` martin rudalics
2018-10-22 13:55         ` Eli Zaretskii
2018-10-22 19:14           ` martin rudalics
2018-10-22 19:27             ` Eli Zaretskii
2018-10-23  8:58               ` martin rudalics
2018-10-23 11:26                 ` Pierre-Yves Luyten
2018-10-23 13:45                   ` martin rudalics
2018-10-23 17:40                   ` Stefan Monnier
2018-10-23 14:04                 ` Drew Adams
2018-10-23 18:18                   ` martin rudalics
2018-10-23 15:18                 ` Eli Zaretskii
2018-10-23 18:23                   ` martin rudalics
2018-10-23 19:07                     ` Eli Zaretskii
2018-10-24  9:44                       ` martin rudalics
2018-10-24 14:48                         ` Eli Zaretskii
2018-10-24 17:40                           ` martin rudalics
2018-10-24 18:25                             ` Eli Zaretskii
2018-10-25 20:42                             ` Juri Linkov
2018-10-23 15:52                 ` Alan Mackenzie [this message]
2018-10-23 18:25                   ` martin rudalics
2018-11-08 19:25                   ` martin rudalics
2018-10-22  1:39   ` Michael Welsh Duggan
2018-10-22  5:54     ` Eli Zaretskii
2018-10-20 15:22 ` Drew Adams
2018-10-20 18:02   ` martin rudalics
2018-10-20 18:24     ` Drew Adams
2018-10-21  8:22       ` martin rudalics
2018-11-04  9:06 ` martin rudalics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181023155231.GB7594@ACM \
    --to=acm@muc.de \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).