From: Alan Mackenzie <acm@muc.de>
To: emacs-devel@gnu.org
Cc: Gemini Lasswell <gazally@runbox.com>
Subject: When calling defuns is a Bad Thing.
Date: Sun, 21 Oct 2018 16:41:10 +0000 [thread overview]
Message-ID: <20181021164110.GA4664@ACM> (raw)
Hello, Emacs.
Calling defuns (as opposed to primitives) from edebug is a bad idea,
unless those defuns are also defined in edebug.el.
The reason is that edebug.el exists to debug these defuns, and if the
edebug engine uses a defun which happens to be instrumented, Emacs will
(probably) lock up.
For the same reason, edebug should probably avoid using "complicated"
macros, such as the pcase family and cl-... because it is difficult to be
sure that their expansions will not introduce non-primitives into the
code.
Currently, edebug calls (at least) one-window-p and walk-windows, which
it shouldn't. Possibly, it should define edebug- versions of them.
There are also quite a few uses of cl-... which is somewhat worrying.
At the very least, edebug should NOT replace its own edebug-pop-to-buffer
with pop-to-buffer, as has been suggested in a comment.
Comments?
--
Alan Mackenzie (Nuremberg, Germany).
next reply other threads:[~2018-10-21 16:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-21 16:41 Alan Mackenzie [this message]
2018-10-21 18:07 ` When calling defuns is a Bad Thing Stefan Monnier
2018-10-22 14:06 ` Alan Mackenzie
2018-10-22 15:25 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181021164110.GA4664@ACM \
--to=acm@muc.de \
--cc=emacs-devel@gnu.org \
--cc=gazally@runbox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).