From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Third Newsgroups: gmane.emacs.devel Subject: Re: Change to NS drawing routines Date: Wed, 15 Aug 2018 21:42:27 +0100 Message-ID: <20180815204227.GA20551@breton.holly.idiocy.org> References: <20180811140620.GA1519@breton.holly.idiocy.org> <20180813184659.GA2258@breton.holly.idiocy.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1534365641 28970 195.159.176.226 (15 Aug 2018 20:40:41 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 15 Aug 2018 20:40:41 +0000 (UTC) User-Agent: Mutt/1.10.0 (2018-05-17) Cc: emacs-devel@gnu.org To: "Charles A. Roelli" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Aug 15 22:40:37 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fq2ar-0007TF-22 for ged-emacs-devel@m.gmane.org; Wed, 15 Aug 2018 22:40:37 +0200 Original-Received: from localhost ([::1]:52047 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fq2cx-0000TP-N2 for ged-emacs-devel@m.gmane.org; Wed, 15 Aug 2018 16:42:47 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40081) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fq2cq-0000T0-Fy for emacs-devel@gnu.org; Wed, 15 Aug 2018 16:42:41 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fq2cm-0008Ig-98 for emacs-devel@gnu.org; Wed, 15 Aug 2018 16:42:38 -0400 Original-Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]:44717) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fq2ci-0008Es-MM for emacs-devel@gnu.org; Wed, 15 Aug 2018 16:42:34 -0400 Original-Received: by mail-wr1-x436.google.com with SMTP id r16-v6so2179981wrt.11 for ; Wed, 15 Aug 2018 13:42:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=6Z3yerS/Xd99bsyVPteeJRVoHxdQ1FdsUhmlKnRc+Zw=; b=dp/UH626zzsGgSVFvYJDx3GaZePpno2wwzyMq+Ys5S2+bvIQkh8tYk8+vGwdGI6yoo GhjjRlfay8A/Mp8dQUCENycmjhTuj10eB6os0c+9mXx1hSHNO9xW1H3oxxMkENghaxlZ vaM6NycgxcQ59j1bKgubgfod1M6yYymyf9Hv5KMdmSxRXwbjx4LwY6r0A+NGeDgEVmEH 7cAH+valkLE4eYjIvyW5JfL8Im96xKp28iKKk0QRvw1LJb2t3EonnrDL3+ijjdt53Qd/ uxRpaAtxpYWJ0eQmRVe2BMJmXaSj8ZwW4re5idIYZ1eXVLNlm+9xcOUgQUVhFUxumlYo bZig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=6Z3yerS/Xd99bsyVPteeJRVoHxdQ1FdsUhmlKnRc+Zw=; b=m8r/zgHi2gPY4IgGcj7IUvWHmTuUuyJoI1xlNB+l/hgEOFbXmUA8c6UZEInHHyNp0b JNsGl8xMmyqJSo1zSAXOXpbd0cGazzCf6iXEB7DqsNMVQgEYkDWNXXYHU5EPyBlUfci2 S4dhdjZv5KH0h/X0sRAscHjLn0r8jeUgpVXMCQAc+v852L+0FvcDuA2Oy/AbdB70PK0B eMHwC+KcDlTUWUEqQN3BmqqLfh09ORUN2G0006ZasGjt1dH6nCAJUOdieWHpDvoq+9kf MI+6O4O8hn22nwxo/i1iL5TybqSEJ9rJC31H4Jj9gf5HwMjWYAeNQHOutHps6itUifuL oAGw== X-Gm-Message-State: AOUpUlFj69NmQB6fdadyI9KRh5+0kO2rcFpVUhbBdPtacNm46V1kizy2 sPDjJ5Il3Zx6Tp9oAq2UlbsqjevqlVo= X-Google-Smtp-Source: AA+uWPxxJX3DWA54ZRcctnWiSOw5D0ufkltUX3hD5qpeRHXmGCsHGbZ1bZmRF/PaBxzc/5GFv9Zoqg== X-Received: by 2002:adf:f507:: with SMTP id q7-v6mr17834464wro.241.1534365750671; Wed, 15 Aug 2018 13:42:30 -0700 (PDT) Original-Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-c55b-5835-b4f8-8d72.holly.idiocy.org. [2001:8b0:3f8:8129:c55b:5835:b4f8:8d72]) by smtp.gmail.com with ESMTPSA id 188-v6sm4831181wmr.16.2018.08.15.13.42.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 15 Aug 2018 13:42:29 -0700 (PDT) Content-Disposition: inline In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::436 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:228571 Archived-At: On Wed, Aug 15, 2018 at 09:20:17PM +0200, Charles A. Roelli wrote: > > By the way, I noticed that one of the problems YAMAMOTO Mitsuharu > discovered with the current way of drawing is fixed in your branch: > > > Link: https://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00440.html > > > > (Another problem with drawing outside the "expose" handler can be > > observed with the NS port on Mac OS X 10.6 and earlier: the resize > > handle at the right bottom corner gets overwritten.) > > It's a small detail, but neat nevertheless. Ah, nice. My version of macOS doesn’t display that handle, so I was unaware. Although now I look the rounded corners at the bottom no longer disappear when the frame is resized. Cool. :) > I tried M-x benchmark RET (redisplay) RET in master and in > scratch/ns-drawing, with scratch/ns-drawing often being faster in the > middle of big files like xdisp.c. But I don't remember if I messed > with compiler options recently, so it would be good if somebody else > could check. I see a slight improvement too, but it’s really too small to measure. Expanding on your test above I tried this with benchmark from the top of xdisp.c: (dotimes (n 100) (scroll-up) (redisplay)) But now I try it again the improvement I saw has disappeared. If there is a change in performance it appears to be too small to reliably measure. Which is, if not good, at least not bad. :) I’ve just realised this has reintroduced an annoying flicker on resize (bug#30699) if you run something like: (dotimes (n 10) (sit-for 0.3) (set-frame-width nil (+ n 80))) -- Alan Third