Xwidget webkit support for macOS X Cocoa

Xwidget webkit support for macOS X Cocoa

[Jaesup Kwak]

[-- Attachment #1: Type: text/plain, Size: 324 bytes --]

Hi all!

I made a work supporting Emacs xwidget webkit for macOS X, which works with
Cocoa and Safari webkit frameworks without need of GTK and X window. You
can t ry it on master branch of  https://github.com/veshboo/emacs

I want to contribute the work to GNU Emacs and hope someone help me how to
contribute.

Thank you.

[-- Attachment #2: Type: text/html, Size: 437 bytes --]

Re: Xwidget webkit support for macOS X Cocoa

[Paul Eggert]

On 11/27/2017 11:13 PM, Jaesup Kwak wrote:
> I made a work supporting Emacs xwidget webkit for macOS X, which works 
> with Cocoa and Safari webkit frameworks without need of GTK and X 
> window. You can t ry it on master branch of 
> https://github.com/veshboo/emacs

Thanks, could you please briefly characterize how this relates to what's 
already in GNU Emacs, and to the Emacs Mac Port 
<https://bitbucket.org/mituharu/emacs-mac/>? (Sorry, I don't know macOS 
well.)

Also, can willing to sign papers contributing your changes to the Free 
Software Foundation? If so, please let me know and I can send you info 
about how to do that.

Re: Xwidget webkit support for macOS X Cocoa

[Jaesup Kwak]

[-- Attachment #1: Type: text/plain, Size: 783 bytes --]

Sure, I can do that.

2017. 11. 29. 오전 12:59에 "Paul Eggert" <eggert@cs.ucla.edu>님이 작성:

> On 11/27/2017 11:13 PM, Jaesup Kwak wrote:
>
>> I made a work supporting Emacs xwidget webkit for macOS X, which works
>> with Cocoa and Safari webkit frameworks without need of GTK and X window.
>> You can t ry it on master branch of https://github.com/veshboo/emacs
>>
>
> Thanks, could you please briefly characterize how this relates to what's
> already in GNU Emacs, and to the Emacs Mac Port <
> https://bitbucket.org/mituharu/emacs-mac/>? (Sorry, I don't know macOS
> well.)
>
> Also, can willing to sign papers contributing your changes to the Free
> Software Foundation? If so, please let me know and I can send you info
> about how to do that.
>
>

[-- Attachment #2: Type: text/html, Size: 1355 bytes --]

Re: Xwidget webkit support for macOS X Cocoa

[Jaesup Kwak]

[-- Attachment #1: Type: text/plain, Size: 2017 bytes --]

On Wed, Nov 29, 2017 at 12:59 AM, Paul Eggert <eggert@cs.ucla.edu> wrote:

> On 11/27/2017 11:13 PM, Jaesup Kwak wrote:
>
>> I made a work supporting Emacs xwidget webkit for macOS X, which works
>> with Cocoa and Safari webkit frameworks without need of GTK and X window.
>> You can t ry it on master branch of https://github.com/veshboo/emacs
>>
>
> Thanks, could you please briefly characterize how this relates to what's
> already in GNU Emacs, and to the Emacs Mac Port <
> https://bitbucket.org/mituharu/emacs-mac/>? (Sorry, I don't know macOS
> well.)
>

This work provides NSView (Cocoa AppKit) and WKWebView (Safari WebKit)
based backend for the Emacs xwidget webkit feature (--with-xwidgets).

The current GNU Emacs xwidget webkit feature requires X window, GTK,
and WebKitGTK even on macOS, it runs OK but not gets along with
macOS's GUI environment.

With my work, it requires only AppKit and WebKit (these are available
on macOS X without manual installation) and the resulting graphical
web browsing in Emacs buffer shows better look in the macOS GUI
environment.

Most changes are made in the following files (about 30 commits):

* configure.ac src/Makefile.in: Enable xwidgets also if NS (macOS) and
  WebKit available

* src/xwidget.[ch]: For USE_GTK or HAVE_NS, conditional compile of
  non-Lisp_Object part of pseudo vector structure and operations on it

* src/nsxwidget.[mh]: Newly added files, provide NS backend for
  xwidget and webkit

* lisp/xwidget.el: Some fixes and enhancements while development and
  testing of ns xwidget webkit support

And this work has no relation to the Emacs Mac Port. I cloned from
'git.sv.gnu.org/emacs.git' and made this work. And I also see no support
for NS Cocoa and Safari WebKit based xwidget webkit in the Emacs Mac
Port.


> Also, can willing to sign papers contributing your changes to the Free
> Software Foundation? If so, please let me know and I can send you info
> about how to do that.
>
>
Sure, I can do that, send me the info, please.

Thanks,

[-- Attachment #2: Type: text/html, Size: 3408 bytes --]

Re: Xwidget webkit support for macOS X Cocoa

[John Wiegley]

>>>>> "JK" == Jaesup Kwak <veshboo@gmail.com> writes:

JK>     Also, can willing to sign papers contributing your changes to the Free
JK>     Software Foundation? If so, please let me know and I can send you info
JK>     about how to do that.

JK> Sure, I can do that, send me the info, please.

Please send an inquiry to assign@gnu.org, and they will send you the necessary
papers.

This looks like exciting work, and I look forward to trying it out!

-- 
John Wiegley                  GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com                          60E1 46C4 BD1A 7AC1 4BA2

Re: Xwidget webkit support for macOS X Cocoa

[Charles A. Roelli]

> From: Jaesup Kwak <veshboo@gmail.com>
> Date: Tue, 28 Nov 2017 16:13:45 +0900
> 
> Hi all! 
> 
> I made a work supporting Emacs xwidget webkit for macOS X, which works with Cocoa and Safari webkit frameworks without need of
> GTK and X window. You can t ry it on master branch of https://github.com/veshboo/emacs 
> 
> I want to contribute the work to GNU Emacs and hope someone help me how to contribute. 
> 
> Thank you.

Thanks a lot for implementing xwidget on macOS.  Could you please
rebase your branch against the latest master, and post a patch to
bug-gnu-emacs@gnu.org?  The ChangeLog will also have to be in the
format as specified here:

https://www.gnu.org/prep/standards/html_node/Change-Logs.html

(It's best to use `C-x 4 a' and then the standard VC bindings to make
commits, so that the right style is used.  The ChangeLog messages will
be automatically copied into the commit message when you commit files
with `C-x v v'.)

Generally Emacs tries to keep support for macOS 10.6 and above, even
for new development.  I saw that you used the WKWebView as a parent
class for the XwWebView, which was made available in version 10.10.  I
made some small changes locally to adapt your branch to build with the
older "WebView" class, and it works on 10.6 (but it is missing some of
the bells and whistles).  I will work on it some more this week, and
we can hopefully include it along with your xwidget implementation.

Thanks again.

Re: Xwidget webkit support for macOS X Cocoa

[Jaesup Kwak]

[-- Attachment #1: Type: text/plain, Size: 1895 bytes --]

I rebased my changes so far against the latest master and posted a
patch to bug-gnu-emacs@gnu.org with the Subject of
"[PATCH] Support xwidget webkit for macOS X".

I made some effort to write good commit log after reading the
ChangeLog guide.

Thanks for your advice and work about the macOS support policy.


On Sun, Dec 3, 2017 at 8:32 PM, Charles A. Roelli <charles@aurox.ch> wrote:

> > From: Jaesup Kwak <veshboo@gmail.com>
> > Date: Tue, 28 Nov 2017 16:13:45 +0900
> >
> > Hi all!
> >
> > I made a work supporting Emacs xwidget webkit for macOS X, which works
> with Cocoa and Safari webkit frameworks without need of
> > GTK and X window. You can t ry it on master branch of
> https://github.com/veshboo/emacs
> >
> > I want to contribute the work to GNU Emacs and hope someone help me how
> to contribute.
> >
> > Thank you.
>
> Thanks a lot for implementing xwidget on macOS.  Could you please
> rebase your branch against the latest master, and post a patch to
> bug-gnu-emacs@gnu.org?  The ChangeLog will also have to be in the
> format as specified here:
>
> https://www.gnu.org/prep/standards/html_node/Change-Logs.html
>
> (It's best to use `C-x 4 a' and then the standard VC bindings to make
> commits, so that the right style is used.  The ChangeLog messages will
> be automatically copied into the commit message when you commit files
> with `C-x v v'.)
>
> Generally Emacs tries to keep support for macOS 10.6 and above, even
> for new development.  I saw that you used the WKWebView as a parent
> class for the XwWebView, which was made available in version 10.10.  I
> made some small changes locally to adapt your branch to build with the
> older "WebView" class, and it works on 10.6 (but it is missing some of
> the bells and whistles).  I will work on it some more this week, and
> we can hopefully include it along with your xwidget implementation.
>
> Thanks again.
>

[-- Attachment #2: Type: text/html, Size: 2824 bytes --]

Re: Xwidget webkit support for macOS X Cocoa

[Perry E. Metzger]

On Tue, 28 Nov 2017 16:13:45 +0900 Jaesup Kwak <veshboo@gmail.com>
wrote:
> Hi all!
> 
> I made a work supporting Emacs xwidget webkit for macOS X, which
> works with Cocoa and Safari webkit frameworks without need of GTK
> and X window. You can t ry it on master branch of
> https://github.com/veshboo/emacs
> 
> I want to contribute the work to GNU Emacs and hope someone help me
> how to contribute.
> 
> Thank you.

I was curious about what has happened to this effort to mainline these
patches. There are people currently maintaining their own patch sets
for the thing to get the functionality, which seems like a waste.

Perry
-- 
Perry E. Metzger		perry@piermont.com

Re: Xwidget webkit support for macOS X Cocoa

[Alan Third]

On Tue, Jun 19, 2018 at 09:43:11AM -0400, Perry E. Metzger wrote:
> On Tue, 28 Nov 2017 16:13:45 +0900 Jaesup Kwak <veshboo@gmail.com>
> wrote:
> > Hi all!
> > 
> > I made a work supporting Emacs xwidget webkit for macOS X, which
> > works with Cocoa and Safari webkit frameworks without need of GTK
> > and X window. You can t ry it on master branch of
> > https://github.com/veshboo/emacs
> > 
> > I want to contribute the work to GNU Emacs and hope someone help me
> > how to contribute.
> > 
> > Thank you.
> 
> I was curious about what has happened to this effort to mainline these
> patches. There are people currently maintaining their own patch sets
> for the thing to get the functionality, which seems like a waste.

The last time I spoke to Jaesup Kwak about this he was waiting to get
some free time to work on it some more.
-- 
Alan Third