Re: [PATCH] Flymake support for C/C++

[Alan Mackenzie <acm@muc.de>]

Hello, João.

On Sun, Jun 03, 2018 at 17:28:20 +0100, João Távora wrote:
> Hello Alan,

> Alan Mackenzie <acm@muc.de> writes:

> > OK.  But a little way down there's a
> >     (setq-local flymake-proc-allowed-file-name-masks nil)
> > , which will create a buffer-local free variable if the variable doesn't
> > already exist.  This is somewhat untidy.  Not so important, either.

> Very much so. I will remove this line, it's not needed.

Thanks

> > How about putting all these details in an alist in flymake-mode.el,
> > the key being the major-mode

> That's something that flymake-mode.el had *before* the Emacs 26.1
> redesign.  It's a natural approach when a package lives outside Emacs,
> but obviously, suffers from the big drawback that flymake-mode.el itself
> must be changed everytime a major-mode is added to Emacs, or to GNU
> ELPA, or anywhere in the emacs ecosphere.

I suppose so.

> >>   (add-hook 'flymake-diagnostic-functions 'flymake-cc nil t)

> > As I suggested above, why not simply build that information into
> > flymake.el at build (or customisation) time without troubling CC Mode at
> > all?

> No, for the reasons detailed above. As it stands, I propose to add that
> single to cc-mode.el.

Oh, OK.  I suppose we've spent enough time arguing it out.  So feel free
to add that line to the c-mode code.  You'll probably want to add a
similar line to c++-mode, and possibly to the other modes, too, maybe
some time in the future.  I'll copy it into the standalone CC Mode, too,
sometime.

> As argued already:

> 1. it is much shorter than, say cc-mode's configuration of imenu, or
> font-lock

Well, font-lock is an essential part of CC Mode, but I take the point
about imenu.

> 2. in contrast to those two, because it uses add-hook, it will never
> break or error even if flymake-mode.el is removed, reworked, etc..

OK.

> > c-initialization-hook is run exactly once, when CC Mode itself is
> > loaded.  Maybe this could be useful here.

> Unfortunately, it doesn't meet criteria (b), so I can't use it.

Fine.  I think we're agreed.  Yes?

Have a good evening!

> João

-- 
Alan Mackenzie (Nuremberg, Germany).