From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Amit Ramon Newsgroups: gmane.emacs.devel Subject: Re: Issues with quail.el Date: Thu, 17 May 2018 21:57:36 +0300 Message-ID: <20180517185736.wp2waby4fb27og2y@isis.luna> References: <87fu2qpipm.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed X-Trace: blaine.gmane.org 1526583381 10800 195.159.176.226 (17 May 2018 18:56:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 17 May 2018 18:56:21 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu May 17 20:56:17 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fJO4W-0002ey-O4 for ged-emacs-devel@m.gmane.org; Thu, 17 May 2018 20:56:17 +0200 Original-Received: from localhost ([::1]:38809 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fJO6c-0002bX-2s for ged-emacs-devel@m.gmane.org; Thu, 17 May 2018 14:58:26 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38383) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fJO62-0002bO-5t for emacs-devel@gnu.org; Thu, 17 May 2018 14:57:50 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fJO5z-0003mH-5W for emacs-devel@gnu.org; Thu, 17 May 2018 14:57:50 -0400 Original-Received: from mx1.riseup.net ([198.252.153.129]:41370) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fJO5y-0003lO-T9 for emacs-devel@gnu.org; Thu, 17 May 2018 14:57:47 -0400 Original-Received: from piha.riseup.net (piha-pn.riseup.net [10.0.1.163]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.riseup.net", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.riseup.net (Postfix) with ESMTPS id BD9FD1A0656 for ; Thu, 17 May 2018 11:57:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1526583465; bh=PjXBOpOE8nW4aWy2mEawwT0BdaFh8ZsjIkh/xcMmF1w=; h=Date:From:To:Subject:References:In-Reply-To:From; b=TtmUgkbbJ3BC7LUWQANgZlkGYCyolrEa4s7jgqG+nNal9Qm+zPk6ba9s7I2fCyy9l 9tuglpVYyBCkcE7tWJmHMbZwCYcLe+371FlDYjEVCnfxGfqQFxkmdV967PpWw/INAX bpV+Otg8NqHofUUoG+O4R2d19Z03JCiNsJpW7Hco= X-Riseup-User-ID: 741028FB40C4F38DA9AC104EDB1E9444C7BC071D9867B809FA707662A40B53CA Original-Received: from [127.0.0.1] (localhost [127.0.0.1]) by piha.riseup.net with ESMTPSA id DEC262755A for ; Thu, 17 May 2018 11:57:44 -0700 (PDT) Mail-Followup-To: emacs-devel@gnu.org Content-Disposition: inline In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 198.252.153.129 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:225373 Archived-At: Filipp Gunbin [2018-05-17 18:44 +0300]: >On 17/05/2018 21:31 +0900, K. Handa wrote: > >> Here's the patch to fix it. Could you please try it? >... >> + ;; This location not available in the current keyboard >> + ;; layout. Check if the location is used to substitute >> + ;; for the other location of the standard layout. >> + (if (setq i (cdr (rassq i quail-keyboard-layout-substitution))) >> + (aref quail-keyboard-layout i) > >Cannot understand this part - it seems to look up alist element by cdr >(i), and then set i to the same value. Should there be `(car (rassq..' >instead? I agree with Filipp -- I also think it should be set to '(car (rassq ...'. (this is a 'reverse' translation -- the code in the existing translation sets i to '(cdr (assq ...', here it should be the 'mirrored image' of it.) --- Amit