Re: ns-popup-color-panel

[Alan Third <alan@idiocy.org>]

[-- Attachment #1: Type: text/plain, Size: 402 bytes --]

On Sat, Apr 21, 2018 at 02:11:08PM +0100, Alan Third wrote:
> 
> I was going to submit a documentation fix for Emacs 26, but I’ve just
> noticed the macos.texi file is full of nonsense. There must have been
> some big changes to drag and drop functionality (at least) since this
> was written.
> 
> I’ll try and sort it out.

Patch attached. Is this OK to go straight into emacs-26?
-- 
Alan Third

[-- Attachment #2: 0001-Fix-macOS-drag-n-drop-event-documentation.patch --]
[-- Type: text/plain, Size: 3481 bytes --]

From 88d178ce9411c2c50498ef131e4a3f374a0618fc Mon Sep 17 00:00:00 2001
From: Alan Third <alan@idiocy.org>
Date: Sat, 21 Apr 2018 14:32:50 +0100
Subject: [PATCH] Fix macOS drag n drop event documentation

* doc/emacs/macos.texi (Mac / GNUstep Customization): Remove
references to color panel.
(Mac / GNUstep Events): Remove ns-drag-file, and add ns-drag-n-drop.
---
 doc/emacs/macos.texi | 41 +++++++++--------------------------------
 1 file changed, 9 insertions(+), 32 deletions(-)

diff --git a/doc/emacs/macos.texi b/doc/emacs/macos.texi
index ef2e944890..6a713271ab 100644
--- a/doc/emacs/macos.texi
+++ b/doc/emacs/macos.texi
@@ -107,30 +107,16 @@ Mac / GNUstep Customization
 keys and the fullscreen behavior.  To see all such options, use
 @kbd{M-x customize-group @key{RET} ns @key{RET}}.
 
-@subsection Font and Color Panels
+@subsection Font Panel
 
 @findex ns-popup-font-panel
-The standard Mac / GNUstep font and color panels are accessible via
-Lisp commands.  The Font Panel may be accessed with @kbd{M-x
-ns-popup-font-panel}.  It will set the default font in the frame most
+The standard Mac / GNUstep font panel is accessible with @kbd{M-x
+ns-popup-font-panel} and will set the default font in the frame most
 recently used or clicked on.
 
 @c  To make the setting permanent, use @samp{Save Options} in the
 @c Options menu, or run @code{menu-bar-options-save}.
 
-@findex ns-popup-color-panel
-You can bring up a color panel with @kbd{M-x ns-popup-color-panel} and
-drag the color you want over the Emacs face you want to change.  Normal
-dragging will alter the foreground color.  Shift dragging will alter the
-background color.  To discard the settings, create a new frame and
-close the altered one.
-
-@c To make the changes permanent select the "Save Options"
-@c item in the "Options" menu, or run @code{menu-bar-options-save}.
-
-Useful in this context is the listing of all faces obtained by
-@kbd{M-x list-faces-display}.
-
 @cindex Core Text, on macOS
 @cindex font backend, on macOS
 In macOS, Emacs uses a Core Text based font backend
@@ -180,21 +166,12 @@ Mac / GNUstep Events
 the file.  Emacs handles this by visiting that file and highlighting
 the requested line (@code{ns-open-file-select-line}).
 
-@item ns-drag-file
-This event occurs when a user drags files from another application
-into an Emacs frame.  The default behavior is to insert the contents
-of all the dragged files into the current buffer
-(@code{ns-insert-files}).  The list of dragged files is stored in the
-variable @code{ns-input-file}.
-
-@item ns-drag-color
-This event occurs when a user drags a color from the color well (or
-some other source) into an Emacs frame.  The default behavior is to
-alter the foreground color of the area the color was dragged onto
-(@code{ns-set-foreground-at-mouse}).  If this event is issued with a
-@key{Shift} modifier, Emacs changes the background color instead
-(@code{ns-set-background-at-mouse}).  The name of the dragged color is
-stored in the variable @code{ns-input-color}.
+@item ns-drag-n-drop
+This event occurs when a user drags an object from another application
+into an Emacs frame.  The default behavior is to open a file in the
+current window, or to insert text in the buffer it is dropped into.
+It may sometimes be necessary to use the @key{META} key in conjunction
+with dragging to force text insertion.
 
 @item ns-change-font
 This event occurs when the user selects a font in a Nextstep font
-- 
2.16.1