From: Alan Third <alan@idiocy.org>
To: David Reitter <david.reitter@gmail.com>
Cc: Matthew Bauer <mjbauer95@gmail.com>, emacs-devel@gnu.org
Subject: Re: bug#26323: 25.1; Closing frames (in fullscreen) under Mac OS cause immediate crash
Date: Sun, 18 Mar 2018 11:30:04 +0000 [thread overview]
Message-ID: <20180318113004.GB917@breton.holly.idiocy.org> (raw)
In-Reply-To: <CA7F5DA0-899C-4CAF-B951-ED6F4164F9F8@gmail.com>
On Sun, Mar 18, 2018 at 07:17:34AM -0400, David Reitter wrote:
> On Mar 18, 2018, at 7:15 AM, Alan Third <alan@idiocy.org> wrote:
>
> >> It reproduced in a mid-2016 build, and in a current build (based on the 25 branch).
> >
> > It was fixed after that. I can’t reproduce it in Emacs 26.
>
> Is this going to be backported to 25?
No, I’m pretty sure it isn’t.
> > I want to know how Matthew got his copy of Emacs as the code to turn
> > off Sierra tab support is only included when built on Sierra+ or when
> > using the right build options.
>
> That suggests the “fix” is to turn off tab support - is that right?
I’m not sure, to be honest, but Matthew said he could only reproduce
the problem with tab support on.
I have tab support on in the OS and can’t reproduce it.
The relevant code is:
/* macOS Sierra automatically enables tabbed windows. We can't
allow this to be enabled until it's available on a Free system.
Currently it only happens by accident and is buggy anyway. */
#if defined (NS_IMPL_COCOA) \
&& MAC_OS_X_VERSION_MAX_ALLOWED >= 101200
#if MAC_OS_X_VERSION_MIN_REQUIRED < 101200
if ([win respondsToSelector: @selector(setTabbingMode:)])
#endif
[win setTabbingMode: NSWindowTabbingModeDisallowed];
#endif
at the bottom of initFrameFromEmacs in nsterm.m.
It’s possible we need to include similar code for fullscreen (I can’t
remember if the fullscreen code uses initFrameFromEmacs), but it seems
OK here.
--
Alan Third
next prev parent reply other threads:[~2018-03-18 11:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-16 0:54 bug#26323: 25.1; Closing frames (in fullscreen) under Mac OS cause immediate crash Matthew Bauer
2018-03-16 10:47 ` Alan Third
2018-03-16 18:12 ` David Reitter
2018-03-18 11:15 ` Alan Third
2018-03-18 11:17 ` David Reitter
2018-03-18 11:30 ` Alan Third [this message]
2018-03-18 18:14 ` John Wiegley
2018-03-18 20:14 ` Alan Third
2018-03-19 0:37 ` Nick Helm
2018-03-19 12:29 ` Alan Third
2018-03-19 2:05 ` Matthew Bauer
2018-03-19 12:23 ` Alan Third
2018-03-20 1:05 ` John Wiegley
-- strict thread matches above, loose matches on Subject: below --
2018-07-10 20:52 Noah Sussman
2018-07-12 20:51 ` Alan Third
2018-07-13 2:16 ` Radon Rosborough
2018-07-13 20:25 ` Noah Sussman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180318113004.GB917@breton.holly.idiocy.org \
--to=alan@idiocy.org \
--cc=david.reitter@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=mjbauer95@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).