Re: Let's make C-M-w in isearch yank symbol, not delete character

[Alan Mackenzie <acm@muc.de>]

Hello, Juri.

On Sun, Mar 11, 2018 at 23:52:58 +0200, Juri Linkov wrote:
> > Why only set those properties in the :setter rather tan just do it at
> > top-level?  Also, would it be possible to avoid having to list those
> > commands and instead treat as `isearch-move` any command which uses the
> > handle-shift-selection?

> Supporting only commands which use the handle-shift-selection
> makes the most sense.  I tested this to confirm it works as expected:

> diff --git a/lisp/isearch.el b/lisp/isearch.el
> index 84b121a..245bf8a 100644
> --- a/lisp/isearch.el
> +++ b/lisp/isearch.el
> @@ -2433,8 +2448,8 @@ isearch-pre-command-hook
>        (setq this-command 'isearch-edit-string))
>       ;; Don't terminate the search for motion commands.
>       ((or (and (eq search-exit-option 'move)
> -               (symbolp this-command)
> -               (eq (get this-command 'isearch-move) t))
> +               (stringp (nth 1 (interactive-form this-command)))
> +               (string-match-p "^^" (nth 1 (interactive-form this-command))))
>            (and (eq search-exit-option 'shift-move)
>                 this-command-keys-shift-translated))
>        (setq this-command-keys-shift-translated nil)

Please don't do this.  handle-shift-selection (whatever that might be)
is a different feature from the isearch extension, and users should be
able to customize them independently from each other.  Correction: MUST
be able to customize them independently.

Although I haven't been following this thread all that closely, I'm a
little perturbed that in the space of little over a week, a small
definite proposal which makes a lot of sense has swollen into a
significant redesign of isearch, and an incompatible one at that.

Disclosure: I've had an isearch-yank-symbol bound to C-S-w in my
isearch-mode-map for several years.

-- 
Alan Mackenzie (Nuremberg, Germany).