From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Third Newsgroups: gmane.emacs.devel Subject: Re: Preview: portable dumper Date: Thu, 15 Feb 2018 22:46:53 +0000 Message-ID: <20180215224653.GA36004@breton.holly.idiocy.org> References: <20180215193047.GA5448@breton.holly.idiocy.org> <62b22b44-2c40-4cca-a25a-d588353cd1fa@email.android.com> <20180215203525.GA12965@breton.holly.idiocy.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1518734953 25679 195.159.176.226 (15 Feb 2018 22:49:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 15 Feb 2018 22:49:13 +0000 (UTC) User-Agent: Mutt/1.9.3 (2018-01-21) Cc: Eli Zaretskii , Angelo Graziosi , emacs-devel@gnu.org To: Daniel Colascione Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Feb 15 23:49:08 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1emSKp-0005nK-Qs for ged-emacs-devel@m.gmane.org; Thu, 15 Feb 2018 23:48:59 +0100 Original-Received: from localhost ([::1]:39471 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1emSMr-00006a-MF for ged-emacs-devel@m.gmane.org; Thu, 15 Feb 2018 17:51:05 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38757) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1emSIu-00065o-DQ for emacs-devel@gnu.org; Thu, 15 Feb 2018 17:47:01 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1emSIt-0000r5-Ij for emacs-devel@gnu.org; Thu, 15 Feb 2018 17:47:00 -0500 Original-Received: from mail-wm0-x22a.google.com ([2a00:1450:400c:c09::22a]:40293) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1emSIs-0000q4-0c; Thu, 15 Feb 2018 17:46:58 -0500 Original-Received: by mail-wm0-x22a.google.com with SMTP id v10so37147wmh.5; Thu, 15 Feb 2018 14:46:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=7VboQVTecLUXmfhfH0deAEyh8zYYlaTkGXwwrOU2ytg=; b=m9jgD0KTFjMXz5kMhLO7IRalieujss6JE8AcsgZsiy0ArbMspWqMwcY/pTnq46IVt4 nzqF63XMiDBj3LWB1ma5/39zxfCRfX6gw+c+qYa9j4Ca55PBx/zc+yT/98wqmHl8+Phw fIVHo1pYniWSFuJiXJLnyBUMlXEhGgRaGlw6uYWzC1sfpitUYw877c5j7DpR+tKzb4qO 4P6EVDOhVW9qTtKbNVtEtaF2u1QNPDb5WAQQQqmPPcynjbERJj2ZIu2Q6q9YkwVxcUz1 p/OIUNGhJ0MuUjWiY6p7Stvoh7RiwsB9KDt4+45QXDdt7SXcSKPSxLSgLmoziF8ELrxg Al1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=7VboQVTecLUXmfhfH0deAEyh8zYYlaTkGXwwrOU2ytg=; b=R+pJi+bXsIaaNT8Kspsh3LWJQT0EdAWDyL6pse2gxWDaFem4wORMR2+kJezGNlS6EQ 4jO5EM03Qgg2LOIDGaJIP+KLnXq8PglVh+aLGC0qN0ldxk5eDOOR9DzIc2CMKKbdLtVv 5b1LRgICxclnu7/IP6N9iX2fsEHMTDMuUZ/oB0pVp4x6k2RAj8/OLjjxcxBkHI5i+T6I q1kxumEp3Wg6EQ6jeYR26btYBwlLpvhU9hiKRoOJEw/2Q9n6VkmzOa6Gs8KQUupxQVLq hw3QgPh6jRk1Q9FX0EyU5Gk4lzEYxeVvZiZMXsP54Y16jzF6y7+hW66XAjdPsJUI2nN+ HAVg== X-Gm-Message-State: APf1xPBtqB9SjMPPAZq4h9+ptIbl6HQgSSQt53YcGylygjkGpsrt3ejp kQKNP7O5dZ0FDANmkny6XGMBHeIu X-Google-Smtp-Source: AH8x227VLVletXOpscKFTIu99TbtuDllfsPHIr1fJk9BCs0Mi+976Nzzb5oFAymMNxiQpSGL3pbH9A== X-Received: by 10.28.158.77 with SMTP id h74mr2987313wme.38.1518734816724; Thu, 15 Feb 2018 14:46:56 -0800 (PST) Original-Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-3550-f824-d1b1-bdf6.holly.idiocy.org. [2001:8b0:3f8:8129:3550:f824:d1b1:bdf6]) by smtp.gmail.com with ESMTPSA id h32sm15997376wrf.65.2018.02.15.14.46.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 15 Feb 2018 14:46:56 -0800 (PST) Content-Disposition: inline In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::22a X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:222782 Archived-At: On Thu, Feb 15, 2018 at 02:02:03PM -0800, Daniel Colascione wrote: > All fixed, I think. Thanks. I’m still seeing this: macfont.m:4057:34: error: use of undeclared identifier 'syms_of_macfont_for_pdumper' pdumper_do_now_and_after_load (syms_of_macfont_for_pdumper); I moved syms_of_macfont_for_pdumper to before syms_of_macfont to fix it. > > @@ -1646,7 +1646,7 @@ static int macfont_variation_glyphs (struct font *, int c, > > unsigned variations[256]); > > static void macfont_filter_properties (Lisp_Object, Lisp_Object); > > -static struct font_driver const macfont_driver = > > +static struct font_driver macfont_driver = > > { > > .type = LISPSYM_INITIALLY (Qmac_ct), > > .get_cache = macfont_get_cache, > > @@ -4034,6 +4034,18 @@ So we use CTFontDescriptorCreateMatchingFontDescriptor (no > > Why did you have to remove the const? macfont.m:4045:23: error: cannot assign to variable 'macfont_driver' with const-qualified type 'const struct font_driver' macfont_driver.type = Qmac_ct; ~~~~~~~~~~~~~~~~~~~ ^ macfont.m:1649:33: note: variable 'macfont_driver' declared const here static struct font_driver const macfont_driver = ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~ I think we’ll also have to copy the pdmp file into Emacs.app on install, but I don’t know enough about how that works to do it just now. -- Alan Third