From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Third Newsgroups: gmane.emacs.devel Subject: Re: Preview: portable dumper Date: Thu, 15 Feb 2018 19:30:47 +0000 Message-ID: <20180215193047.GA5448@breton.holly.idiocy.org> References: <1775923222.898447.1518559575706@mail.libero.it> <83inb0xkfx.fsf@gnu.org> <20180214203434.GA83944@breton.holly.idiocy.org> <0eef747d-0dae-e32f-477a-e72eadf1626f@dancol.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1518723093 12368 195.159.176.226 (15 Feb 2018 19:31:33 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 15 Feb 2018 19:31:33 +0000 (UTC) User-Agent: Mutt/1.9.3 (2018-01-21) Cc: Eli Zaretskii , Angelo Graziosi , emacs-devel@gnu.org To: Daniel Colascione Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Feb 15 20:31:29 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1emPF8-0000xX-Ea for ged-emacs-devel@m.gmane.org; Thu, 15 Feb 2018 20:30:54 +0100 Original-Received: from localhost ([::1]:52279 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1emPHA-0001XV-9N for ged-emacs-devel@m.gmane.org; Thu, 15 Feb 2018 14:33:00 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50622) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1emPF8-0008Gd-Tq for emacs-devel@gnu.org; Thu, 15 Feb 2018 14:30:55 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1emPF7-0001fp-Py for emacs-devel@gnu.org; Thu, 15 Feb 2018 14:30:54 -0500 Original-Received: from mail-wr0-x230.google.com ([2a00:1450:400c:c0c::230]:46126) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1emPF6-0001f1-8q; Thu, 15 Feb 2018 14:30:52 -0500 Original-Received: by mail-wr0-x230.google.com with SMTP id 34so768559wre.13; Thu, 15 Feb 2018 11:30:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=q7vhhKiAJyrgsX1kVRH9Vighbx5UA1y9vs4A+PAFuyU=; b=Fjd/VmnH39DufLFXyzxaq0r8XGul07Ob6zOkMpr7mmAfLB73tWfbtU2Z/q/1DYjV2N 3FeZv98NL4INirmvg+5+2ZW5lZ4iBX+aaTubWfXQ9Yue5iC5YyC0MOB9fcVF6w09DENP Po+wNiF2XHy1gqZ0u7yRF43e89C7OVE2q0OTQS+AKCAZaV2CR90UFQUjX47JovH+ct1w flvFIfM6IIDuqcN5G/e354NpYaBn9E4x1tvrSI9DRPBi+pVxb89bAOLC6Cp29HYXoZbn 3XF6rKWl02QWwstYae7kfo8AoC3g92y0i6wZu2nlumiD+w7FRL+3phKdLQaeLqrAoqa8 t1ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=q7vhhKiAJyrgsX1kVRH9Vighbx5UA1y9vs4A+PAFuyU=; b=qc37SEvJlong/EQvUUBsW01sf/Fl7Of/WkO7jiZ22uOj/HOPuTOw66uEo+b762by1T fvQN0xo4Tw//U2XAQAk0gxo3GL6dT5oMcrwkZy9EMz/1jKv2K5i3JeGqg3LxP9yMuThY Ep2eCMDhOHGoDTnT4TTulUi0lOE//nE1GjW8rQAqG1ua8Y0iJdYtqBrZHprYkEBJspp8 XorO/8FpA01i4c/cn8ul65DDqtVCJjdF7WYixsReHk0bE2OQ+Raf/5AtuS89ejpHUGOs rYjVpUWwE/YACRSUWaaVnQH+w/zafZFefPLywqEGwWiuNqbJwjUGt8doSaz/pR8nFcHe 5Tuw== X-Gm-Message-State: APf1xPD5rkCtQit85ahO4PV8HtSZdcbDEJe1/WeWFUxaDQsenv0oGyHG yCM8nSxjMYq2AKHVuX4ylms= X-Google-Smtp-Source: AH8x224twzq/FRgu3+5TNq3AbzJ62BepZ1I+54+NtpiaoV/NBfd2oWIpWfIKsCjbL94EkH8lS0VNig== X-Received: by 10.223.129.49 with SMTP id 46mr1337477wrm.133.1518723050952; Thu, 15 Feb 2018 11:30:50 -0800 (PST) Original-Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-3550-f824-d1b1-bdf6.holly.idiocy.org. [2001:8b0:3f8:8129:3550:f824:d1b1:bdf6]) by smtp.gmail.com with ESMTPSA id h194sm20414165wma.8.2018.02.15.11.30.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 15 Feb 2018 11:30:49 -0800 (PST) Content-Disposition: inline In-Reply-To: <0eef747d-0dae-e32f-477a-e72eadf1626f@dancol.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::230 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:222769 Archived-At: On Wed, Feb 14, 2018 at 04:49:43PM -0800, Daniel Colascione wrote: > Thanks. I've pushed a fix, I think. Got some more. I had to make this change: modified src/dispnew.c @@ -6066,7 +6066,7 @@ init_display (void) #endif /* HAVE_NTGUI */ #ifdef HAVE_NS - if (!inhibit_window_system && !will_dump) + if (!inhibit_window_system && !will_dump_p ()) { Vinitial_window_system = Qns; Vwindow_system_version = make_number (10); and now I get these: pdumper.c:2904:21: error: implicit conversion turns string literal into bool: 'char [48]' to 'bool' [-Werror,-Wstring-conversion] eassert (!"should not be dumping int: is self-representing"); ~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ./lisp.h:195:43: note: expanded from macro 'eassert' # define eassert(cond) ((void) (false && (cond))) /* Check COND compiles. */ ^~~~ pdumper.c:3217:25: error: implicit conversion loses integer precision: 'EMACS_INT' (aka 'long') to 'enum cold_op' [-Werror,-Wshorten-64-to-32] enum cold_op op = XFASTINT (XCAR (item)); ~~ ^~~~~~~~~~~~~~~~~~~~~~ pdumper.c:3390:31: error: implicit conversion loses integer precision: 'EMACS_INT' (aka 'long') to 'enum dump_fixup_type' [-Werror,-Wshorten-64-to-32] enum dump_fixup_type type = XFASTINT (XCAR (fixup)); ~~~~ ^~~~~~~~~~~~~~~~~~~~~~~ pdumper.c:3478:32: error: implicit conversion loses integer precision: 'EMACS_INT' (aka 'long') to 'enum dump_reloc_type' [-Werror,-Wshorten-64-to-32] dump_reloc_set_type (&reloc, XFASTINT (dump_pop (&lreloc))); ~~~~~~~~~~~~~~~~~~~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ pdumper.c:4726:14: error: implicit conversion from enumeration type 'const enum dump_reloc_type' to different enumeration type 'enum Lisp_Type' [-Werror,-Wenum-conversion] ? reloc->type ~~~~~~~^~~~ pdumper.c:5007:62: warning: size argument in 'memcmp' call is a comparison [-Wmemsize-comparison] if (memcmp (header->magic, dump_magic, sizeof (dump_magic) != 0)) ~~~~~~~~~~~~~~~~~~~~^~~~ pdumper.c:5007:7: note: did you mean to compare the result of 'memcmp' instead? if (memcmp (header->magic, dump_magic, sizeof (dump_magic) != 0)) ^ ~ ) pdumper.c:5007:42: note: explicitly cast the argument to size_t to silence this warning if (memcmp (header->magic, dump_magic, sizeof (dump_magic) != 0)) ^ (size_t)( ) 1 warning and 5 errors generated. I suspect some of these are because of clang. -- Alan Third