From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: Something has sped up desktop. :-) Date: Tue, 23 Jan 2018 20:47:37 +0000 Message-ID: <20180123204736.GB17044@ACM> References: <20180123194121.GA17044@ACM> <83372wnxxv.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1516740852 31084 195.159.176.226 (23 Jan 2018 20:54:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 23 Jan 2018 20:54:12 +0000 (UTC) User-Agent: Mutt/1.7.2 (2016-11-26) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jan 23 21:54:08 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ee5Zj-0006X0-8r for ged-emacs-devel@m.gmane.org; Tue, 23 Jan 2018 21:53:47 +0100 Original-Received: from localhost ([::1]:52662 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ee5bj-00038y-Ke for ged-emacs-devel@m.gmane.org; Tue, 23 Jan 2018 15:55:51 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33748) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ee5b0-00037Q-UA for emacs-devel@gnu.org; Tue, 23 Jan 2018 15:55:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ee5ax-0000l3-Ix for emacs-devel@gnu.org; Tue, 23 Jan 2018 15:55:06 -0500 Original-Received: from colin.muc.de ([193.149.48.1]:64167 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1ee5ax-0000iD-74 for emacs-devel@gnu.org; Tue, 23 Jan 2018 15:55:03 -0500 Original-Received: (qmail 41967 invoked by uid 3782); 23 Jan 2018 20:55:00 -0000 Original-Received: from acm.muc.de (p548C776C.dip0.t-ipconnect.de [84.140.119.108]) by colin.muc.de (tmda-ofmipd) with ESMTP; Tue, 23 Jan 2018 21:55:00 +0100 Original-Received: (qmail 20558 invoked by uid 1000); 23 Jan 2018 20:47:37 -0000 Content-Disposition: inline In-Reply-To: <83372wnxxv.fsf@gnu.org> X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x [fuzzy] X-Received-From: 193.149.48.1 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:222178 Archived-At: Hello, Eli. On Tue, Jan 23, 2018 at 22:05:00 +0200, Eli Zaretskii wrote: > > Date: Tue, 23 Jan 2018 19:41:21 +0000 > > From: Alan Mackenzie > > So, how come desktop is now so much faster than it was? > Profile it, then we will know. After examining the result of profiler-report (which shed no light on the speed up, but suggested functions to examine): With (elp-instrument-package "desktop-") (elp-instrument-function 'find-file-noselect) (elp-instrument-function 'find-file-noselect-1) I got (in Emacs 25.3): desktop-read 1 13.248979429 13.248979429 desktop-create-buffer 315 13.205279113 0.0419215209 desktop-restore-file-buffer 309 11.734947750 0.0379771771 find-file-noselect 309 11.717252634 0.0379199114 <========== find-file-noselect-1 309 11.308377736 0.0365966917 <========== desktop-load-file 897 0.2864683340 0.0003193626 desktop-claim-lock 1 0.03431397 0.03431397 desktop-auto-save-set-timer 5 5.2026e-05 1.04052e-05 desktop-full-file-name 4 2.9286e-05 7.3215e-06 desktop-owner 1 1.6671e-05 1.6671e-05 desktop-full-lock-name 2 1.2353e-05 6.1765e-06 desktop-list* 1 1.0389e-05 1.0389e-05 desktop-save-mode 1 9.348e-06 9.348e-06 desktop-auto-save-cancel-timer 6 7.935...e-06 1.322...e-06 desktop-auto-save-enable 2 4.168e-06 2.084e-06 desktop-auto-save-disable 1 2.324e-06 2.324e-06 desktop-restoring-frameset-p 3 1.453...e-06 4.843...e-07 desktop-restore-frameset 1 1.443e-06 1.443e-06 desktop-lazy-abort 1 2.8e-07 2.8e-07 (and in Emacs 26.0.91): desktop-read 1 4.993224913 4.993224913 desktop-create-buffer 315 4.9612332350 0.0157499467 desktop-restore-file-buffer 309 3.5642595339 0.0115348204 find-file-noselect 309 3.4490214970 0.0111618818 <========== find-file-noselect-1 309 2.9180459170 0.0094435142 <========== desktop-load-file 897 0.2635534279 0.0002938165 desktop-claim-lock 1 0.023274371 0.023274371 desktop-full-lock-name 2 2.8944e-05 1.4472e-05 desktop-full-file-name 4 2.7863e-05 6.96575e-06 desktop-owner 1 1.7113e-05 1.7113e-05 desktop-save-mode 1 1.3145e-05 1.3145e-05 desktop-auto-save-set-timer 1 1.08e-05 1.08e-05 desktop-list* 1 1.0099e-05 1.0099e-05 desktop-auto-save-enable 2 4.81e-06 2.405e-06 desktop-auto-save-disable 1 3.015e-06 3.015e-06 desktop-restore-frameset 1 1.522e-06 1.522e-06 desktop-restoring-frameset-p 3 1.483e-06 4.943...e-07 desktop-auto-save-cancel-timer 2 1.153e-06 5.765e-07 desktop-lazy-abort 1 3.61e-07 3.61e-07 . So, as a preliminary result, find-file-noselect is appreciably faster. -- Alan Mackenzie (Nuremberg, Germany).