unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Something has sped up desktop.  :-)
Date: Tue, 23 Jan 2018 20:47:37 +0000	[thread overview]
Message-ID: <20180123204736.GB17044@ACM> (raw)
In-Reply-To: <83372wnxxv.fsf@gnu.org>

Hello, Eli.

On Tue, Jan 23, 2018 at 22:05:00 +0200, Eli Zaretskii wrote:
> > Date: Tue, 23 Jan 2018 19:41:21 +0000
> > From: Alan Mackenzie <acm@muc.de>

> > So, how come desktop is now so much faster than it was?

> Profile it, then we will know.

After examining the result of profiler-report (which shed no light on
the speed up, but suggested functions to examine):

With (elp-instrument-package "desktop-")
(elp-instrument-function 'find-file-noselect)
(elp-instrument-function 'find-file-noselect-1)

I got
(in Emacs 25.3):
desktop-read                    1           13.248979429  13.248979429
desktop-create-buffer           315         13.205279113  0.0419215209
desktop-restore-file-buffer     309         11.734947750  0.0379771771
find-file-noselect              309         11.717252634  0.0379199114 <==========
find-file-noselect-1            309         11.308377736  0.0365966917 <==========
desktop-load-file               897         0.2864683340  0.0003193626
desktop-claim-lock              1           0.03431397    0.03431397
desktop-auto-save-set-timer     5           5.2026e-05    1.04052e-05
desktop-full-file-name          4           2.9286e-05    7.3215e-06
desktop-owner                   1           1.6671e-05    1.6671e-05
desktop-full-lock-name          2           1.2353e-05    6.1765e-06
desktop-list*                   1           1.0389e-05    1.0389e-05
desktop-save-mode               1           9.348e-06     9.348e-06
desktop-auto-save-cancel-timer  6           7.935...e-06  1.322...e-06
desktop-auto-save-enable        2           4.168e-06     2.084e-06
desktop-auto-save-disable       1           2.324e-06     2.324e-06
desktop-restoring-frameset-p    3           1.453...e-06  4.843...e-07
desktop-restore-frameset        1           1.443e-06     1.443e-06
desktop-lazy-abort              1           2.8e-07       2.8e-07

(and in Emacs 26.0.91):
desktop-read                    1           4.993224913   4.993224913
desktop-create-buffer           315         4.9612332350  0.0157499467
desktop-restore-file-buffer     309         3.5642595339  0.0115348204
find-file-noselect              309         3.4490214970  0.0111618818 <==========
find-file-noselect-1            309         2.9180459170  0.0094435142 <==========
desktop-load-file               897         0.2635534279  0.0002938165
desktop-claim-lock              1           0.023274371   0.023274371
desktop-full-lock-name          2           2.8944e-05    1.4472e-05
desktop-full-file-name          4           2.7863e-05    6.96575e-06
desktop-owner                   1           1.7113e-05    1.7113e-05
desktop-save-mode               1           1.3145e-05    1.3145e-05
desktop-auto-save-set-timer     1           1.08e-05      1.08e-05
desktop-list*                   1           1.0099e-05    1.0099e-05
desktop-auto-save-enable        2           4.81e-06      2.405e-06
desktop-auto-save-disable       1           3.015e-06     3.015e-06
desktop-restore-frameset        1           1.522e-06     1.522e-06
desktop-restoring-frameset-p    3           1.483e-06     4.943...e-07
desktop-auto-save-cancel-timer  2           1.153e-06     5.765e-07
desktop-lazy-abort              1           3.61e-07      3.61e-07

.  So, as a preliminary result, find-file-noselect is appreciably
faster.

-- 
Alan Mackenzie (Nuremberg, Germany).



  reply	other threads:[~2018-01-23 20:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-23 19:41 Something has sped up desktop. :-) Alan Mackenzie
2018-01-23 20:05 ` Eli Zaretskii
2018-01-23 20:47   ` Alan Mackenzie [this message]
2018-01-24 19:37     ` Stefan Monnier
2018-01-24 21:41       ` Alan Mackenzie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180123204736.GB17044@ACM \
    --to=acm@muc.de \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).