From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: Suboptimal bug fix in CC Mode. Date: Thu, 18 Jan 2018 18:00:21 +0000 Message-ID: <20180118180021.GA21934@ACM> References: <20180115220012.GA4477@ACM> <83bmhty9jf.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1516298759 4818 195.159.176.226 (18 Jan 2018 18:05:59 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 18 Jan 2018 18:05:59 +0000 (UTC) User-Agent: Mutt/1.7.2 (2016-11-26) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jan 18 19:05:55 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecEZM-0000SC-O0 for ged-emacs-devel@m.gmane.org; Thu, 18 Jan 2018 19:05:44 +0100 Original-Received: from localhost ([::1]:45464 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ecEbM-0007qm-Pq for ged-emacs-devel@m.gmane.org; Thu, 18 Jan 2018 13:07:48 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58464) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ecEaf-0007q0-TZ for emacs-devel@gnu.org; Thu, 18 Jan 2018 13:07:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ecEab-0001JC-SH for emacs-devel@gnu.org; Thu, 18 Jan 2018 13:07:05 -0500 Original-Received: from colin.muc.de ([193.149.48.1]:10498 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1ecEab-00017y-9F for emacs-devel@gnu.org; Thu, 18 Jan 2018 13:07:01 -0500 Original-Received: (qmail 86086 invoked by uid 3782); 18 Jan 2018 18:06:54 -0000 Original-Received: from acm.muc.de (p548C76DC.dip0.t-ipconnect.de [84.140.118.220]) by colin.muc.de (tmda-ofmipd) with ESMTP; Thu, 18 Jan 2018 19:06:53 +0100 Original-Received: (qmail 21962 invoked by uid 1000); 18 Jan 2018 18:00:21 -0000 Content-Disposition: inline In-Reply-To: <83bmhty9jf.fsf@gnu.org> X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x [fuzzy] X-Received-From: 193.149.48.1 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:222079 Archived-At: Hello, Eli. On Tue, Jan 16, 2018 at 19:53:56 +0200, Eli Zaretskii wrote: > > Date: Mon, 15 Jan 2018 22:00:12 +0000 > > Cc: emacs-devel@gnu.org > > From: Alan Mackenzie > > I don't think we should leave this bug in Emacs-26. > Agreed. > > Clearly, analysing the innards of "{ ... }" is not a reliable way to > > distinguish brace blocks from statement/defun blocks. Instead, more > > elaborate analysis of its context needs to be carried out. This fix > > will be quite involved, and will be considerably more extensive than a > > "one-line fix". > > Alternatively, the C99 compound literals feature could be removed from > > Emacs-26 and postponed till Emacs-27. > I suggest that you revert the fix from the release branch, but leave > it on master, and try to fix it there. Please mark the revert as "not > to be merged to master". I've now reverted that change on the emacs-26 branch, complete with a "don't merge" instruction. > Thanks. -- Alan Mackenzie (Nuremberg, Germany).