From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: Lisp primitives and their calling of the change hooks Date: Sun, 7 Jan 2018 13:56:29 +0000 Message-ID: <20180107135629.GC22254@ACM> References: <20180104155111.GB6846@ACM> <20180104211154.GC6846@ACM> <20180106151839.GB23284@ACM> <20180106202403.GD23284@ACM> <20180107113628.GA22254@ACM> <83o9m599du.fsf@gnu.org> <20180107120859.GB22254@ACM> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1515333561 6317 195.159.176.226 (7 Jan 2018 13:59:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 7 Jan 2018 13:59:21 +0000 (UTC) User-Agent: Mutt/1.7.2 (2016-11-26) Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jan 07 14:59:16 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eYBTl-0000uX-7S for ged-emacs-devel@m.gmane.org; Sun, 07 Jan 2018 14:59:13 +0100 Original-Received: from localhost ([::1]:54186 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eYBVi-0000jC-9E for ged-emacs-devel@m.gmane.org; Sun, 07 Jan 2018 09:01:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35228) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eYBVa-0000iw-8V for emacs-devel@gnu.org; Sun, 07 Jan 2018 09:01:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eYBVW-00084p-Dd for emacs-devel@gnu.org; Sun, 07 Jan 2018 09:01:06 -0500 Original-Received: from colin.muc.de ([193.149.48.1]:34124 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1eYBVW-00083d-3H for emacs-devel@gnu.org; Sun, 07 Jan 2018 09:01:02 -0500 Original-Received: (qmail 5702 invoked by uid 3782); 7 Jan 2018 14:01:00 -0000 Original-Received: from acm.muc.de (p548C75D0.dip0.t-ipconnect.de [84.140.117.208]) by colin.muc.de (tmda-ofmipd) with ESMTP; Sun, 07 Jan 2018 15:00:59 +0100 Original-Received: (qmail 22651 invoked by uid 1000); 7 Jan 2018 13:56:29 -0000 Content-Disposition: inline In-Reply-To: <20180107120859.GB22254@ACM> X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x [fuzzy] X-Received-From: 193.149.48.1 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:221666 Archived-At: Hello again, Eli. On Sun, Jan 07, 2018 at 12:08:59 +0000, Alan Mackenzie wrote: > On Sun, Jan 07, 2018 at 13:49:17 +0200, Eli Zaretskii wrote: > > > Date: Sun, 7 Jan 2018 11:36:28 +0000 > > > Cc: Eli Zaretskii , emacs-devel@gnu.org > > > From: Alan Mackenzie > > > I'm aware of exactly one further bug of this nature: in > > > zlib-decompress-region, there are no calls to the change hooks at all. > > zlib-decompress-region calls del_range, which calls the hooks. Or am > > I missing something? > Yes, you're right, sorry. There are change-hook calls for the second, > deletion, part of the operation. No hooks are called for the first > part, the insertion of the decompressed text into the buffer. So > zlib-decompress-region is still not right. > I'm going to take a careful look for any more such primitives, which > have one balanced pair of change hook calls, yet these calls only cover > part of the operation. There appear to be no more such primitives. Should I try to fix zlib-decompress-region? -- Alan Mackenzie (Nuremberg, Germany).