unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: zhang cc <ccsmile2008@outlook.com>
Cc: Eli Zaretskii <eliz@gnu.org>,
	"npostavs@gmail.com" <npostavs@gmail.com>,
	"emacs-devel@gnu.org" <emacs-devel@gnu.org>
Subject: Re: beginning-of-defun-comments bug [was: Re: 26.0.90: mark-defun problem in c-mode]
Date: Sat, 6 Jan 2018 12:00:02 +0000	[thread overview]
Message-ID: <20180106120002.GA23284@ACM> (raw)
In-Reply-To: <SG2PR0601MB14050CF46434416B5AAD1C68A81C0@SG2PR0601MB1405.apcprd06.prod.outlook.com>

Hello, Zhang, Eli, and Marcin.

On Fri, Jan 05, 2018 at 14:55:54 +0000, zhang cc wrote:

> On 4 Jan 2018, 12:28 AM +0800, Alan Mackenzie <acm@muc.de>, wrote:

> I applied the patch, and I can’t reproduce the problem now. But there
> is something I don’t known if it is intended.

Thanks for doing this test.

> With the following c code, run mark-defun with cursor in the body of
> the second function, and the comment above of the function is also
> marked.

There was a long discussion about this and related matters on
emacs-devel about a year ago, I think.  I'm assuming that this marking of
the preceding comment is in accordance with that thread on emacs-devel.

> int test_func1(int a)
> {
> int i;

> return 0;
> }
> /*
>  * aa
>  */
> int test_func2(int a)
> {
> int i;

> return 0;
> }

I've committed the change to the emacs-26 branch.

-- 
Alan Mackenzie (Nuremberg, Germany).



  reply	other threads:[~2018-01-06 12:00 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-30  9:49 26.0.90: mark-defun problem in c-mode zhang cc
2017-12-30 10:30 ` Eli Zaretskii
2017-12-30 10:34   ` Alan Mackenzie
2017-12-30 12:01     ` beginning-of-defun-comments bug [was: Re: 26.0.90: mark-defun problem in c-mode] Alan Mackenzie
2017-12-30 12:53       ` Eli Zaretskii
2017-12-30 13:05         ` Alan Mackenzie
2018-01-03  4:51           ` Marcin Borkowski
2018-01-03 16:24             ` Alan Mackenzie
2018-01-05 14:55               ` zhang cc
2018-01-06 12:00                 ` Alan Mackenzie [this message]
2018-01-06 13:54                   ` zhang cc
2018-01-07  6:25                   ` Marcin Borkowski
2018-03-26  6:57               ` Marcin Borkowski
2017-12-30 15:43         ` Alan Mackenzie
2017-12-30 18:43           ` Stephen Leake
2017-12-31 10:55             ` Alan Mackenzie
2017-12-31  4:26           ` Stefan Monnier
2017-12-31 10:50             ` Alan Mackenzie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180106120002.GA23284@ACM \
    --to=acm@muc.de \
    --cc=ccsmile2008@outlook.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=npostavs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).