From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: git history tracking across renames (and emacs support) Date: Thu, 4 Jan 2018 12:02:52 +0000 Message-ID: <20180104120252.GA6846@ACM> References: <83tvw6chqv.fsf@gnu.org> <86shbprix7.fsf_-_@dod.no> <83608kck4c.fsf@gnu.org> <544c170f-99bd-c701-3063-c697296a30a6@cs.ucla.edu> <83po6rar9c.fsf@gnu.org> <20180103182917.GC5435@ACM> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1515067524 21966 195.159.176.226 (4 Jan 2018 12:05:24 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 4 Jan 2018 12:05:24 +0000 (UTC) User-Agent: Mutt/1.7.2 (2016-11-26) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jan 04 13:05:20 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eX4Gq-0005CA-NI for ged-emacs-devel@m.gmane.org; Thu, 04 Jan 2018 13:05:16 +0100 Original-Received: from localhost ([::1]:53695 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eX4Ip-0001lp-U3 for ged-emacs-devel@m.gmane.org; Thu, 04 Jan 2018 07:07:19 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58801) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eX4Ie-0001kZ-5v for emacs-devel@gnu.org; Thu, 04 Jan 2018 07:07:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eX4IX-0002sR-G1 for emacs-devel@gnu.org; Thu, 04 Jan 2018 07:07:08 -0500 Original-Received: from colin.muc.de ([193.149.48.1]:28236 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1eX4IX-0002q9-29 for emacs-devel@gnu.org; Thu, 04 Jan 2018 07:07:01 -0500 Original-Received: (qmail 80147 invoked by uid 3782); 4 Jan 2018 12:06:59 -0000 Original-Received: from acm.muc.de (p548C72B8.dip0.t-ipconnect.de [84.140.114.184]) by colin.muc.de (tmda-ofmipd) with ESMTP; Thu, 04 Jan 2018 13:06:58 +0100 Original-Received: (qmail 6965 invoked by uid 1000); 4 Jan 2018 12:02:52 -0000 Content-Disposition: inline In-Reply-To: X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x [fuzzy] X-Received-From: 193.149.48.1 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:221586 Archived-At: Hello, Stefan. On Wed, Jan 03, 2018 at 17:45:27 -0500, Stefan Monnier wrote: > > I agree. Frequently, I am looking for recent changes in a > > particular function. C-s in the ChangeLog is much more convenient > > than a git blame (or several of them in succession) followed by > > remembering the hash of an indicated change (or several of them), > > followed by a git show (or several of them). > Hmm... could it be you haven't tried vc-region-history yet? It could indeed. > Try: > - put the region around the chunk of code of interest. > - hit C-x v h (or M-x vc-region-history if you use Emacs<26). > - enjoy pure bliss. Yes, thanks, that's nice. Incidentally, the doc string for vc-region-history is somewhat brief. > > Let's please keep these individual function change descriptions in > > the VC log (which will eventually become the ChangeLog). > I tend to agree, but the text after the ":" should focus much more on > the purpose of the change than on the description of the change itself. I've been trying to do "motivational" commit messages for some while, now. Though, most of that has been in an explanatory paragraph below the introductory line rather than in the description of each defun change. I think trying to explain the purpose of each individual change might become things like "prevent doing with a nil argument", which might not be much better than what we already have. > Stefan -- Alan Mackenzie (Nuremberg, Germany).