From: Philipp Stephani <p.stephani2@gmail.com>
To: emacs-devel@gnu.org
Cc: Philipp Stephani <phst@google.com>
Subject: [PATCH 2/2] Improve error message for old-style backquotes
Date: Fri, 29 Dec 2017 21:59:29 +0100 [thread overview]
Message-ID: <20171229205929.23584-2-phst@google.com> (raw)
In-Reply-To: <20171229205929.23584-1-phst@google.com>
* src/lread.c (load_error_old_style_backquotes): Improve error message
if no file is being loaded.
* test/src/lread-tests.el (lread-tests--force-new-style-backquotes):
Adapt test.
---
src/lread.c | 12 ++++++++++--
test/src/lread-tests.el | 3 +--
2 files changed, 11 insertions(+), 4 deletions(-)
diff --git a/src/lread.c b/src/lread.c
index 57cb0a5e48..5f8c85e769 100644
--- a/src/lread.c
+++ b/src/lread.c
@@ -1006,8 +1006,16 @@ load_error_handler (Lisp_Object data)
static _Noreturn void
load_error_old_style_backquotes (void)
{
- AUTO_STRING (format, "Loading `%s': old-style backquotes detected!");
- xsignal1 (Qerror, CALLN (Fformat_message, format, Vload_file_name));
+ if (NILP (Vload_file_name))
+ {
+ AUTO_STRING (message, "Old-style backquotes detected!");
+ xsignal1 (Qerror, message);
+ }
+ else
+ {
+ AUTO_STRING (format, "Loading `%s': old-style backquotes detected!");
+ xsignal1 (Qerror, CALLN (Fformat_message, format, Vload_file_name));
+ }
}
static void
diff --git a/test/src/lread-tests.el b/test/src/lread-tests.el
index 4dfed13be7..2ac3cdb2f0 100644
--- a/test/src/lread-tests.el
+++ b/test/src/lread-tests.el
@@ -183,8 +183,7 @@ lread-tests--last-message
(ert-deftest lread-tests--force-new-style-backquotes ()
(let ((data (should-error (read "(` (a b))"))))
- (should (equal (cdr data)
- '("Loading `nil': old-style backquotes detected!"))))
+ (should (equal (cdr data) '("Old-style backquotes detected!"))))
(should (equal (let ((force-new-style-backquotes t))
(read "(` (a b))"))
'(`(a b)))))
--
2.15.1
next prev parent reply other threads:[~2017-12-29 20:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAArVCkRj3AhF0EDaSKu7a4zu1rYOx8Ac7+Hhj6gcC3sJQRGLtg@mail.gmail.com>
2017-12-29 20:59 ` [PATCH 1/2] Add new variable to force new-style backquote interpretation Philipp Stephani
2017-12-29 20:59 ` Philipp Stephani [this message]
2017-12-30 6:19 ` Paul Eggert
2017-12-30 9:02 ` Philipp Stephani
2017-12-30 23:07 ` Paul Eggert
2017-12-30 23:29 ` Philipp Stephani
2017-12-31 0:40 ` Paul Eggert
2018-01-07 13:21 ` Philipp Stephani
2017-12-31 5:08 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171229205929.23584-2-phst@google.com \
--to=p.stephani2@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=phst@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).