unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Alan Third <alan@idiocy.org>
To: Philipp Stephani <p.stephani2@gmail.com>
Cc: Philipp Stephani <phst@google.com>, emacs-devel@gnu.org
Subject: Re: [PATCH] Allow inserting non-BMP characters
Date: Tue, 26 Dec 2017 01:26:35 +0000	[thread overview]
Message-ID: <20171226012635.GA79310@breton.holly.idiocy.org> (raw)
In-Reply-To: <20171225210115.13789-1-phst@google.com>

Well, that’s annoying. I just wrote nearly the same patch.

Yours is better.

On Mon, Dec 25, 2017 at 10:01:15PM +0100, Philipp Stephani wrote:
> * src/character.h (char_low_surrogate_p, char_high_surrogate_p)
> (surrogates_to_codepoint): New functions.
> 
> * src/nsterm.m (insertText:): Properly handle surrogate pairs.
<snip>
-- 
Alan Third



  reply	other threads:[~2017-12-26  1:26 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAArVCkRx8p_vaFKJ_kXRuoZCKVBSYr=94RJANGpU0NXvkEZv6A@mail.gmail.com>
2017-12-25 21:01 ` [PATCH] Allow inserting non-BMP characters Philipp Stephani
2017-12-26  1:26   ` Alan Third [this message]
2017-12-26  4:46   ` Eli Zaretskii
2017-12-26 10:35     ` Philipp Stephani
2017-12-26 16:11       ` Eli Zaretskii
2017-12-26 18:50         ` Philipp Stephani
2017-12-26 20:22           ` Eli Zaretskii
2017-12-26 21:36             ` Alan Third
2017-12-27  3:41               ` Eli Zaretskii
2017-12-28 11:38                 ` Alan Third
2017-12-28 12:31                   ` Philipp Stephani
2017-12-28 16:29                     ` Eli Zaretskii
2017-12-29 20:14                       ` Philipp Stephani
2017-12-29 20:27                         ` Eli Zaretskii
2018-01-07 15:51                           ` Philipp Stephani
2018-01-07 17:40                             ` Eli Zaretskii
2018-01-07 18:44                               ` Philipp Stephani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171226012635.GA79310@breton.holly.idiocy.org \
    --to=alan@idiocy.org \
    --cc=emacs-devel@gnu.org \
    --cc=p.stephani2@gmail.com \
    --cc=phst@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).