From: Alan Mackenzie <acm@muc.de>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: How long have I got? (For emacs-26 bug fixes.)
Date: Tue, 12 Dec 2017 19:24:23 +0000 [thread overview]
Message-ID: <20171212192423.GB5274@ACM> (raw)
In-Reply-To: <FE0D9BE9-B928-4318-BB33-8AA4203BCC17@gnu.org>
Hello, Eli.
On Wed, Dec 06, 2017 at 22:18:34 +0000, Eli Zaretskii wrote:
> On December 6, 2017 8:26:43 PM GMT+00:00, Alan Mackenzie <acm@muc.de> wrote:
> > Hello, Emacs.
> > I'm currently awaiting confirmatory feedback from a wonderfully
> > prolific
> > bug reporter that three CC Mode bugs actually are fixed.
> > This could arrive tomorrow, but it could take longer.
> > I would very much like these bugs to be corrected for Emacs 26. Are
> > there any plans (secret or not) for a cut off day for bug fixes?
> It depends on the severity of the bug and the risks inherent in the fix.
> In general, we still plan one more pretest, so there's time. Whether
> a given fix will be deemed safe enough and worth it to be included in
> Emacs 26 is a case by case decision.
I have heard back from the bug reporter: two of the bugs are fixed, one
is partially fixed.
Here are the three (fixed) bugs:
(i) False fontification of C++ function call as type (partially fixed,
see below).
In the following,
if ( nullptr == _someVar )
{
std::string aStr( isQueued() ? "Send" : "Write" );
bool someBool = false;
}
, "isQueued" is being fontified as a type rather than being left
unfontified as the function call it is.
(ii) Misfontified C++ member initialiser list after "throw".
In the following,
1 #define someNn 1
3 struct TheClass
4 {
5 int theABC, abcMode, theThing, abcConfig;
7 struct XMLInitFailedException
8 {
9 XMLInitFailedException(void) { }
10 ~XMLInitFailedException(void) { }
11 };
13 TheClass( void ) throw( TheClass::XMLInitFailedException )
14 : theABC( 0 ),
15 abcMode( someNn ),
16 theThing( 0 ),
17 abcConfig( 0 )
18 {
19 // do not do anything!
20 }
22 ~TheClass( void ) { }
24 };
26 int main()
27 {
28 return 0;
29 }
, the initialiser list at L14-17 is being chaotically fontified: L14 has
no face (correct), in L15 "abcMode" has function-face, on L16-17, the
two identifiers have variable-name-face.
(iii) Declaration in a C++ lambda form not fontified.
In the following:
1 struct SomeType { };
2 struct SomeOther { SomeType someMethod(void)const{return SomeType();} };
3 int main()
4 {
5 auto someLambda = [&]( const SomeOther& access )
6 {
7 const SomeType& someType = access.someMethod();
8 };
9 }
, in L7, "SomeType" and "someType" aren't getting fontified at all.
#########################################################################
The problem still remaining in (i) is in:
someStruct x ( ( nullptr != x ) ? 3 : 4 );
, the extra parens around "nullptr != x" are causing "someStruct" to
lose its fontification. I have a suspicion that this is really a
distinct bug.
Two and a half of these bugs are fixed, and I'm confident their risk
level is low. I would like to commit the fixes to the release branch.
Is that OK? (Otherwise I will commit them to master.)
> Thanks.
--
Alan Mackenzie (Nuremberg, Germany).
next prev parent reply other threads:[~2017-12-12 19:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-06 20:26 How long have I got? (For emacs-26 bug fixes.) Alan Mackenzie
2017-12-06 22:18 ` Eli Zaretskii
2017-12-12 19:24 ` Alan Mackenzie [this message]
2017-12-12 19:48 ` Eli Zaretskii
2017-12-14 21:30 ` Alan Mackenzie
2017-12-06 22:19 ` John Wiegley
2017-12-08 11:00 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171212192423.GB5274@ACM \
--to=acm@muc.de \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).