From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Flymake support for C/C++ Date: Thu, 12 Oct 2017 17:50:44 +0000 Message-ID: <20171012175044.GA6106@ACM> References: <87zi8wmmhw.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1507830801 9226 195.159.176.226 (12 Oct 2017 17:53:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 12 Oct 2017 17:53:21 +0000 (UTC) User-Agent: Mutt/1.7.2 (2016-11-26) Cc: eliz@gnu.org, npostavs@users.sourceforge.net, sdl.web@gmail.com, monnier@iro.umontreal.ca, emacs-devel@gnu.org To: =?iso-8859-1?Q?Jo=E3o_T=E1vora?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Oct 12 19:53:17 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e2hfR-00013Y-Lk for ged-emacs-devel@m.gmane.org; Thu, 12 Oct 2017 19:53:09 +0200 Original-Received: from localhost ([::1]:46662 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e2hfZ-0001Fv-2G for ged-emacs-devel@m.gmane.org; Thu, 12 Oct 2017 13:53:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46218) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e2hfP-0001Fe-Ah for emacs-devel@gnu.org; Thu, 12 Oct 2017 13:53:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e2hfK-0003D0-E8 for emacs-devel@gnu.org; Thu, 12 Oct 2017 13:53:07 -0400 Original-Received: from ocolin.muc.de ([193.149.48.4]:41003 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1e2hfK-0003CJ-31 for emacs-devel@gnu.org; Thu, 12 Oct 2017 13:53:02 -0400 Original-Received: (qmail 96352 invoked by uid 3782); 12 Oct 2017 17:52:59 -0000 Original-Received: from acm.muc.de (p548C7111.dip0.t-ipconnect.de [84.140.113.17]) by colin.muc.de (tmda-ofmipd) with ESMTP; Thu, 12 Oct 2017 19:52:57 +0200 Original-Received: (qmail 7597 invoked by uid 1000); 12 Oct 2017 17:50:44 -0000 Content-Disposition: inline In-Reply-To: <87zi8wmmhw.fsf@gmail.com> X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x [fuzzy] X-Received-From: 193.149.48.4 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:219425 Archived-At: Hello, Joćo. On Thu, Oct 12, 2017 at 16:09:15 +0100, Joćo Tįvora wrote: > Hi, > Here's a proposal for supporting Flymake in C/C++. This patch: > - Sets up Flymake in c-mode buffers (heads up Alan), but doesn't > automatically enable it. I must admit not to being too keen on CC Mode changing like this; it would spoil the unity of purpose of the mode. I've glanced through the new code, but can't quite see why it needs to be an integral part of CC Mode. What is stopping the needed setup and initialisation being in a function to be added to one of the mode's hooks: say c-mode-common-hook, or even c-initialization-hook (which are documented in the CC Mode manual)? If there is any reason why it couldn't work on a CC Mode hook, I'd far rather solve that reason (thus making the solution available for other libraries too, and preserving the unity of CC Mode). [ .... ] -- Alan Mackenzie (Nuremberg, Germany).