From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 06e452a 1/3: Allow Edebug's instrumentation to be used for other purposes Date: Wed, 11 Oct 2017 20:36:24 +0000 Message-ID: <20171011203624.GC7384@ACM> References: <20171008231448.29638.520@vcs0.savannah.gnu.org> <20171008231451.3FBBC20326@vcs0.savannah.gnu.org> <20171011200212.GA7384@ACM> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1507754360 7215 195.159.176.226 (11 Oct 2017 20:39:20 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 11 Oct 2017 20:39:20 +0000 (UTC) User-Agent: Mutt/1.7.2 (2016-11-26) Cc: Gemini Lasswell , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Oct 11 22:39:16 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e2NmR-00087G-5a for ged-emacs-devel@m.gmane.org; Wed, 11 Oct 2017 22:39:03 +0200 Original-Received: from localhost ([::1]:42596 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e2NmV-0001un-8d for ged-emacs-devel@m.gmane.org; Wed, 11 Oct 2017 16:39:07 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38289) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e2Nlt-0001ug-VT for emacs-devel@gnu.org; Wed, 11 Oct 2017 16:38:30 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e2Nlq-0008BD-Rh for emacs-devel@gnu.org; Wed, 11 Oct 2017 16:38:30 -0400 Original-Received: from ocolin.muc.de ([193.149.48.4]:18298 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1e2Nlq-0008AY-Kt for emacs-devel@gnu.org; Wed, 11 Oct 2017 16:38:26 -0400 Original-Received: (qmail 10693 invoked by uid 3782); 11 Oct 2017 20:38:25 -0000 Original-Received: from acm.muc.de (p548C7002.dip0.t-ipconnect.de [84.140.112.2]) by colin.muc.de (tmda-ofmipd) with ESMTP; Wed, 11 Oct 2017 22:38:24 +0200 Original-Received: (qmail 7658 invoked by uid 1000); 11 Oct 2017 20:36:24 -0000 Content-Disposition: inline In-Reply-To: X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x [fuzzy] X-Received-From: 193.149.48.4 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:219391 Archived-At: Hello, Stefan. On Wed, Oct 11, 2017 at 16:32:53 -0400, Stefan Monnier wrote: > > You don't say why you want to make the patch. > No, indeed. I think the patch speaks for itself, and the author of the > original code seems to agree. > > It looks to me like you want to replace a normal abnormal hook with > > a single function. This is less flexible (unless one jumps through > > hoops). > Look at the patch again: the resulting code is simpler. And if you > want, you can reimplement the previous > edebug-after-instrumentation-functions API on top of the new, because > it's actually *more* flexible. > > It is also incompatible; it will break applications which use the > > existing interface. > Yes, it changes a hook which was introduced what 3 days ago? > I promise I'll take care of the all backlash from all the previous users. Ah, OK. I got the impression this was a traditional hook. > > I'm against this incompatible change > Duly noted. > > (which I don't fully understand). > I had noticed, yes ;-) Now that I understand it better, I withdraw my objection. Thanks for the explanation! > Stefan -- Alan Mackenzie (Nuremberg, Germany).