From: Alan Mackenzie <acm@muc.de>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: Gemini Lasswell <gazally@runbox.com>, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 06e452a 1/3: Allow Edebug's instrumentation to be used for other purposes
Date: Wed, 11 Oct 2017 20:36:24 +0000 [thread overview]
Message-ID: <20171011203624.GC7384@ACM> (raw)
In-Reply-To: <jwv7ew1jup6.fsf-monnier+emacsdiffs@gnu.org>
Hello, Stefan.
On Wed, Oct 11, 2017 at 16:32:53 -0400, Stefan Monnier wrote:
> > You don't say why you want to make the patch.
> No, indeed. I think the patch speaks for itself, and the author of the
> original code seems to agree.
> > It looks to me like you want to replace a normal abnormal hook with
> > a single function. This is less flexible (unless one jumps through
> > hoops).
> Look at the patch again: the resulting code is simpler. And if you
> want, you can reimplement the previous
> edebug-after-instrumentation-functions API on top of the new, because
> it's actually *more* flexible.
> > It is also incompatible; it will break applications which use the
> > existing interface.
> Yes, it changes a hook which was introduced what 3 days ago?
> I promise I'll take care of the all backlash from all the previous users.
Ah, OK. I got the impression this was a traditional hook.
> > I'm against this incompatible change
> Duly noted.
> > (which I don't fully understand).
> I had noticed, yes ;-)
Now that I understand it better, I withdraw my objection. Thanks for
the explanation!
> Stefan
--
Alan Mackenzie (Nuremberg, Germany).
prev parent reply other threads:[~2017-10-11 20:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20171008231448.29638.520@vcs0.savannah.gnu.org>
[not found] ` <20171008231451.3FBBC20326@vcs0.savannah.gnu.org>
2017-10-09 4:13 ` [Emacs-diffs] master 06e452a 1/3: Allow Edebug's instrumentation to be used for other purposes Stefan Monnier
2017-10-11 15:44 ` Gemini Lasswell
2017-10-11 16:11 ` Stefan Monnier
2017-10-15 18:06 ` Gemini Lasswell
2017-10-16 1:30 ` Stefan Monnier
2017-10-11 20:02 ` Alan Mackenzie
2017-10-11 20:32 ` Stefan Monnier
2017-10-11 20:36 ` Alan Mackenzie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171011203624.GC7384@ACM \
--to=acm@muc.de \
--cc=emacs-devel@gnu.org \
--cc=gazally@runbox.com \
--cc=monnier@IRO.UMontreal.CA \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).