From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 06e452a 1/3: Allow Edebug's instrumentation to be used for other purposes Date: Wed, 11 Oct 2017 20:02:12 +0000 Message-ID: <20171011200212.GA7384@ACM> References: <20171008231448.29638.520@vcs0.savannah.gnu.org> <20171008231451.3FBBC20326@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1507752330 21517 195.159.176.226 (11 Oct 2017 20:05:30 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 11 Oct 2017 20:05:30 +0000 (UTC) User-Agent: Mutt/1.7.2 (2016-11-26) Cc: Gemini Lasswell , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Oct 11 22:05:20 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e2NFY-0002Qu-TB for ged-emacs-devel@m.gmane.org; Wed, 11 Oct 2017 22:05:05 +0200 Original-Received: from localhost ([::1]:42496 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e2NFc-0002vg-L7 for ged-emacs-devel@m.gmane.org; Wed, 11 Oct 2017 16:05:08 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47667) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e2NEt-0002vW-Vz for emacs-devel@gnu.org; Wed, 11 Oct 2017 16:04:24 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e2NEp-00064j-3Q for emacs-devel@gnu.org; Wed, 11 Oct 2017 16:04:23 -0400 Original-Received: from ocolin.muc.de ([193.149.48.4]:47637 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1e2NEo-00061B-Os for emacs-devel@gnu.org; Wed, 11 Oct 2017 16:04:19 -0400 Original-Received: (qmail 99539 invoked by uid 3782); 11 Oct 2017 20:04:13 -0000 Original-Received: from acm.muc.de (p548C7002.dip0.t-ipconnect.de [84.140.112.2]) by colin.muc.de (tmda-ofmipd) with ESMTP; Wed, 11 Oct 2017 22:04:13 +0200 Original-Received: (qmail 7465 invoked by uid 1000); 11 Oct 2017 20:02:12 -0000 Content-Disposition: inline In-Reply-To: X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x [fuzzy] X-Received-From: 193.149.48.4 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:219388 Archived-At: Hello, Stefan. On Mon, Oct 09, 2017 at 00:13:24 -0400, Stefan Monnier wrote: > > +@defopt edebug-after-instrumentation-functions > > +An abnormal hook run by Edebug after it instruments a form. > > +Each function is called with one argument, a form which has > > +just been instrumented by Edebug. > This seems a bit awkward. Why? How is it at all awkward? > How 'bout something like the 100% untested patch below? You don't say why you want to make the patch. It looks to me like you want to replace a normal abnormal hook with a single function. This is less flexible (unless one jumps through hoops). It is also incompatible; it will break applications which use the existing interface. Why do you want to break these applications? What benefits will the new single function scheme bring? I'm against this incompatible change (which I don't fully understand). > Stefan [ .... ] -- Alan Mackenzie (Nuremberg, Germany).